From patchwork Mon Jul 18 08:57:39 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulrich Hecht X-Patchwork-Id: 9234215 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9DD5A6089D for ; Mon, 18 Jul 2016 08:57:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8CFF320855 for ; Mon, 18 Jul 2016 08:57:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8127226B4A; Mon, 18 Jul 2016 08:57:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SBL, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2DE992094D for ; Mon, 18 Jul 2016 08:57:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751401AbcGRI5y (ORCPT ); Mon, 18 Jul 2016 04:57:54 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:36146 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389AbcGRI5x (ORCPT ); Mon, 18 Jul 2016 04:57:53 -0400 Received: by mail-lf0-f68.google.com with SMTP id 33so10905937lfw.3; Mon, 18 Jul 2016 01:57:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=m0LdFoNPLd+GsfmAZjOlVgqj36Vp6DoKoN/RO4PaTDE=; b=gJ7oQNlz1HVhbeeeb1LUnZ7QRaJMEU1d2cPLj25raKxtuljBfX08eNIuJrOIxb1m4n 16VLXtzS30WYT2UdGJPMEdI+xC5aWWmt8MBHmsT4zPM9CiaWERcTqZCAgOGTslIUShit YRAQAw2SO8Gb6A37eP7l9+vSjEcq6wnvHR+Yj7gxy/VL/QV6VIjXgz8ZgvIj0S9eJyBo ZMlbrCSK2Fjj8RxujZY9/CUy95vMRvvtrCFacf8NiwcL1fskGcdsVgpbDDAV4sAuPWBY uAva4PEjxxVbc/0fzp31qC7KcZ6VsInLi7HuT9fDvKAINtdYapNfiotKZKfQo6INS7Rw R0Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=m0LdFoNPLd+GsfmAZjOlVgqj36Vp6DoKoN/RO4PaTDE=; b=I7evBXUvvbYT3uUkDVIGB0mRZRRSCCeUAokpaggblsGIGEcfpqVsFWdcdIyCL6QKdY jXr9BcnnOo94NaTKjZ60Vc/xkO0roTitk8glTXTuMSDv1Yok8qLy3N98mYsX7I+SJxnD qAbSTzDIC1VcRKNPepj0AA7HNJgOt2WwmpDBUbbG4q5exu6FnZhC+mBFGa1YvLDvJFZP uD15CQKDr6yjT4L2T+P3JDuqhvzENaf1/XWUjsfIq9gEBdY8GrUh4CSeCvZ587Yy4j7I MxakjOZ/Rr9EJ8fB8hFzv9olbqvUzQ8krBMdXAeAxXAGIYgib2/tfv5JsRODMqU0mm2J /WfA== X-Gm-Message-State: ALyK8tLUTvb5vPqwzwo45gYqKSAQLgbJPpt/IIxnx6cznGUI3ctba8shRHnpzweAmxJJ7w== X-Received: by 10.25.149.13 with SMTP id x13mr15586907lfd.199.1468832271721; Mon, 18 Jul 2016 01:57:51 -0700 (PDT) Received: from groucho.site ([192.40.95.2]) by smtp.gmail.com with ESMTPSA id 83sm4359771ljj.14.2016.07.18.01.57.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 18 Jul 2016 01:57:51 -0700 (PDT) From: Ulrich Hecht To: geert+renesas@glider.be Cc: broonie@kernel.org, linux-spi@vger.kernel.org, linux-renesas-soc@vger.kernel.org, wsa@the-dreams.de, magnus.damm@gmail.com, Ulrich Hecht Subject: [PATCH] spi: sh-msiof: request and set cs-gpio direction to output Date: Mon, 18 Jul 2016 10:57:39 +0200 Message-Id: <1468832259-26476-1-git-send-email-ulrich.hecht+renesas@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Required for the CS signal to actually be visible to the device. Signed-off-by: Ulrich Hecht Tested-by: Geert Uytterhoeven --- drivers/spi/spi-sh-msiof.c | 25 +++++++++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c index a7934ab..d4b5772 100644 --- a/drivers/spi/spi-sh-msiof.c +++ b/drivers/spi/spi-sh-msiof.c @@ -536,15 +536,35 @@ static int sh_msiof_spi_setup(struct spi_device *spi) !!(spi->mode & SPI_LSB_FIRST), !!(spi->mode & SPI_CS_HIGH)); - if (spi->cs_gpio >= 0) - gpio_set_value(spi->cs_gpio, !(spi->mode & SPI_CS_HIGH)); + if (spi->cs_gpio >= 0 && !spi_get_ctldata(spi)) { + int status = gpio_request(spi->cs_gpio, dev_name(&spi->dev)); + + if (status) + return status; + status = gpio_direction_output(spi->cs_gpio, + !(spi->mode & SPI_CS_HIGH)); + if (status) { + gpio_free(spi->cs_gpio); + return status; + } + + spi_set_ctldata(spi, (void *)spi->cs_gpio); + } pm_runtime_put(&p->pdev->dev); return 0; } +static void sh_msiof_spi_cleanup(struct spi_device *spi) +{ + if (spi->cs_gpio >= 0) + gpio_free(spi->cs_gpio); + + spi_set_ctldata(spi, NULL); +} + static int sh_msiof_prepare_message(struct spi_master *master, struct spi_message *msg) { @@ -1232,6 +1252,7 @@ static int sh_msiof_spi_probe(struct platform_device *pdev) master->dev.of_node = pdev->dev.of_node; master->num_chipselect = p->info->num_chipselect; master->setup = sh_msiof_spi_setup; + master->cleanup = sh_msiof_spi_cleanup; master->prepare_message = sh_msiof_prepare_message; master->bits_per_word_mask = SPI_BPW_RANGE_MASK(8, 32); master->auto_runtime_pm = true;