From patchwork Thu Jul 28 16:19:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 9251457 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8CE026077C for ; Thu, 28 Jul 2016 16:19:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7DBB527D0E for ; Thu, 28 Jul 2016 16:19:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7245027D4D; Thu, 28 Jul 2016 16:19:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1F3DB27D0E for ; Thu, 28 Jul 2016 16:19:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161024AbcG1QTw (ORCPT ); Thu, 28 Jul 2016 12:19:52 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:36402 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161010AbcG1QTw (ORCPT ); Thu, 28 Jul 2016 12:19:52 -0400 Received: by mail-pf0-f196.google.com with SMTP id y134so3951373pfg.3 for ; Thu, 28 Jul 2016 09:19:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1+uD1hxGagBYfiqxc3o7SWomo+5U877wdEEOGBNOU/0=; b=PDBTCuFg1Kekl5GNZYqShI1NXrVuyZvFmmXUg3+4LkL4Aupf3S/Z4rG9a6nT+mU/1G yo/8ytDFzjgGvROuus0d6SKevybiSYxYY55vxTI2As/pRk3w0msgXnykVs4EN/kzIkJW 1ZVQedRWc52en7c3SA97QbBtLA6rpENVAYhxmgBUBqxFEK3liAqmv0V4ohc1QnaUesU4 hn2rsHdtlGY7Fr9RS/xTdtC/v04mjQ/Zof5qBDNLDf9nlzyI+7L4d8LuD1Xu3wI77DqV gifhxvssWrgDADT1arTgO2tl8h9ek4WwY7gg9AJxjsoj9hVbIDBvrVDRWdeFUv4Vn2XP racA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1+uD1hxGagBYfiqxc3o7SWomo+5U877wdEEOGBNOU/0=; b=AfXItO0xEBNsZ+EwCj/y+IPqgj+7Xiv+Xknw41frlZyHmo1IvS5nos9ks29vyrNRJQ BwcEEniFb9bBNMdBrNg5JaXxsKf7BQi169chXKkX+g2mvMPvXk/2jy9LUH/+YxcRLn+l vuSnppMwtDfoT41hbC64jLooJVe2EYQB+UXINuNqDBkn6UObQnQ1wPiQAnlrIq/8MH4o Kk86T9+QKLZAoLOBazoQ4Few84Mr/lgXNR7o+mLSR503ZeqeUuV2B7pUULPVRG/YBA/k O7N6WEzbM0qnjacVnJTMCEwl8hZ7NhbbAkep7hRRJKKdICNiROB0mEz6AOUfxhw7Ho8C SXUg== X-Gm-Message-State: AEkooutatxkFjnGCzOVXye1ux+/o2OqTGS3wajjOGezT4YS9m+i2AD9a7NKFPXNr9UV44g== X-Received: by 10.98.157.154 with SMTP id a26mr60377769pfk.68.1469722791417; Thu, 28 Jul 2016 09:19:51 -0700 (PDT) Received: from localhost.localdomain.localdomain (ec2-52-192-197-227.ap-northeast-1.compute.amazonaws.com. [52.192.197.227]) by smtp.gmail.com with ESMTPSA id o5sm18385518pfb.9.2016.07.28.09.19.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Jul 2016 09:19:51 -0700 (PDT) From: Wei Yongjun To: Mark Brown Cc: Wei Yongjun , linux-spi@vger.kernel.org Subject: [PATCH -next] spi: pic32-sqi: use list_move_tail and list_move Date: Thu, 28 Jul 2016 16:19:47 +0000 Message-Id: <1469722787-15413-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Using list_move_tail() and list_move() to simplify the code. Signed-off-by: Wei Yongjun --- drivers/spi/spi-pic32-sqi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/spi/spi-pic32-sqi.c b/drivers/spi/spi-pic32-sqi.c index c41abdd..bd1c6b5 100644 --- a/drivers/spi/spi-pic32-sqi.c +++ b/drivers/spi/spi-pic32-sqi.c @@ -253,15 +253,13 @@ static struct ring_desc *ring_desc_get(struct pic32_sqi *sqi) return NULL; rdesc = list_first_entry(&sqi->bd_list_free, struct ring_desc, list); - list_del(&rdesc->list); - list_add_tail(&rdesc->list, &sqi->bd_list_used); + list_move_tail(&rdesc->list, &sqi->bd_list_used); return rdesc; } static void ring_desc_put(struct pic32_sqi *sqi, struct ring_desc *rdesc) { - list_del(&rdesc->list); - list_add(&rdesc->list, &sqi->bd_list_free); + list_move(&rdesc->list, &sqi->bd_list_free); } static int pic32_sqi_one_transfer(struct pic32_sqi *sqi,