From patchwork Wed Aug 10 17:34:52 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 9273585 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F3CCD6075E for ; Wed, 10 Aug 2016 18:51:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E18EC283E7 for ; Wed, 10 Aug 2016 18:51:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D606628413; Wed, 10 Aug 2016 18:51:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 914D3283E7 for ; Wed, 10 Aug 2016 18:51:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933024AbcHJSvy (ORCPT ); Wed, 10 Aug 2016 14:51:54 -0400 Received: from broadband.actcorp.in ([106.51.130.53]:5885 "EHLO arvind-ThinkPad-Edge-E431" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752591AbcHJSu4 (ORCPT ); Wed, 10 Aug 2016 14:50:56 -0400 X-Greylist: delayed 2399 seconds by postgrey-1.27 at vger.kernel.org; Wed, 10 Aug 2016 14:50:55 EDT Received: by arvind-ThinkPad-Edge-E431 (Postfix, from userid 1000) id 085004E3064; Wed, 10 Aug 2016 23:04:54 +0530 (IST) From: Arvind Yadav To: broonie@kernel.org, galak@kernel.crashing.com Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Arvind Yadav Subject: [v.1] spi : spi-fsl :- Error check if cpm_muram_alloc fails and return Date: Wed, 10 Aug 2016 23:04:52 +0530 Message-Id: <1470850492-6606-1-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP cpm_muram_alloc can fail so the returned value should be checked. Signed-off-by: Arvind Yadav --- drivers/spi/spi-fsl-cpm.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/spi/spi-fsl-cpm.c b/drivers/spi/spi-fsl-cpm.c index 8f7b26e..1362e2d 100644 --- a/drivers/spi/spi-fsl-cpm.c +++ b/drivers/spi/spi-fsl-cpm.c @@ -258,6 +258,9 @@ static unsigned long fsl_spi_cpm_get_pram(struct mpc8xxx_spi *mspi) /* QE but with a dynamic pram location? */ if (mspi->flags & SPI_QE) { pram_ofs = cpm_muram_alloc(SPI_PRAM_SIZE, 64); + if (IS_ERR_VALUE(pram_ofs)) + return pram_ofs; + qe_issue_cmd(QE_ASSIGN_PAGE_TO_DEVICE, mspi->subblock, QE_CR_PROTOCOL_UNSPECIFIED, pram_ofs); return pram_ofs; @@ -269,9 +272,13 @@ static unsigned long fsl_spi_cpm_get_pram(struct mpc8xxx_spi *mspi) if (mspi->flags & SPI_CPM2) { pram_ofs = cpm_muram_alloc(SPI_PRAM_SIZE, 64); + if (IS_ERR_VALUE(pram_ofs)) + goto error_pram; + out_be16(spi_base, pram_ofs); } +error_pram: iounmap(spi_base); return pram_ofs; }