From patchwork Wed Jun 14 05:52:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Varadarajan Narayanan X-Patchwork-Id: 9785465 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 73624602D9 for ; Wed, 14 Jun 2017 05:57:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 79D962853F for ; Wed, 14 Jun 2017 05:57:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6E44128552; Wed, 14 Jun 2017 05:57:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 23F9028589 for ; Wed, 14 Jun 2017 05:57:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754564AbdFNF5A (ORCPT ); Wed, 14 Jun 2017 01:57:00 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:43974 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754364AbdFNFxk (ORCPT ); Wed, 14 Jun 2017 01:53:40 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id AE04C608C5; Wed, 14 Jun 2017 05:53:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1497419618; bh=zwDnBSf+Aq/ZI0UlT1g+BI0AWfMaBY/5ETAPAHd/zC0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XIzxaWgOowfx8nncSAG08y88IpjpsksDgdxcSz8UrWPYqmHvZOq4LjJHkYPP1LSAe jz/ype/Ts4kiuY5hq+TzJ+1r6AhCt8XkRYlUpiXSqvMo13w6wJnLVux1PU3dSjL4v0 iWE/TgXCMhr2k6uW7QRr42HnDvuLWYZvM5mnatqg= Received: from absahu-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: varada@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 22CA26095F; Wed, 14 Jun 2017 05:53:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1497419614; bh=zwDnBSf+Aq/ZI0UlT1g+BI0AWfMaBY/5ETAPAHd/zC0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YTFtetXEyLBQ2KRGah8Pct4u2KErYIeznTeMGMOwZSdBZI8Amfg1RvpXX/z0UzT21 t0A4b4LPYO9fSB/OxPrWe42/L+R2lUxCvswu6/1gQtcdYo0ExYr6mk1T0eiyKz4n+Q eTANvwCMSAPQAJ8hUEY0brv0V7oCHFFt5uJsgd1Y= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 22CA26095F Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=varada@codeaurora.org From: Varadarajan Narayanan To: broonie@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, andy.gross@linaro.org, david.brown@linaro.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org Cc: Varadarajan Narayanan Subject: [PATCH 07/18] spi: qup: Fix transaction done signaling Date: Wed, 14 Jun 2017 11:22:20 +0530 Message-Id: <1497419551-21834-8-git-send-email-varada@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1497419551-21834-1-git-send-email-varada@codeaurora.org> References: <1497419551-21834-1-git-send-email-varada@codeaurora.org> Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Wait to signal done until we get all of the interrupts we are expecting to get for a transaction. If we don't wait for the input done flag, we can be inbetween transactions when the done flag comes in and this can mess up the next transaction. Signed-off-by: Andy Gross Signed-off-by: Varadarajan Narayanan --- drivers/spi/spi-qup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c index 2124815..7c22ee4 100644 --- a/drivers/spi/spi-qup.c +++ b/drivers/spi/spi-qup.c @@ -465,7 +465,8 @@ static irqreturn_t spi_qup_qup_irq(int irq, void *dev_id) controller->xfer = xfer; spin_unlock_irqrestore(&controller->lock, flags); - if (controller->rx_bytes == xfer->len || error) + if ((controller->rx_bytes == xfer->len && + (opflags & QUP_OP_MAX_INPUT_DONE_FLAG)) || error) complete(&controller->done); return IRQ_HANDLED;