From patchwork Tue Jun 27 16:10:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aravind Thokala X-Patchwork-Id: 9812763 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 06E03603D7 for ; Tue, 27 Jun 2017 16:11:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EA79D28448 for ; Tue, 27 Jun 2017 16:11:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DD7AD286E6; Tue, 27 Jun 2017 16:11:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8590228448 for ; Tue, 27 Jun 2017 16:11:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752516AbdF0QLV (ORCPT ); Tue, 27 Jun 2017 12:11:21 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:35069 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752364AbdF0QLO (ORCPT ); Tue, 27 Jun 2017 12:11:14 -0400 Received: by mail-pg0-f66.google.com with SMTP id f127so4832902pgc.2; Tue, 27 Jun 2017 09:11:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=SXy2Py0zF4PO9125BlH4wsePYNMmjf2dazwp9QHafEE=; b=L1PclqpppX12esjqt2EiCWwQJXOrrky6GyKZBGbkjAbuzM8T2B3tVRrxH6PSIR4VUR BiKHp1Tk9ldktl5ZGP/jfOTGXSM0V5zfyqCkUAxreeqa4iUwiStjN8iYZ6NFclABpB4L S1vfyqbZkluMltkATAMe2f2ozhU6sDzjHU2MXXgwCkAcAAE8zSRYrQW81zfJktCDsJJx N9YPYon46Nl46TYw3s9z4kotGdN7vTpkUukXpzam+w2VR0SdkdqE/F9u8eVuP4C12/X0 0U5JgYfDlXTxXsYD/FCEMZ0Mk4PnyXTTJkcsraFMrqybj0ncqqTRbLqGY/vAKJzRKpi/ xilg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=SXy2Py0zF4PO9125BlH4wsePYNMmjf2dazwp9QHafEE=; b=C2TpQQcubOiCFLUCBenMqEisDNLmWOYrN1OJafWj55ZpA3VkZ5XxtJ+yHSVzZ0VzjT iTfyq4iwnvso6ex36xYthDKchtkv0XAIkgfp0VWbhfR5b8iArLxoqXwdf8cI3CeUCgo7 ltny5yqNVJUzR15OKNW5R3GptPZdEFinZWHmotfh5IWHB7RE2inXqe8MFIDJ/WkYgBxS LnubtjY8NW2J9DcyMVcO5Z7SZW5U5yvqvxL9T4VIotXV1PKsOZyTLyQx7Djw6RsBj3dx NZ2bYE/FNAD5cQYxzp0R6DIl6b1n7aN0RyHP0AKMCjXj4IOQy5eVvhCivP+eTUghXovB /3Ig== X-Gm-Message-State: AKS2vOztQFolX1KgCHTRcNuTn0BRobzGvPnweYQIRxSHZ3KbcmP7N6lC Gya85XE6FKvnLVrSL7U= X-Received: by 10.98.193.197 with SMTP id i188mr5963718pfg.215.1498579868923; Tue, 27 Jun 2017 09:11:08 -0700 (PDT) Received: from localhost.localdomain ([183.82.198.149]) by smtp.gmail.com with ESMTPSA id i186sm6923778pgd.55.2017.06.27.09.11.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 27 Jun 2017 09:11:08 -0700 (PDT) From: Aravind Thokala To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Aravind Thokala Subject: [PATCH 2/2] spi/ath79: Fix checkpatch warnings Date: Tue, 27 Jun 2017 21:40:57 +0530 Message-Id: <1498579857-10236-1-git-send-email-aravind.thk@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch fixes the checkpatch.pl warnings on the driver file. Signed-off-by: Aravind Thokala --- drivers/spi/spi-ath79.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/spi/spi-ath79.c b/drivers/spi/spi-ath79.c index b89cee1..0719bd4 100644 --- a/drivers/spi/spi-ath79.c +++ b/drivers/spi/spi-ath79.c @@ -39,15 +39,15 @@ struct ath79_spi { u32 reg_ctrl; void __iomem *base; struct clk *clk; - unsigned rrw_delay; + unsigned int rrw_delay; }; -static inline u32 ath79_spi_rr(struct ath79_spi *sp, unsigned reg) +static inline u32 ath79_spi_rr(struct ath79_spi *sp, unsigned int reg) { return ioread32(sp->base + reg); } -static inline void ath79_spi_wr(struct ath79_spi *sp, unsigned reg, u32 val) +static inline void ath79_spi_wr(struct ath79_spi *sp, unsigned int reg, u32 val) { iowrite32(val, sp->base + reg); } @@ -57,7 +57,7 @@ static inline struct ath79_spi *ath79_spidev_to_sp(struct spi_device *spi) return spi_master_get_devdata(spi->master); } -static inline void ath79_spi_delay(struct ath79_spi *sp, unsigned nsecs) +static inline void ath79_spi_delay(struct ath79_spi *sp, unsigned int nsecs) { if (nsecs > sp->rrw_delay) ndelay(nsecs - sp->rrw_delay); @@ -148,9 +148,8 @@ static int ath79_spi_setup_cs(struct spi_device *spi) static void ath79_spi_cleanup_cs(struct spi_device *spi) { - if (gpio_is_valid(spi->cs_gpio)) { + if (gpio_is_valid(spi->cs_gpio)) gpio_free(spi->cs_gpio); - } } static int ath79_spi_setup(struct spi_device *spi) @@ -176,7 +175,7 @@ static void ath79_spi_cleanup(struct spi_device *spi) spi_bitbang_cleanup(spi); } -static u32 ath79_spi_txrx_mode0(struct spi_device *spi, unsigned nsecs, +static u32 ath79_spi_txrx_mode0(struct spi_device *spi, unsigned int nsecs, u32 word, u8 bits) { struct ath79_spi *sp = ath79_spidev_to_sp(spi);