From patchwork Wed Dec 6 15:22:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Takuo Koguchi X-Patchwork-Id: 10096107 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4A09B60327 for ; Wed, 6 Dec 2017 14:46:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 78981289B5 for ; Wed, 6 Dec 2017 14:45:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6D838290FE; Wed, 6 Dec 2017 14:45:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1BB8A289B5 for ; Wed, 6 Dec 2017 14:45:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753005AbdLFOpn (ORCPT ); Wed, 6 Dec 2017 09:45:43 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33655 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752231AbdLFOpk (ORCPT ); Wed, 6 Dec 2017 09:45:40 -0500 Received: by mail-wm0-f66.google.com with SMTP id g130so23483518wme.0; Wed, 06 Dec 2017 06:45:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=cG0hmJ6DZIiRfy2nRhcuJ1SEgFrY/z7T8fXy4Dt7sas=; b=tMmq25v8UzeOFJL29t7/6ca65AGWeHxqiDQpopO3ptIZtFN2nmN0t+EDu/AegeR9Bj lS3bFy5W/5p9pQXJmAUWQ9jLEzFql/t1JjFi3+EayYJe+Rpc7bsfccAlDLJjdNhf3p+H HdqR6QbEmMdij4gTtCpqLnGHsdttout4VqULJGQziPbulWxUzVZx2+lckpqFUpQA9EZx WcSMmKnNTMM9rVwIYTuKnZ2KiXpfIpN5/MsxxfyPY9yJ0DSBxHfyOfA5YO186Sx+09He J5pjOXMm9CrCL0P3T7KLvrAnPWfS6QJVBnJH193jFYUdChHz8vkwnU7VIc/sIr31wnSu oyxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=cG0hmJ6DZIiRfy2nRhcuJ1SEgFrY/z7T8fXy4Dt7sas=; b=Bn5s3Qp6J7gO90kHr8pHOuRIcAenp4QtUaqDzuj6wk3zWmGImVzWh7JntdAoMTNrt2 NAxbjsBBZE6uECGsxxYBOFqL9334S2P1smRVfIkxni3dqiEtnX+O168vn2SKJ8gu3pOZ IJXc1q1xCUhYAHH/O5MZQDELvlnaFkMO/+BlaoDk3A+Stl7vXaQr//9a/urmJDjadBoW 1AffHD2ApnnXS/HjH5VXGQd0+1BhGxZbXDH8kW5zJV3kUQqIA+u+ovT9chpwOfNFylwZ gj9uzd7ShRqb6aJzEHnhqID6kGLaFCYfmowSTW3jeY3LkjRGchxRQxFBwJXnarFRDL1Y TkyQ== X-Gm-Message-State: AJaThX6t3bp3lUtXqx5056EwOWGp3Vz1Sku99WrsGNJEYw2IV0owxBmY 6udV8ZBXT7gYMw2nKrf3BJUS6lWEGgY= X-Google-Smtp-Source: AGs4zMYky3zP7FLXTyvdNBREUuCylXRva4xyBTDWqFFm7kNMqLw6e+cZ3h40Ida8qTQ66gznbQ2Fuw== X-Received: by 10.80.145.154 with SMTP id g26mr41182790eda.140.1512571538995; Wed, 06 Dec 2017 06:45:38 -0800 (PST) Received: from localhost.localdomain ([145.253.130.2]) by smtp.gmail.com with ESMTPSA id r15sm1291914edi.23.2017.12.06.06.45.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 06 Dec 2017 06:45:38 -0800 (PST) From: Takuo Koguchi X-Google-Original-From: Takuo Koguchi To: lkml@vger.kernel.org, khoroshilov@ispras.ru, takuo.koguchi.sw@gmail.com Cc: Takuo Koguchi , Mark Brown , Maxime Ripard , Chen-Yu Tsai , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] spi: sun4i: disable clocks in the remove function Date: Thu, 7 Dec 2017 00:22:13 +0900 Message-Id: <1512573752-13091-1-git-send-email-takuo.koguchi.sw@hitachi.com> X-Mailer: git-send-email 2.7.4 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP mclk and hclk need to be disabled explicitly since pm_runtime_disable does not disable the clocks. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Takuo Koguchi --- drivers/spi/spi-sun4i.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/spi/spi-sun4i.c b/drivers/spi/spi-sun4i.c index c5cd635..9011c09 100644 --- a/drivers/spi/spi-sun4i.c +++ b/drivers/spi/spi-sun4i.c @@ -525,6 +525,11 @@ static int sun4i_spi_probe(struct platform_device *pdev) static int sun4i_spi_remove(struct platform_device *pdev) { + struct spi_master *master = dev_get_drvdata(&pdev->dev); + struct sun4i_spi *sspi = spi_master_get_devdata(master); + + clk_disable_unprepare(sspi->mclk); + clk_disable_unprepare(sspi->hclk); pm_runtime_disable(&pdev->dev); return 0;