diff mbox

[-next] spi: fix spi-sprd-adi build errors when COMPILE_TEST=y

Message ID 1e21f485-7f06-0566-afd4-74f2bfc9606e@infradead.org (mailing list archive)
State New, archived
Headers show

Commit Message

Randy Dunlap Sept. 21, 2017, 4:10 p.m. UTC 
From: Randy Dunlap <rdunlap@infradead.org>

Fix build errors when CONFIG_HWSPINLOCK=m.

This patch fixes the build errors when COMPILE_TEST=y,
but I expect that this driver also wants HWSPINLOCK_SPRD=y (or =m
when SPI_SPRD_ADI=m).

drivers/spi/spi-sprd-adi.o: In function `sprd_adi_remove':
spi-sprd-adi.c:(.text+0x13): undefined reference to `hwspin_lock_free'
drivers/spi/spi-sprd-adi.o: In function `sprd_adi_probe':
spi-sprd-adi.c:(.text+0xf5): undefined reference to `of_hwspin_lock_get_id'
spi-sprd-adi.c:(.text+0x107): undefined reference to `hwspin_lock_request_specific'
spi-sprd-adi.c:(.text+0x22e): undefined reference to `hwspin_lock_free'
drivers/spi/spi-sprd-adi.o: In function `sprd_adi_transfer_one':
spi-sprd-adi.c:(.text+0x2eb): undefined reference to `__hwspin_lock_timeout'
spi-sprd-adi.c:(.text+0x349): undefined reference to `__hwspin_unlock'
spi-sprd-adi.c:(.text+0x389): undefined reference to `__hwspin_lock_timeout'
spi-sprd-adi.c:(.text+0x3ee): undefined reference to `__hwspin_unlock'

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Baolin Wang <Baolin.Wang@spreadtrum.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org
---
 drivers/spi/Kconfig |    1 +
 1 file changed, 1 insertion(+)



--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Mark Brown Sept. 21, 2017, 4:49 p.m. UTC | #1 
On Thu, Sep 21, 2017 at 09:10:04AM -0700, Randy Dunlap wrote:

> +++ linux-next-20170921/drivers/spi/Kconfig
> @@ -625,6 +625,7 @@ config SPI_SIRF
>  config SPI_SPRD_ADI
>  	tristate "Spreadtrum ADI controller"
>  	depends on ARCH_SPRD || COMPILE_TEST
> +	depends on HWSPINLOCK
>  	help
>  	  ADI driver based on SPI for Spreadtrum SoCs.

Why is this a more sensible fix than providing stubs for HWSPINLOCK?
Randy Dunlap Sept. 21, 2017, 6 p.m. UTC | #2 
On 09/21/17 09:49, Mark Brown wrote:
> On Thu, Sep 21, 2017 at 09:10:04AM -0700, Randy Dunlap wrote:
> 
>> +++ linux-next-20170921/drivers/spi/Kconfig
>> @@ -625,6 +625,7 @@ config SPI_SIRF
>>  config SPI_SPRD_ADI
>>  	tristate "Spreadtrum ADI controller"
>>  	depends on ARCH_SPRD || COMPILE_TEST
>> +	depends on HWSPINLOCK
>>  	help
>>  	  ADI driver based on SPI for Spreadtrum SoCs.
> 
> Why is this a more sensible fix than providing stubs for HWSPINLOCK?
> 

There are already stubs there. I'll send an updated patch.
diff mbox

Patch

--- linux-next-20170921.orig/drivers/spi/Kconfig
+++ linux-next-20170921/drivers/spi/Kconfig
@@ -625,6 +625,7 @@  config SPI_SIRF
 config SPI_SPRD_ADI
 	tristate "Spreadtrum ADI controller"
 	depends on ARCH_SPRD || COMPILE_TEST
+	depends on HWSPINLOCK
 	help
 	  ADI driver based on SPI for Spreadtrum SoCs.