From patchwork Tue Feb 7 08:07:48 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andi Shyti X-Patchwork-Id: 9559337 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0492B60216 for ; Tue, 7 Feb 2017 08:08:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EA8AA204C2 for ; Tue, 7 Feb 2017 08:08:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DD58E2818E; Tue, 7 Feb 2017 08:08:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D359A204C2 for ; Tue, 7 Feb 2017 08:08:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751927AbdBGIIt (ORCPT ); Tue, 7 Feb 2017 03:08:49 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:42461 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753318AbdBGIIX (ORCPT ); Tue, 7 Feb 2017 03:08:23 -0500 Received: from epcas1p4.samsung.com (unknown [182.195.41.48]) by mailout1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OKZ01JO1VXWAT10@mailout1.samsung.com>; Tue, 07 Feb 2017 17:08:20 +0900 (KST) Received: from epsmges5p4.samsung.com (unknown [182.195.40.66]) by epcas1p1.samsung.com (KnoxPortal) with ESMTP id 20170207080820epcas1p1fe5d7ee9dd208726ff4c70833523b188~g8ttA8CMO1673916739epcas1p1h; Tue, 7 Feb 2017 08:08:20 +0000 (GMT) Received: from epcas5p3.samsung.com ( [182.195.41.41]) by epsmges5p4.samsung.com (EPCPMTA) with SMTP id 67.16.04777.47089985; Tue, 7 Feb 2017 17:08:20 +0900 (KST) Received: from epcpsbgm2new.samsung.com (u27.gpu120.samsung.co.kr [203.254.230.27]) by epcas5p3.samsung.com (KnoxPortal) with ESMTP id 20170207080820epcas5p3a680e8126abf88d53106b23c3aab9958~g8tstJPP42551525515epcas5p3C; Tue, 7 Feb 2017 08:08:20 +0000 (GMT) X-AuditID: b6c32a58-f79746d0000012a9-74-58998074e419 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2new.samsung.com (EPCPMTA) with SMTP id 92.13.06428.47089985; Tue, 7 Feb 2017 17:08:20 +0900 (KST) Received: from gangnam.samsung ([10.113.62.47]) by mmp2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OKZ005X2VXT8320@mmp2.samsung.com>; Tue, 07 Feb 2017 17:08:20 +0900 (KST) From: Andi Shyti To: Krzysztof Kozlowski , Mark Brown Cc: Javier Martinez Canillas , linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti , Andi Shyti Subject: [PATCH] spi: s3c64xx: fix inconsistency between binding and driver Date: Tue, 07 Feb 2017 17:07:48 +0900 Message-id: <20170207080748.9524-1-andi.shyti@samsung.com> X-Mailer: git-send-email 2.11.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrBKsWRmVeSWpSXmKPExsWy7bCmpm5Jw8wIg2k/ZS22H3nGarH4x3Mm i6kPn7BZvHm7hsni/PkN7BaXd81hs5hxfh+TRePHm+wOHB7Xl3xi9ti0qpPNY0v/XXaPvi2r GD0+b5ILYI1KtclITUxJLVJIzUvOT8nMS7dV8g6Od443NTMw1DW0tDBXUshLzE21VXLxCdB1 y8wBukVJoSwxpxQoFJBYXKykb2dTlF9akqqQkV9cYqsUbWhopGdoYK5nZGSkZ2Ica2VkClSS kJrxb+NpxoIV7BU7FjWzNjBOZuti5OSQEDCRaN+ynBHCFpO4cG89UJyLQ0hgKaPEm7XLWCCc diaJpsNnGGE6Fu74yAiRmMMosejWenYI5yOjxMJJR8Cq2AQ0JZpu/wDbISLgJTFhxj2wucwC txkl5m5aAFTEwSEs4C2x5bo8SA2LgKrEpfYzrCBhXgEriRsTMiCWyUvsarvICtIqIfCYTeLX sVlgrRICshKbDjBD1LhILF9ziwnCFpZ4dXwLO4QtLfF36S2oo8sl1h7czgQxp4VR4vfLq1D/ G0vcf3APbBCzAJ9E7+8nTBDzeSU62oQgSjwktt6eADXHUWLx7dVgrUICsRJXFyxlmcAovYCR YRWjWGpBcW56arFpgYlecWJucWleul5yfu4mRnCq0YrYwfhvRtAhRgEORiUe3oYXMyKEWBPL iitzDzFKcDArifAeq50ZIcSbklhZlVqUH19UmpNafIjRFBgyE5mlRJPzgWkwryTe0MTM0MTI EgjNDc2VxHmjDCZGCAmkJ5akZqemFqQWwfQxcXBKNTCWKReZ5fXrKy/t7l18m6N2nabxhKer +Yr60nhX8r0vPLbTlWXn/+lOzufjhR6U7ZPgjZDtapa4dSNCjN3C717cddYHkjtmxN1qPD71 s2ls2SynD4wzq56vZjVxXXFzU86rq2Vn5u53d/wTluUgNyU3q4Zp16U5C6ceOZd0XvtiqukR z49v/lYrsRRnJBpqMRcVJwIAtPg8b0sDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJLMWRmVeSWpSXmKPExsVy+t9jQd2ShpkRBrPWcVlsP/KM1WLxj+dM FlMfPmGzePN2DZPF+fMb2C0u75rDZjHj/D4mi8aPN9kdODyuL/nE7LFpVSebx5b+u+wefVtW MXp83iQXwBrlZpORmpiSWqSQmpecn5KZl26rFBripmuhpJCXmJtqqxSh6xsSpKRQlphTCuQZ GaABB+cA92AlfbsEt4x/G08zFqxgr9ixqJm1gXEyWxcjJ4eEgInEwh0fGSFsMYkL99YDxbk4 hARmMUp0vOpmhXA+Mkrc/9/HBFLFJqAp0XT7B1i3iICXxIQZ98A6mAVuM0p82rWHuYuRg0NY wFtiy3V5kBoWAVWJS+1nWEHCvAJWEjcmZEAsk5fY1XaRdQIj9wJGhlWMEqkFyQXFSem5Rnmp 5XrFibnFpXnpesn5uZsYwcH6THoH4+Fd7ocYBTgYlXh4AzhnRgixJpYVV+YeYpTgYFYS4T1W CxTiTUmsrEotyo8vKs1JLT7EaAq0fyKzlGhyPjCS8kriDU3MTcyNDSzMLS1NjJTEeRtnPwsX EkhPLEnNTk0tSC2C6WPi4JRqYPTuKdv+/WX9NHXFsqmrojqO9c6tfRKgKK94/cme1u+mKwKd bqqqzvxzX29l4r638rmlO2eoW4oLy0idVBS9W7+xe8eq7MhZU2tE1r+7oPCpuWCD+3SV7x1/ Yo5/uXx2/beply6WC+xkuH3vtdXrn/fSZjQGZfy3LJhxwJy18dqXJr5vh7x2LPNSYinOSDTU Yi4qTgQAtpfYcmwCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170207080820epcas5p3a680e8126abf88d53106b23c3aab9958 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7JWI65SUG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLzthLAp?= =?UTF-8?B?G+yCvOyEseyghOyekBvssYXsnoQ=?= X-Global-Sender: =?UTF-8?B?QW5kaSBTaHl0aRtUaXplbiBQbGF0Zm9ybSBMYWIuG1NhbXN1?= =?UTF-8?B?bmcgRWxlY3Ryb25pY3MbU2VuaW9yIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170207080820epcas5p3a680e8126abf88d53106b23c3aab9958 X-RootMTR: 20170207080820epcas5p3a680e8126abf88d53106b23c3aab9958 References: Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit a92e7c3d82a1 ("spi: s3c64xx: consider the case when the CS line is not connected") introduced an inconsistency between the binding where the disconnected CS line was marked as 'no-cs-readback' while the driver was erroneously checking for 'broken-cs'. Check for 'no-cs-readback' in the driver as well. Signed-off-by: Andi Shyti Reviewed-by: Krzysztof Kozlowski --- drivers/spi/spi-s3c64xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index b8cd356d8d10..b392cca8fa4f 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -969,7 +969,7 @@ static struct s3c64xx_spi_info *s3c64xx_spi_parse_dt(struct device *dev) sci->num_cs = temp; } - sci->no_cs = of_property_read_bool(dev->of_node, "broken-cs"); + sci->no_cs = of_property_read_bool(dev->of_node, "no-cs-readback"); return sci; }