From patchwork Fri Feb 10 02:20:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andi Shyti X-Patchwork-Id: 9565917 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1F03560572 for ; Fri, 10 Feb 2017 02:20:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 06A3028538 for ; Fri, 10 Feb 2017 02:20:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EF54228548; Fri, 10 Feb 2017 02:20:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 57A5928538 for ; Fri, 10 Feb 2017 02:20:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751007AbdBJCUy (ORCPT ); Thu, 9 Feb 2017 21:20:54 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:39396 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750972AbdBJCUw (ORCPT ); Thu, 9 Feb 2017 21:20:52 -0500 Received: from epcas1p2.samsung.com (unknown [182.195.41.46]) by mailout4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OL400LR2ZU52360@mailout4.samsung.com>; Fri, 10 Feb 2017 11:20:29 +0900 (KST) Received: from epsmges1p1.samsung.com (unknown [182.195.40.68]) by epcas1p4.samsung.com (KnoxPortal) with ESMTP id 20170210022028epcas1p432965b6371db50b3cfd6acbc4a0506bf~hy51kYwn51526415264epcas1p44; Fri, 10 Feb 2017 02:20:28 +0000 (GMT) Received: from epcas1p1.samsung.com ( [182.195.41.45]) by epsmges1p1.samsung.com (Symantec Messaging Gateway) with SMTP id BF.44.06731.C632D985; Fri, 10 Feb 2017 11:20:28 +0900 (KST) Received: from epcpsbgm1new.samsung.com (u26.gpu120.samsung.co.kr [203.254.230.26]) by epcas1p1.samsung.com (KnoxPortal) with ESMTP id 20170210022028epcas1p11030d5037df9f9f43f20ea3e2e22be84~hy51Ldw1v2695526955epcas1p16; Fri, 10 Feb 2017 02:20:28 +0000 (GMT) X-AuditID: b6c32a35-f79166d000001a4b-fc-589d236c62f2 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1new.samsung.com (EPCPMTA) with SMTP id 85.73.06487.C632D985; Fri, 10 Feb 2017 11:20:28 +0900 (KST) Received: from gangnam.samsung ([10.113.62.47]) by mmp1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OL400MLIZU20O00@mmp1.samsung.com>; Fri, 10 Feb 2017 11:20:28 +0900 (KST) From: Andi Shyti To: Krzysztof Kozlowski , Mark Brown Cc: linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Andi Shyti , Andi Shyti Subject: [PATCH v2] spi: s3c64xx: fix inconsistency between binding and driver Date: Fri, 10 Feb 2017 11:20:19 +0900 Message-id: <20170210022019.12340-1-andi.shyti@samsung.com> X-Mailer: git-send-email 2.11.0 X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH++1xd7VWt+XjOLPWjaAE1+5102tpGEnMklhEpNZYF/0xxb3Y 3SwLIi18UdOgqEBjUBAMRfORomGplUiQlkSmoCaV1R+WimZPmrv13+f8zvd8zzk/DilVtcrV ZKHDg90O3kYT4bL7/TsSEmxb67N1NV0s1/H4g5y7vTwj4a69fUdwQ0PNCm6kq47gbgz1SLjS uTcKzn9vGqWTxtd35qXGlkAVYfS1BZBxoWWTSZaLUwswn4/dGuzIc+YXOqxp9MEjln0WQ5KO SWBSuGRa4+DtOI3OyDIl7C+0BcegNcW8zRt8MvGCQO/ck+p2ej1YU+AUPGn0cYZhtYwuWcuy rFafaN7FGoKSk7hgtKaDcC2En+7ytSrOo6th1SiMBEoP35q7CZGjYHiiKcjhpIrqRDDy44tM DCokMNNeS/yvGK1ckq+wirqLoHkaRJ5DUNUQvcIEtQPKxpdD+gjqANTemAi5SqkeBG2fxiQr iQ2UCdp9gyGRjNoGfa+HQ6ZKajeUT87LxGaboav8hXylGKhxAhr9I4pqRAaDOGh5JBU1GdD6 YAyJvAE+D7QpRI6FwB+xF1CnoLG3QyL6XETw89Orf9skwuTURMhISq2F2cVLctFfCZXlKlFi hMuDk//m2QuLt74T4sJmqC4rRbUo1o9WBVAUdgl2KxYYF6MVeLvgdVi1eU57CwodTLyhE119 ntWHKBLRa5S1Z+qyVXK+WCix9yEgpXSE0q6uz1Yp8/mSM9jttLi9Niz0IUPwa65I1ZF5zuD5 OTwWRp/E6Fk9wySzOpaOVsp1V7JVlJX34CKMXdj9v05ChqnPo3RrLrM+kus1aT6f6H7260jO hesW9LLsYf6anMUMMtU3kHKvIXFdEbQuP1XHE88MmTepcahKCRweMx06Zq6OSeq3xvi28Hr1 1NHdnc42c+XZZrsXleiG3/td+8y2c+Wenkz1k4re2d+xS6u3exfNcRFfzU0pz9ux/PjHjfGF tEwo4Jl4qVvg/wJXA46xRgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKLMWRmVeSWpSXmKPExsVy+t9jAd0c5bkRBh+XSVpsP/KM1WLxj+dM FlMfPmGzOH9+A7vF5V1z2CxmnN/HZNH48Sa7xYKNjxgdODyuL/nE7LFpVSebR9+WVYwenzfJ BbBEudlkpCampBYppOYl56dk5qXbKoWGuOlaKCnkJeam2ipF6PqGBCkplCXmlAJ5RgZowME5 wD1YSd8uwS3jRv92toLPXBW7+jazNzBO4exi5OSQEDCRuNHxjRXCFpO4cG89WxcjF4eQwFJG iUcfPoAlhAQ+Mkqs3a0HYrMJaEo03f7BBmKLCHhJTJhxD6yBWWAfo8SXC/tYQBLCAn4S9xc+ ZgexWQRUJQ5dvwA2iFfAWqLt/icWiG3yErvaLrJOYORewMiwilEitSC5oDgpPdcwL7Vcrzgx t7g0L10vOT93EyM4SJ9J7WA8uMv9EKMAB6MSD++EqjkRQqyJZcWVuYcYJTiYlUR4c6XmRgjx piRWVqUW5ccXleakFh9iNAU6YCKzlGhyPjCC8kriDU3MTcyNDSzMLS1NjJTEeRtnPwsXEkhP LEnNTk0tSC2C6WPi4JRqYFy2TyHlMOvE2h3RCrraGzsr4zqW9M9NKBLffOCcU5LH3VV7mTd/ 6Dufum4C5y65jXyvXnUdeGX16FBSi9WqQxNa7hgE764MMXDVt/pX8ux6aPHlXIaQ/7pSgXOM nv2QYvM96dcz0ak4/9Ia/02R1lotCxVOL3Y0WXNGXWRXa5xXwq901uqiu0osxRmJhlrMRcWJ AHeVKfloAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170210022028epcas1p11030d5037df9f9f43f20ea3e2e22be84 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?7JWI65SUG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLzthLAp?= =?UTF-8?B?G+yCvOyEseyghOyekBvssYXsnoQ=?= X-Global-Sender: =?UTF-8?B?QW5kaSBTaHl0aRtUaXplbiBQbGF0Zm9ybSBMYWIuG1NhbXN1?= =?UTF-8?B?bmcgRWxlY3Ryb25pY3MbU2VuaW9yIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170210022028epcas1p11030d5037df9f9f43f20ea3e2e22be84 X-RootMTR: 20170210022028epcas1p11030d5037df9f9f43f20ea3e2e22be84 References: Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit a92e7c3d82a1 ("spi: s3c64xx: consider the case when the CS line is not connected") introduced an inconsistency between the binding, where the disconnected CS line was marked as 'no-cs-readback', and the driver. The driver is erroneously checking for that attribute with property name of 'broken-cs'. Check for 'no-cs-readback' in the driver as well. Fixes: a92e7c3d82a1 ("spi: s3c64xx: consider the case when the CS line is not connected") Cc: Signed-off-by: Andi Shyti Reviewed-by: Krzysztof Kozlowski --- Changelog v1 -> v2 ================== v2: https://marc.info/?l=linux-kernel&m=148645493529741&w=2 - added more tags (Cc to stable, Fixes and Krzysztof's review) - reworded the commit to make it more clear where the error lays drivers/spi/spi-s3c64xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index b8cd356d8d10..b392cca8fa4f 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -969,7 +969,7 @@ static struct s3c64xx_spi_info *s3c64xx_spi_parse_dt(struct device *dev) sci->num_cs = temp; } - sci->no_cs = of_property_read_bool(dev->of_node, "broken-cs"); + sci->no_cs = of_property_read_bool(dev->of_node, "no-cs-readback"); return sci; }