From patchwork Fri Oct 13 19:54:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Trent Piepho X-Patchwork-Id: 10005819 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2DE7960230 for ; Fri, 13 Oct 2017 19:54:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 185D228C52 for ; Fri, 13 Oct 2017 19:54:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0B30928CFA; Fri, 13 Oct 2017 19:54:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5D8B428C52 for ; Fri, 13 Oct 2017 19:54:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752877AbdJMTyn (ORCPT ); Fri, 13 Oct 2017 15:54:43 -0400 Received: from mail-by2nam03on0092.outbound.protection.outlook.com ([104.47.42.92]:45376 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751632AbdJMTym (ORCPT ); Fri, 13 Oct 2017 15:54:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=impinj.onmicrosoft.com; s=selector1-impinj-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=55gXQ97WTZMPG+O8/WoD/anUpRr3G5aDSNwx1ns7KcM=; b=Uv0lovTPZFFP4YSbUXSY4PPZM7t2U4TB5BF6NphI5/VbNhOl0yplSRsdyQdTFhCy/sTcx++yNLxt8LNVcgf3LX8teFKoCWc1CLIt+doRZey4wyQyE0mrBIxhZ/btgEyxSgTXXgVlGdTEPjFIXPGAIzB9oyax1MYJswDJFSUC8jI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=tpiepho@impinj.com; Received: from impinj.com (216.243.31.162) by BN6PR06MB2803.namprd06.prod.outlook.com (10.175.127.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Fri, 13 Oct 2017 19:54:40 +0000 From: Trent Piepho To: linux-spi , linux-arm-kernel Cc: Shawn Guo , Sascha Hauer , Fabio Estevam , Greg Ungerer , Trent Piepho Subject: [PATCH 1/4] spi: imx: GPIO based chip selects should not be required Date: Fri, 13 Oct 2017 12:54:07 -0700 Message-Id: <20171013195410.30767-1-tpiepho@impinj.com> X-Mailer: git-send-email 2.13.6 MIME-Version: 1.0 X-Originating-IP: [216.243.31.162] X-ClientProxiedBy: MWHPR21CA0064.namprd21.prod.outlook.com (10.172.93.154) To BN6PR06MB2803.namprd06.prod.outlook.com (10.175.127.21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a6d87104-b4f5-4740-b987-08d512743e13 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:BN6PR06MB2803; X-Microsoft-Exchange-Diagnostics: 1; BN6PR06MB2803; 3:T6YYZxirK4/6A488zztw3jUV5aILcvGdqQcJIg5Y/bimEwUwBdZUwtu4Nlyteqwbdijwq6n9AS13t2VvlvkThtyAbK8we+WilE3VeCAGy9eNXA5pjlfvN8Sr9VzM1f5Tmg9/TKEGBt4n/kkPMeIVo9mdEVqz3Nwli0BD5pmNaUji6JUWIFHrQcUu2r7GACPqfNK+hpbRV5TFA+ujV5sl1nneh6HWNSlUcsbqFy75PZnuUvYYWXQBqhJ1gM1VAMqR; 25:ULkhhcG0hIgDxYmmbPqWf/lloxF80fhC9+aKEHaPCNI3nCjYk49RVyzJ7uSvrspjjgBfw5dd51EUkqJcT5kLx0ICS7HZxhkkIldnBFdrZQ1e2MKmIHesMHLNJLRZZxcq69heT3X3UU4flc+82vuunBnTcztoeRGoWnc1PtmY8qp3cUD0L661l/K4Lzo1CIFe9W9106YlbmU8kOOWQ/8eoltO2+h5ZiKFtoTbXyuxdF8aL9zIfSu8TElwLB26XZsHspsBsPJjVXKITzjgdZX0kP+3b/kZcF2JCa4XdNvBqUPurNqImcP/Jc/Wc6WBbSo+jHMJQFXz3VRvksAniXF20g==; 31:WP2ZP6ZbLfGbTEfO7sIWkmQkb51sXZjZQvjhSKQIy1cjNqCe8LnnI0FhYy7FH6O6evQGMJ6rwsGVsjvYUIMLQTWOIFJ1QLSfxKkWZnmPJwXMJL14Xl7QYUwC6rI+T2z93O7kYGnXjVzbm59vFbAbtDoo0c5IXePVxl0dQ++aobPTt0xSJXy4SG7lhfAcQR0zhMf3K+32zFcHg/Z+X73CyWXRJujtrZmFMCGKRWmzOvU= X-MS-TrafficTypeDiagnostic: BN6PR06MB2803: X-Microsoft-Exchange-Diagnostics: 1; BN6PR06MB2803; 20:fRD/BDx/meroxGWhR/dR1OqpbvcAjtgOLi8Z9uaegaz5RQ7o6pdhRRKQqU6bXX92pjwjvXbPcKBWaFvqzRqWySE3K+g74QWtHWS3YhAzIcyMyogAORdzRvBZ/8MstHowMkKgNAE0pjKKqJI8lSoAaQa/uHQOsF210e2k3DDc1quZ6QkRRRNTAqZTirc3qKh6X4HSbmzR3lRgZYHZGe4wGy/57cd2UmUBYZ9XND2GJb5NafmarbOx/TK4K93kvojA/yKy5l6Bc89lLxtnYgMe/v69YXE6sqmtmEWGatVgL1e8xQsb/JqwG/JW3SdMFQIwl1TUIjtgvSKuTXu4YHVBtLXumoMlfsTDJqycciraRmPZ+bzxuN45H6eeoYuJo/Yl/bcHJeWqGziq7/bTdAf15psmUpSVdBpb05UZ3ppVYr4ZGl94uQHEla/GNo2ZZzPwkpDuJM4t4nta2v2Wi4Z91zZZQSjsrrwy2hXUJWlXebFSQh2Jet7LvcSSAU/8BULQ; 4:L6aXAj0RlkhGOuuRqVPI+SP4h8q/sHVj+ULvgJBDQHPdNast+VQiGW/uh41LENPn+fkHKDfTxJ2qlwFsOgJENXQXFEU+CObe011agO7WacNj8LOOL6iX1ZHP2V3bZTtUMc2EFR8zJA3uHJVHHE8whH+T5CuZzYx26fPxlZs5i8ugFkZNP3Y2Pg5n2K//HBsXpe980DsEiU+DI+WokkGcKeOdqNBgiZYPLnQ1zVGVKcSjWdZ7XSONApSJ/9Tbvgwa X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(3002001)(93006095)(93001095)(10201501046)(6041248)(20161123560025)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN6PR06MB2803; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN6PR06MB2803; X-Forefront-PRVS: 04599F3534 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6009001)(346002)(39830400002)(376002)(199003)(189002)(47776003)(6666003)(107886003)(8656003)(4326008)(53936002)(21086003)(68736007)(66066001)(2906002)(5003940100001)(3846002)(1076002)(69596002)(33646002)(6116002)(8676002)(105586002)(55016002)(189998001)(106356001)(48376002)(478600001)(50466002)(110136005)(50986999)(97736004)(5660300001)(54906003)(50226002)(16586007)(81166006)(8936002)(316002)(305945005)(16526018)(86362001)(7736002)(25786009)(101416001)(36756003)(81156014); DIR:OUT; SFP:1102; SCL:1; SRVR:BN6PR06MB2803; H:impinj.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: impinj.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR06MB2803; 23:wEvrlZ3fNBgjk1DCeZgS7nYBFyw21JOxwk/srPdNX?= =?us-ascii?Q?Sl+VYREQAt2Q1egeEVrfL3hjMhjNubS+Mr/+YcD3VAjpxUjwJEfE8SoTXqJF?= =?us-ascii?Q?B5nkWFuzjj1mdb8lBG7aQMm/U7/aE4uANKfT5IU8sfi6TCBGYxVTj1kTAa7D?= =?us-ascii?Q?6HB4naPmbW5tx65uLb5ltYIWrMb1Xe0MSLMwpq0rmbIhxxg7E//vIzVQX2fc?= =?us-ascii?Q?A4aK5keRUx1ZmoSyBtxQ4QW/I5p+6uRitsJrhih5YEVbsRaCZliWF2Aj6Y4J?= =?us-ascii?Q?wMkrU89+OJpA/uPntIDFc6/vTaKhRYFOgbHeu0SRc0qwxTBICLsIvwg/ksoo?= =?us-ascii?Q?U4GhhIcjDKZiRdQuuLV/si18fZpLGWsFMwAZYwYGq8Bksizij+Hy+nogq9Qe?= =?us-ascii?Q?qZxek5SzUPAeFghhfJ2E61wwLHrwkVHsDh6/vRreMh2lqnVkvvLp521/OWJW?= =?us-ascii?Q?HsFzdUWVEPsON/RTGFVjvhCJ9VI9pNwb7Vz1ln6ppb1tQmzPqY8tLamgB3y7?= =?us-ascii?Q?cwXSHLxRvc2V7fzvrfuw6xCvoJSs2ILTyNup162KPyZqceaxhTJbVFkDWNvZ?= =?us-ascii?Q?3TBzAXUM7Pq2IIBcRwCWqnmbyQAq6ceC9gTIigL/idxZehLEr+TC6nb65MTn?= =?us-ascii?Q?U68W+mv8tTiX4ynw2SFGw3brfcxvxIQFUQ+v7TDVqdy4A/FDqWTtJ7ITDaZf?= =?us-ascii?Q?HRzp7GylYe08UWQ9WtpjfkqWePjIx2oEGJAmynWgerjgrQyZR/46rltF4Ize?= =?us-ascii?Q?qJP1FOAe+z92JPq6blwh4hSdHOiGvmfmnHGaPQl27Rctlp7684YRcjdLB9iC?= =?us-ascii?Q?ft/1+qSsvBce+gNSqHAmlQz1BYvd5BYB7SIW/xa2Pl8CR775wVZwXjK+j0pS?= =?us-ascii?Q?HVJmk9rbPOBh8JmacFFiwSQR+uA5gf+ZTclsR3B7uyDKpoD8LBUrtN96qLDi?= =?us-ascii?Q?fzzPIGgYQR91zy3I/1TFOG/3O6YuUzyeg0WpVNI0SCkMUN/uXQevqfAcNaN5?= =?us-ascii?Q?lUu1we8aYjU9qsWvdw6m72+PnapW1rnWp5hY0ihH+N/jSOYnExsxEMG/oiEq?= =?us-ascii?Q?hwyirkeKWaB3wS5BBAosfXrlmYGqlK0uLZpuEhB8iU6w/1SYtx1Pd9LCEA3Z?= =?us-ascii?Q?yS/GYV+xxhgSHJ074lZs1z9wkE4mbDp?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR06MB2803; 6:kzq9QytG7NC2osovBkZr4fKaAfKt3CcV/rNpbWGvEkYbbVCBdzimKGP+go0F8S/BZKXHdeVWlmd1fAtvp8mHfNfgavPCkXGSzCYeJbJMMsgaiwyp77fiwJ/aVCkLX7km2N6eaLHzIQzJt5EIXTzmhldOnV+hcTCLLaBfaeW8TN18R17XiiEelEFna+LTh/POPaNpUzkxp8hRfsUSUvFEsRdEdtcWziBW3ov1Lz0I6TGJb/LWcwvaM7Z2SpcMvlJndJNydk6VDspm+h3YwrKjW0xhQMTMBpjPR08JfqMVUvIlBXc8JhfAPDxm/LYWUjC0p8Ar0e9RvTdjyZgZ4X30mQ==; 5:Vl/SyuJnskXDd5x79vgFVCV0TNwXBBHAqWK3/E+qTDYeckn8ZaWu4QtSQoGcRWW4QsLLR6arl1JOMa6pK1TtIB6DjY7R3cyJhwz1eqKOUPd02JQCw7tta5lEjubZlTyHS49uPxNhLC3q4T9Cycl6cCqyLofbSssJUxKUyO3v8Uo=; 24:dk1yZY2AAhZEznsyIZZtE+EWSWB1uq44sHcYL5jzqJzDjLtVLi6kcvrY8abkoslOQaui9g4I2KNjxxK5l6Nj8LdP2wFTMKFSwhi8wWIWG7U=; 7:8IPRB3gmgUEAsTDKC3Nrpx+A1/VLcLIHwDpDGbiwMOe68LMXK9hO6Qy0Uuxwf1ES9a/VCVp6WeLmTjVG6syB1DRojYwvu//Hcn7Na/xkyJOeDTMxlbAxnFyCgsMvzm6J7wGs6qeLDnilzEJbC94gJFWK82/qTBWevnsD6B/P7lgSOPdFJjFSK9vFJTjd5Q/X3yjHmQbumTrEUP/u2uKk8Rmx/0F8OaRf+FPLCYIVeaA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: impinj.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2017 19:54:40.2904 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 6de70f0f-7357-4529-a415-d8cbb7e93e5e X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR06MB2803 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver will fail to load if no gpio chip selects are specified, this patch changes this so that it no longer fails. It's possible to use all native chip selects, in which case there is no reason to have a gpio chip select array. This is what happens if the *optional* device tree property "cs-gpios" is omitted. The spi core already checks for the absence of gpio chip selects in the master and assigns any slaves the gpio_cs value of -ENOENT. Signed-off-by: Trent Piepho --- drivers/spi/spi-imx.c | 29 +++++++++++++---------------- 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index babb15f07995..07e6250f2dad 100644 --- a/drivers/spi/spi-imx.c +++ b/drivers/spi/spi-imx.c @@ -1457,22 +1457,19 @@ static int spi_imx_probe(struct platform_device *pdev) goto out_clk_put; } - if (!master->cs_gpios) { - dev_err(&pdev->dev, "No CS GPIOs available\n"); - ret = -EINVAL; - goto out_clk_put; - } - - for (i = 0; i < master->num_chipselect; i++) { - if (!gpio_is_valid(master->cs_gpios[i])) - continue; - - ret = devm_gpio_request(&pdev->dev, master->cs_gpios[i], - DRIVER_NAME); - if (ret) { - dev_err(&pdev->dev, "Can't get CS GPIO %i\n", - master->cs_gpios[i]); - goto out_clk_put; + /* Request GPIO CS lines, if any */ + if (master->cs_gpios) { + for (i = 0; i < master->num_chipselect; i++) { + if (!gpio_is_valid(master->cs_gpios[i])) + continue; + + ret = devm_gpio_request(&pdev->dev, master->cs_gpios[i], + DRIVER_NAME); + if (ret) { + dev_err(&pdev->dev, "Can't get CS GPIO %i\n", + master->cs_gpios[i]); + goto out_clk_put; + } } }