| Message ID | 20180927223152.24990-1-lukma@denx.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5e9feb3544a72321553d17fcfa0c7e88435ea7ad |
| Headers | show |
| Series | spidev: Enable the Liebherr's BK4 board to work with spidev driver | expand |
On pátek 28. září 2018 0:31:52 CEST, Lukasz Majewski wrote: > With this commit the DSPI driver on the BK4 board can be used for SPI > transmission managed from user space (via /dev/spidev0.0). Hi Lukasz, I tried submitting a similar patch for another devicem but got no reaction [1]. In the meanwhile, there has been another proposal [2] which moves handling of this into userspace via udev. You might want to take a look at that mechanism instead (and perhaps send your Tested-by tag). It has worked well for me. [1] https://patchwork.kernel.org/patch/10558889/ [2] https://patchwork.kernel.org/project/spi-devel-general/list/?series=21295 Cheers, Jan
On Mon, Oct 01, 2018 at 04:20:32PM +0200, Jan Kundrát wrote: > Hi Lukasz, > I tried submitting a similar patch for another devicem but got no reaction > [1]. In the meanwhile, there has been another proposal [2] which moves As documented in SubmittingPatches please send patches to the maintainers for the code you would like to change. The normal kernel workflow is that people apply patches from their inboxes, if they aren't copied they are likely to not see the patch at all and it is much more difficult to apply patches.
Hi Jan, > On Mon, Oct 01, 2018 at 04:20:32PM +0200, Jan Kundrát wrote: > > > Hi Lukasz, > > I tried submitting a similar patch for another devicem but got no > > reaction [1]. In the meanwhile, there has been another proposal [2] > > which moves > > As documented in SubmittingPatches please send patches to the > maintainers for the code you would like to change. I'm using the ./scripts/get_maintainer.py script to obtain list of relevant people. Moreover, you may want to look for gitk -- <patch to your modified file> and add developers, who did some remarkable work in that file. Also git-blame helps. And another issue - maitainers are very often very busy (as maintaining/reviewing is not their main occupation). We would like to have a prompt response/review, but it is acceptable to wait week or two for reply.... Please also document in the ./Documentation/devicetree the introduced compatible -> there are some examples (ge,ahca) in the misc directory. > The normal kernel > workflow is that people apply patches from their inboxes, if they > aren't copied they are likely to not see the patch at all and it is > much more difficult to apply patches. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
On Tue, Oct 02, 2018 at 10:11:20AM +0200, Lukasz Majewski wrote: > > As documented in SubmittingPatches please send patches to the > > maintainers for the code you would like to change. > I'm using the ./scripts/get_maintainer.py script to obtain list of > relevant people. Your patch went to the right place (and I applied it yesterday), that was directed at Jan - the reason his patch got missed is that he didn't send it to me. > Please also document in the ./Documentation/devicetree the introduced > compatible -> there are some examples (ge,ahca) in the misc directory. Good point.
diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c index cda10719d1d1..07f4d05563ea 100644 --- a/drivers/spi/spidev.c +++ b/drivers/spi/spidev.c @@ -669,6 +669,7 @@ static const struct of_device_id spidev_dt_ids[] = { { .compatible = "lineartechnology,ltc2488" }, { .compatible = "ge,achc" }, { .compatible = "semtech,sx1301" }, + { .compatible = "lwn,bk4" }, {}, }; MODULE_DEVICE_TABLE(of, spidev_dt_ids);
With this commit the DSPI driver on the BK4 board can be used for SPI transmission managed from user space (via /dev/spidev0.0). Example usage/testing: insmod ./spi-fsl-dspi.ko ./spidev_test -D /dev/spidev0.0 -s 3000000 -v -H -b 8 -p "\xCC\x11\x22\x74" Signed-off-by: Lukasz Majewski <lukma@denx.de> --- drivers/spi/spidev.c | 1 + 1 file changed, 1 insertion(+)