| Message ID | 20181010172300.317643-5-lkundrak@v3.sk (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add support for OLPC XO 1.75 Embedded Controller | expand |
On Wed, Oct 10, 2018 at 8:23 PM Lubomir Rintel <lkundrak@v3.sk> wrote: > > Also, the header is x86 specific, while there are non-x86 OLPC machines. Same concern. as per patch 2. Also, you might want to sort headers in alphabetical order. > > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk> > --- > drivers/platform/olpc/olpc-ec.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/platform/olpc/olpc-ec.c b/drivers/platform/olpc/olpc-ec.c > index f99b183d5296..35a21c66cd0d 100644 > --- a/drivers/platform/olpc/olpc-ec.c > +++ b/drivers/platform/olpc/olpc-ec.c > @@ -15,7 +15,6 @@ > #include <linux/module.h> > #include <linux/list.h> > #include <linux/olpc-ec.h> > -#include <asm/olpc.h> > > struct ec_cmd_desc { > u8 cmd; > -- > 2.19.0 >
On Wed 2018-10-10 19:22:49, Lubomir Rintel wrote: > Also, the header is x86 specific, while there are non-x86 OLPC machines. > > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk> Acked-by: Pavel Machek <pavel@ucw.cz> > --- > drivers/platform/olpc/olpc-ec.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/platform/olpc/olpc-ec.c b/drivers/platform/olpc/olpc-ec.c > index f99b183d5296..35a21c66cd0d 100644 > --- a/drivers/platform/olpc/olpc-ec.c > +++ b/drivers/platform/olpc/olpc-ec.c > @@ -15,7 +15,6 @@ > #include <linux/module.h> > #include <linux/list.h> > #include <linux/olpc-ec.h> > -#include <asm/olpc.h> > > struct ec_cmd_desc { > u8 cmd;
Hi, thank you for the response. On Fri, 2018-10-19 at 16:05 +0300, Andy Shevchenko wrote: > On Wed, Oct 10, 2018 at 8:23 PM Lubomir Rintel <lkundrak@v3.sk> > wrote: > > Also, the header is x86 specific, while there are non-x86 OLPC > > machines. > > Same concern. as per patch 2. Which concern? If it's that it doesn't make sense in that particular place in the patch set, then I don't think so; this header is unnecessary and the patch has no other dependencies. But the changes that enable the OLPC EC platform code depend on this. > Also, you might want to sort headers in alphabetical order. But should I? Doing so in the same commit would obscure the actual change, and a separate commit would needlessly clobber git annotate. Thank you Lubo > > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk> > > --- > > drivers/platform/olpc/olpc-ec.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/platform/olpc/olpc-ec.c > > b/drivers/platform/olpc/olpc-ec.c > > index f99b183d5296..35a21c66cd0d 100644 > > --- a/drivers/platform/olpc/olpc-ec.c > > +++ b/drivers/platform/olpc/olpc-ec.c > > @@ -15,7 +15,6 @@ > > #include <linux/module.h> > > #include <linux/list.h> > > #include <linux/olpc-ec.h> > > -#include <asm/olpc.h> > > > > struct ec_cmd_desc { > > u8 cmd; > > -- > > 2.19.0 > > > >
diff --git a/drivers/platform/olpc/olpc-ec.c b/drivers/platform/olpc/olpc-ec.c index f99b183d5296..35a21c66cd0d 100644 --- a/drivers/platform/olpc/olpc-ec.c +++ b/drivers/platform/olpc/olpc-ec.c @@ -15,7 +15,6 @@ #include <linux/module.h> #include <linux/list.h> #include <linux/olpc-ec.h> -#include <asm/olpc.h> struct ec_cmd_desc { u8 cmd;
Also, the header is x86 specific, while there are non-x86 OLPC machines. Signed-off-by: Lubomir Rintel <lkundrak@v3.sk> --- drivers/platform/olpc/olpc-ec.c | 1 - 1 file changed, 1 deletion(-)