From patchwork Wed Jan 16 08:21:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 10765487 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C293E13B5 for ; Wed, 16 Jan 2019 08:21:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B28282CAE3 for ; Wed, 16 Jan 2019 08:21:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A69582D3AB; Wed, 16 Jan 2019 08:21:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 76A9F2D3A2 for ; Wed, 16 Jan 2019 08:21:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729127AbfAPIVS (ORCPT ); Wed, 16 Jan 2019 03:21:18 -0500 Received: from mail-lf1-f68.google.com ([209.85.167.68]:41965 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728726AbfAPIVS (ORCPT ); Wed, 16 Jan 2019 03:21:18 -0500 Received: by mail-lf1-f68.google.com with SMTP id c16so4172379lfj.8 for ; Wed, 16 Jan 2019 00:21:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=z27WWP/cKKdfJ/qLFUMIj0GJqLOsy7raZASVRvwLgfs=; b=jjwzezcWZEE8g8Q99D8U6tHCQjOMAkFpQQtBkBxEnUlirOIkQjKlFv+TkaHD83Qy+Q Ah23STm+kAjeMet8PZ7IdRuHqWr4QIv0VoSrWxvrB8mmXtxEu60GhD3y4y0wkhQaWv2a 1zFHm/5F/rJD92PSA0NsPgnBKeChgOmFNExe8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=z27WWP/cKKdfJ/qLFUMIj0GJqLOsy7raZASVRvwLgfs=; b=SNnbXu2fxFJHwGXRedN59F7mBXysHSagrs/54IGsu4/scAFsRTF1MfOJpvLtV4MwTl sSpBMleTHPxeZZsjcgGMFQlcqdLDNCSXbfU7/usDCSpAhN4/sc7Au1j7RFoMpaxudH3i hxGM9Zr/wk5dkrYajhU6XUADyM0SsRIUvNMG9WrcjIPhh98VYtglxMtAuqotEZQ9fW4y zSTBbsZ2zmDtbA0vV9OaK4vXqGJJ76IL9+AQmbR21155yTehZN6K7rykoZlI7+W+Wn6H orjm/Zb2+zAggv7OLZNv1Cwp271QWKdBM0mlnfdYbSqeVWC7BNXq5P/q8UnjF1+0T+UU /3bg== X-Gm-Message-State: AJcUukcjtKBPuqkTNzyvH5+r/V6yTgaHs0jYPHOpUtz3csqpTTQFEb1k 12B9Al99mb+xgQFuDFAG4+w7Tw== X-Google-Smtp-Source: ALg8bN5217BqrgrZVriZ79sphq38uZraFcfOu88crUktgYKjZARxqAGjifCLtyQSIqitW2dxmFstBg== X-Received: by 2002:a19:db82:: with SMTP id t2mr6181815lfi.130.1547626876662; Wed, 16 Jan 2019 00:21:16 -0800 (PST) Received: from genomnajs.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id z9sm1035095lfj.79.2019.01.16.00.21.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Jan 2019 00:21:15 -0800 (PST) From: Linus Walleij To: Mark Brown , linux-spi@vger.kernel.org Cc: linux-gpio@vger.kernel.org, Bartosz Golaszewski , linuxarm@huawei.com, Linus Walleij , Jan Kotas Subject: [PATCH 1/4 v3] spi: Support high CS when using descriptors Date: Wed, 16 Jan 2019 09:21:07 +0100 Message-Id: <20190116082110.5604-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP All controllers using GPIO descriptors can by definition support high CS connections, so just enforce this when registering an SPI controller. This fixes a regression where controllers were missing SPI_CS_HIGH, the drivers would fail like this: spi spi0.0: setup: unsupported mode bits 4 cdns-spi fd0b0000.spi: can't setup spi0.0, status -22 This is because as using descriptors moves the CS inversion logic over to gpiolib, all such controllers are registered with CS active high. Cc: Jan Kotas Reported-by: Jan Kotas Tested-by: Jan Kotas Fixes: f3186dd87669 ("spi: Optionally use GPIO descriptors for CS GPIOs") Signed-off-by: Linus Walleij --- ChangeLog v1->v3: - Collected Jan's Tested-by --- drivers/spi/spi.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 06b9139664a3..31696f2fc8d5 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -2336,6 +2336,11 @@ int spi_register_controller(struct spi_controller *ctlr) status = spi_get_gpio_descs(ctlr); if (status) return status; + /* + * A controller using GPIO descriptors always + * supports SPI_CS_HIGH if need be. + */ + ctlr->mode_bits |= SPI_CS_HIGH; } else { /* Legacy code path for GPIOs from DT */ status = of_spi_register_master(ctlr);