From patchwork Wed Mar 6 06:30:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Clark Wang X-Patchwork-Id: 10840441 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 19B6D17E0 for ; Wed, 6 Mar 2019 06:31:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 052992C756 for ; Wed, 6 Mar 2019 06:31:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ED8982C776; Wed, 6 Mar 2019 06:31:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 952262C756 for ; Wed, 6 Mar 2019 06:31:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729116AbfCFGbO (ORCPT ); Wed, 6 Mar 2019 01:31:14 -0500 Received: from mail-eopbgr50089.outbound.protection.outlook.com ([40.107.5.89]:43681 "EHLO EUR03-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729000AbfCFGaq (ORCPT ); Wed, 6 Mar 2019 01:30:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o+IVxQPrefSbya8gbOMGStjGMWB28FqD40Gw/UQgXL0=; b=oHBfH+mjzHrBDejelcC5Z0u400alHB9bZbUjoq6hXduzlfDsRf1opryT97Vy6OHdkkeYrUbBt8XrXk91bBpZOW7/2rL7i9Ey/OTrCa+jxxkZJJYrB+tch9HuNCMMIeCIU4EXT/FNMq2WFbsBc8JwU8gu9dZUu2HNXjA8ojGQJ/A= Received: from AM6PR04MB5016.eurprd04.prod.outlook.com (20.177.34.88) by AM6PR04MB4373.eurprd04.prod.outlook.com (20.177.38.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.19; Wed, 6 Mar 2019 06:30:41 +0000 Received: from AM6PR04MB5016.eurprd04.prod.outlook.com ([fe80::5841:afe:53fd:42bb]) by AM6PR04MB5016.eurprd04.prod.outlook.com ([fe80::5841:afe:53fd:42bb%6]) with mapi id 15.20.1665.020; Wed, 6 Mar 2019 06:30:41 +0000 From: Clark Wang To: "broonie@kernel.org" CC: "linux-spi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: [PATCH V2 4/8] spi: lpspi: add the error info of transfer speed setting Thread-Topic: [PATCH V2 4/8] spi: lpspi: add the error info of transfer speed setting Thread-Index: AQHU0+YeeShjZYAheEKu2sFsXPOkAQ== Date: Wed, 6 Mar 2019 06:30:41 +0000 Message-ID: <20190306063020.793-5-xiaoning.wang@nxp.com> References: <20190306063020.793-1-xiaoning.wang@nxp.com> In-Reply-To: <20190306063020.793-1-xiaoning.wang@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: SG2PR02CA0029.apcprd02.prod.outlook.com (2603:1096:3:18::17) To AM6PR04MB5016.eurprd04.prod.outlook.com (2603:10a6:20b:9::24) x-mailer: git-send-email 2.17.1 authentication-results: spf=none (sender IP is ) smtp.mailfrom=xiaoning.wang@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.71] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 741b5e45-65db-4368-97ae-08d6a1fd40df x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:AM6PR04MB4373; x-ms-traffictypediagnostic: AM6PR04MB4373: x-microsoft-exchange-diagnostics: =?iso-8859-1?q?1=3BAM6PR04MB4373=3B23=3AgE?= =?iso-8859-1?q?iSB44yjMG9JBryVSepKWMP2etbF6mc1IezGkf7jC5N5urn76mph30iqSySqc?= =?iso-8859-1?q?bd0zI2UW22uaRf+c/uY+mCIw0+LWyR7GxZpUcfv2obsJMizmGBmbyKe35Krm?= =?iso-8859-1?q?ZEZzb1bTDWNPzE4uUT8Lz33iIDr1AsfnzA5IyXVU7jmOJqBK49XUK0zMVV9H?= =?iso-8859-1?q?2lzhH138B+4L7sMZFajSEw35HV2VHBieVxZbO8IDzgkLWnuyRytWqMCh0qF9?= =?iso-8859-1?q?okaOrZFO9EvQzq9YKcZ0DRmj6UsvxbaezosrWYRetqG9jGuk0iadSSwyuDqD?= =?iso-8859-1?q?frY3pHFNAoG+XnXYxgS3UouXR+hPTIqatxIRrEd1BPjoR17PlIDPwI4Vxw7l?= =?iso-8859-1?q?jA/I0eRvRgZHCVykC9UpLBuv1nkGdJSt3rk48hNxK/tnEHMzfEAf1khVdcR7?= =?iso-8859-1?q?q9PNRsKHg2HyxBAy8OT1jFBC6ag1Ergk25pqgdFIfvBgWE++vwkzy/t9bXv6?= =?iso-8859-1?q?019ofaLUehMOBgTukX6HZxwFLs3QbqOBy3m1L9bMpAyx6BD2CpIhSJRNHZgD?= =?iso-8859-1?q?eFNv7BOxD71G58JdaXPEejfh4duc0eknseA8WhrcYJWuDoKgVsOhAeaNsi2M?= =?iso-8859-1?q?LwJdn2LsPMVPoHilsm4Fwnb3UPdagnCyFrRvdCgn3s/8/TlebKx9wetiHv5Z?= =?iso-8859-1?q?ecO5bvHsAHJbGyMb1nROXlW4y/bofczYMT+wwkp0qs85ekL5PtmJMJHID56b?= =?iso-8859-1?q?ytwhWZ5u1kyaSpw1A7xBpzfZmEFy+s3gJfcQYZQzF3/U39GtHN5W5IWQC5nu?= =?iso-8859-1?q?sZUfyM6mb3YAohSVjEVlW7mULd6WQhzA7f6L962x88PXBCBT/1/zaXHMvbf5?= =?iso-8859-1?q?KPltFcbJ9cc0vr5LeoTnJEVSqGiPM4coguJJONiB2b8VMmsLMp2i5eSwFkcp?= =?iso-8859-1?q?crUHjCK0NGhVZcQk8wtAruHr8b2AcHSwPWUinppJJikVa2zl4HVpzPrqww6J?= =?iso-8859-1?q?quNzOS8eCdLJagbchjTL+dFOKjOvMFupw3xlTaB6G6nmyLC0XxucxRJS0egP?= =?iso-8859-1?q?AXl4jv+D4FK6hwueqN05yTvT9AI3zGhxXsD1pf+y0wuThkOYPcGJ8n5bGfWF?= =?iso-8859-1?q?reJ0T7BE4fEW9qfi+fLuLxEQwsA2vzD2HyGM8q86QDZcxzDeBth5xZVMxww7?= =?iso-8859-1?q?HG9cPlzQOiJww2xksxA+iYV+/iQElx1J6GE2/nJalmFREnDDWLnvL9u3+J90?= =?iso-8859-1?q?QGcHlDcqa1aRSQ7sf0MNDqLtTYnGgechCUyDiy6SuSAf2qxXCZ+iiWYVk7Yu?= =?iso-8859-1?q?KKFNko/eo18/vSwSL/YWlVDuHuxvUInDPGG1IUDA=3D=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 0968D37274 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(346002)(136003)(376002)(366004)(39860400002)(396003)(199004)(189003)(97736004)(6116002)(386003)(8936002)(6506007)(106356001)(52116002)(1730700003)(8676002)(26005)(81156014)(81166006)(256004)(105586002)(102836004)(50226002)(2501003)(76176011)(99286004)(6512007)(305945005)(71200400001)(6436002)(5640700003)(6486002)(4326008)(53936002)(71190400001)(476003)(25786009)(486006)(66066001)(2616005)(7736002)(186003)(68736007)(446003)(1076003)(11346002)(54906003)(478600001)(316002)(36756003)(6916009)(2351001)(14454004)(86362001)(2906002)(5660300002)(3846002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM6PR04MB4373;H:AM6PR04MB5016.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 6PUsKQdyjpJcQASfQcPIuwy7JdZeafkBfy+AJbyUMDKn4gryVibM4dpOx2GN4ikAIBvDDyuk11WPDa0Gj2cJZzCCyScFf69KDMzrRQHKB3HXnBMbYGYQTP0XKVkjLd6jdrgxUvUEakxDzThjUK4lcmwZiantWDzbMhzYgu2d4U4o0rjNe427kp5BaAXKwMH+iD3XViCs8oVIUzN+yEndb823uvEdD9ivdNwZ42pxMjN9GlPAB70VjrL5h4n75bpZlF1/sc/VVgE5/x99cZG+ju6u0Kuwxkj2P+OiYM7F+PRj7TFsI0z6cKEbC5+RV+s3nEGtQA48Jw/T/Z73qQGpchGX7s9ZucL9ssHjV8Oz4yG9YIFQZ5eAl/WXChRiRPPoM9mmeI+0Kwvnh4dL0oMfn2iiWdO/BmKUeEoCk7DIdKY= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 741b5e45-65db-4368-97ae-08d6a1fd40df X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2019 06:30:41.0799 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4373 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add a error info when set a speed which greater than half of per-clk of spi module. The minimum SCK period is 2 cycles(CCR[SCKDIV]). So the maximum transfer speed is half of spi per-clk. Signed-off-by: Clark Wang --- V2: - No change. Resend for applying. --- drivers/spi/spi-fsl-lpspi.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 84dcb9e176b8..69635cde0e22 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -255,6 +255,13 @@ static int fsl_lpspi_set_bitrate(struct fsl_lpspi_data *fsl_lpspi) u8 prescale; perclk_rate = clk_get_rate(fsl_lpspi->clk_per); + + if (config.speed_hz > perclk_rate / 2) { + dev_err(fsl_lpspi->dev, + "per-clk should be at least two times of transfer speed"); + return -EINVAL; + } + for (prescale = 0; prescale < 8; prescale++) { scldiv = perclk_rate / (clkdivs[prescale] * config.speed_hz) - 2; @@ -304,7 +311,7 @@ static int fsl_lpspi_config(struct fsl_lpspi_data *fsl_lpspi) return 0; } -static void fsl_lpspi_setup_transfer(struct spi_device *spi, +static int fsl_lpspi_setup_transfer(struct spi_device *spi, struct spi_transfer *t) { struct fsl_lpspi_data *fsl_lpspi = @@ -337,7 +344,7 @@ static void fsl_lpspi_setup_transfer(struct spi_device *spi, else fsl_lpspi->watermark = fsl_lpspi->txfifosize; - fsl_lpspi_config(fsl_lpspi); + return fsl_lpspi_config(fsl_lpspi); } static int fsl_lpspi_slave_abort(struct spi_controller *controller) @@ -429,7 +436,10 @@ static int fsl_lpspi_transfer_one_msg(struct spi_controller *controller, msg->actual_length = 0; list_for_each_entry(xfer, &msg->transfers, transfer_list) { - fsl_lpspi_setup_transfer(spi, xfer); + ret = fsl_lpspi_setup_transfer(spi, xfer); + if (ret < 0) + goto complete; + fsl_lpspi_set_cmd(fsl_lpspi, is_first_xfer); is_first_xfer = false;