diff mbox series

[2/2] spi: pxa2xx: Unify remaing prints in pxa2xx_spi_transfer_one()

Message ID 20190329130046.27515-2-jarkko.nikula@linux.intel.com (mailing list archive)
State Accepted
Commit 748fbadf951a8b32713351e10ef989181a4b47a6
Headers show
Series [1/2] spi: pxa2xx: Use struct spi_device directly in pxa2xx_spi_transfer_one() | expand

Commit Message

Jarkko Nikula March 29, 2019, 1 p.m. UTC 
Use SPI device pointer in the remaining two error and warning prints in
pxa2xx_spi_transfer_one() instead of platform device of the controller

It make prints in the function uniform and more useful especially the
error print here as it can reveal the driver that has mapped the DMA
itself and attempts to transfer more than the maximum supported DMA
transfer length.

Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
---
 drivers/spi/spi-pxa2xx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
index 6d935f351616..6160fe0ce7ab 100644
--- a/drivers/spi/spi-pxa2xx.c
+++ b/drivers/spi/spi-pxa2xx.c
@@ -943,7 +943,7 @@  static int pxa2xx_spi_transfer_one(struct spi_controller *controller,
 		/* reject already-mapped transfers; PIO won't always work */
 		if (message->is_dma_mapped
 				|| transfer->rx_dma || transfer->tx_dma) {
-			dev_err(&drv_data->pdev->dev,
+			dev_err(&spi->dev,
 				"Mapped transfer length of %u is greater than %d\n",
 				transfer->len, MAX_DMA_LEN);
 			return -EINVAL;
@@ -957,7 +957,7 @@  static int pxa2xx_spi_transfer_one(struct spi_controller *controller,
 
 	/* Setup the transfer state based on the type of transfer */
 	if (pxa2xx_spi_flush(drv_data) == 0) {
-		dev_err(&drv_data->pdev->dev, "Flush failed\n");
+		dev_err(&spi->dev, "Flush failed\n");
 		return -EIO;
 	}
 	drv_data->n_bytes = chip->n_bytes;