| Message ID | 20190429162246.6061-1-olof@lixom.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ab7b7c715e9a3b74d4e2ee33e6cd5d1bde5332cc |
| Headers | show |
| Series | spi: zynqmp: Fix build break | expand |
On 29. 04. 19 9:22, Olof Johansson wrote: > Missing include: > drivers/spi/spi-zynqmp-gqspi.c:1025:13: error: implicit declaration of > function 'zynqmp_pm_get_eemi_ops'; did you mean > 'zynqmp_process_dma_irq'? [-Werror=implicit-function-declaration] > > Fixes: 3d0313786470a ('drivers: Defer probe if firmware is not ready') > Cc: Rajan Vaja <rajan.vaja@xilinx.com> > Cc: Jolly Shah <jollys@xilinx.com> > Cc: Michal Simek <michal.simek@xilinx.com> > Signed-off-by: Olof Johansson <olof@lixom.net> > --- > drivers/spi/spi-zynqmp-gqspi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/spi/spi-zynqmp-gqspi.c b/drivers/spi/spi-zynqmp-gqspi.c > index d07b6f940f9f..9850a0efe85a 100644 > --- a/drivers/spi/spi-zynqmp-gqspi.c > +++ b/drivers/spi/spi-zynqmp-gqspi.c > @@ -14,6 +14,7 @@ > #include <linux/delay.h> > #include <linux/dma-mapping.h> > #include <linux/dmaengine.h> > +#include <linux/firmware/xlnx-zynqmp.h> > #include <linux/interrupt.h> > #include <linux/io.h> > #include <linux/module.h> > Acked-by: Michal Simek <michal.simek@xilinx.com> Thanks, Michal
Hello: The following patches were marked "accepted", because they were applied to broonie/spi.git (refs/heads/for-next): Patch: [v1] dmaengine: idma64: Use actual device for DMA transfers Submitter: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Patchwork: https://patchwork.kernel.org/project/spi-devel-general/list/?series=93067 Patch: spi: zynqmp: Fix build break Submitter: Olof Johansson <olof@lixom.net> Patchwork: https://patchwork.kernel.org/project/spi-devel-general/list/?series=111559 Total patches: 2
On Mon, Apr 29, 2019 at 09:22:46AM -0700, Olof Johansson wrote: > Missing include: > drivers/spi/spi-zynqmp-gqspi.c:1025:13: error: implicit declaration of > function 'zynqmp_pm_get_eemi_ops'; did you mean > 'zynqmp_process_dma_irq'? [-Werror=implicit-function-declaration] > > Fixes: 3d0313786470a ('drivers: Defer probe if firmware is not ready') Please copy maintainers on patches so they aren't surprised when they get mails saying they accepted patches they never heard of before!
diff --git a/drivers/spi/spi-zynqmp-gqspi.c b/drivers/spi/spi-zynqmp-gqspi.c index d07b6f940f9f..9850a0efe85a 100644 --- a/drivers/spi/spi-zynqmp-gqspi.c +++ b/drivers/spi/spi-zynqmp-gqspi.c @@ -14,6 +14,7 @@ #include <linux/delay.h> #include <linux/dma-mapping.h> #include <linux/dmaengine.h> +#include <linux/firmware/xlnx-zynqmp.h> #include <linux/interrupt.h> #include <linux/io.h> #include <linux/module.h>
Missing include: drivers/spi/spi-zynqmp-gqspi.c:1025:13: error: implicit declaration of function 'zynqmp_pm_get_eemi_ops'; did you mean 'zynqmp_process_dma_irq'? [-Werror=implicit-function-declaration] Fixes: 3d0313786470a ('drivers: Defer probe if firmware is not ready') Cc: Rajan Vaja <rajan.vaja@xilinx.com> Cc: Jolly Shah <jollys@xilinx.com> Cc: Michal Simek <michal.simek@xilinx.com> Signed-off-by: Olof Johansson <olof@lixom.net> --- drivers/spi/spi-zynqmp-gqspi.c | 1 + 1 file changed, 1 insertion(+)