| Message ID | 20190618162818.24415-1-vz@mleia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f56943699463478617b235930252261d5277bd46 |
| Headers | show |
| Series | spi: don't open code list_for_each_entry_safe_reverse() | expand |
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 74113ee9ce44..ebef6d4a6792 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -2740,12 +2740,9 @@ EXPORT_SYMBOL_GPL(spi_res_add); */ void spi_res_release(struct spi_controller *ctlr, struct spi_message *message) { - struct spi_res *res; - - while (!list_empty(&message->resources)) { - res = list_last_entry(&message->resources, - struct spi_res, entry); + struct spi_res *res, *tmp; + list_for_each_entry_safe_reverse(res, tmp, &message->resources, entry) { if (res->release) res->release(ctlr, message, res->data);
The loop declaration in function spi_res_release() can be simplified by reusing the common list_for_each_entry_safe_reverse() helper macro. Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> --- drivers/spi/spi.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)