| Message ID | 20200315134416.16527-4-sam@ravnborg.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: display: convert remaning panel bindings to DT Schema | expand |
On Sun, Mar 15, 2020 at 02:43:43PM +0100, Sam Ravnborg wrote: > The binding for this panel is a SPI slave. > Reference spi-slave.yaml > to avoid duplicating all properties. > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > Cc: Jonathan Bakker <xc-racer2@live.ca> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Sam Ravnborg <sam@ravnborg.org> > --- > .../display/panel/samsung,s6e63m0.txt | 33 ----------- > .../display/panel/samsung,s6e63m0.yaml | 58 +++++++++++++++++++ > 2 files changed, 58 insertions(+), 33 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.txt > create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.txt b/Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.txt > deleted file mode 100644 > index 9fb9ebeef8e4..000000000000 > --- a/Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.txt > +++ /dev/null > @@ -1,33 +0,0 @@ > -Samsung s6e63m0 AMOLED LCD panel > - > -Required properties: > - - compatible: "samsung,s6e63m0" > - - reset-gpios: GPIO spec for reset pin > - - vdd3-supply: VDD regulator > - - vci-supply: VCI regulator > - > -The panel must obey rules for SPI slave device specified in document [1]. > - > -The device node can contain one 'port' child node with one child > -'endpoint' node, according to the bindings defined in [2]. This > -node should describe panel's video bus. > - > -[1]: Documentation/devicetree/bindings/spi/spi-bus.txt > -[2]: Documentation/devicetree/bindings/media/video-interfaces.txt > - > -Example: > - > - s6e63m0: display@0 { > - compatible = "samsung,s6e63m0"; > - reg = <0>; > - reset-gpio = <&mp05 5 1>; > - vdd3-supply = <&ldo12_reg>; > - vci-supply = <&ldo11_reg>; > - spi-max-frequency = <1200000>; > - > - port { > - lcd_ep: endpoint { > - remote-endpoint = <&fimd_ep>; > - }; > - }; > - }; > diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.yaml > new file mode 100644 > index 000000000000..204ed76da84d > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.yaml > @@ -0,0 +1,58 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/samsung,s6e63m0.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung s6e63m0 AMOLED LCD panel > + > +maintainers: > + - Jonathan Bakker <xc-racer2@live.ca> > + > +allOf: > + - $ref: ../../spi/spi-slave.yaml# > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: samsung,s6e63m0 > + > + reg: true > + reset-gpios: true > + port: true > + > + vdd3-supply: > + description: VDD regulator > + > + vci-supply: > + description: VCI regulator > + > +required: > + - compatible > + - reset-gpios > + - vdd3-supply > + - vci-supply Shouldn't port be required? Not really clear in the binding doc, but in the driver it doesn't look like display data goes over spi. Rob > + > +examples: > + - | > + spi { > + reg = <0xf00 0x20>; Drop this or do 'spi@f00'. If it doesn't warn with W=1, it's only a matter of time. > + #address-cells = <1>; > + #size-cells = <0>; > + display@0 { > + compatible = "samsung,s6e63m0"; > + reg = <0>; > + reset-gpios = <&mp05 5 1>; > + vdd3-supply = <&ldo12_reg>; > + vci-supply = <&ldo11_reg>; > + spi-max-frequency = <1200000>; > + > + port { > + lcd_ep: endpoint { > + remote-endpoint = <&fimd_ep>; > + }; > + }; > + }; > + }; > + > +... > -- > 2.20.1 >
diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.txt b/Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.txt deleted file mode 100644 index 9fb9ebeef8e4..000000000000 --- a/Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.txt +++ /dev/null @@ -1,33 +0,0 @@ -Samsung s6e63m0 AMOLED LCD panel - -Required properties: - - compatible: "samsung,s6e63m0" - - reset-gpios: GPIO spec for reset pin - - vdd3-supply: VDD regulator - - vci-supply: VCI regulator - -The panel must obey rules for SPI slave device specified in document [1]. - -The device node can contain one 'port' child node with one child -'endpoint' node, according to the bindings defined in [2]. This -node should describe panel's video bus. - -[1]: Documentation/devicetree/bindings/spi/spi-bus.txt -[2]: Documentation/devicetree/bindings/media/video-interfaces.txt - -Example: - - s6e63m0: display@0 { - compatible = "samsung,s6e63m0"; - reg = <0>; - reset-gpio = <&mp05 5 1>; - vdd3-supply = <&ldo12_reg>; - vci-supply = <&ldo11_reg>; - spi-max-frequency = <1200000>; - - port { - lcd_ep: endpoint { - remote-endpoint = <&fimd_ep>; - }; - }; - }; diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.yaml new file mode 100644 index 000000000000..204ed76da84d --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.yaml @@ -0,0 +1,58 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/samsung,s6e63m0.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung s6e63m0 AMOLED LCD panel + +maintainers: + - Jonathan Bakker <xc-racer2@live.ca> + +allOf: + - $ref: ../../spi/spi-slave.yaml# + - $ref: panel-common.yaml# + +properties: + compatible: + const: samsung,s6e63m0 + + reg: true + reset-gpios: true + port: true + + vdd3-supply: + description: VDD regulator + + vci-supply: + description: VCI regulator + +required: + - compatible + - reset-gpios + - vdd3-supply + - vci-supply + +examples: + - | + spi { + reg = <0xf00 0x20>; + #address-cells = <1>; + #size-cells = <0>; + display@0 { + compatible = "samsung,s6e63m0"; + reg = <0>; + reset-gpios = <&mp05 5 1>; + vdd3-supply = <&ldo12_reg>; + vci-supply = <&ldo11_reg>; + spi-max-frequency = <1200000>; + + port { + lcd_ep: endpoint { + remote-endpoint = <&fimd_ep>; + }; + }; + }; + }; + +...
The binding for this panel is a SPI slave. Reference spi-slave.yaml to avoid duplicating all properties. Signed-off-by: Sam Ravnborg <sam@ravnborg.org> Cc: Jonathan Bakker <xc-racer2@live.ca> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: Sam Ravnborg <sam@ravnborg.org> --- .../display/panel/samsung,s6e63m0.txt | 33 ----------- .../display/panel/samsung,s6e63m0.yaml | 58 +++++++++++++++++++ 2 files changed, 58 insertions(+), 33 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.txt create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.yaml