| Message ID | 20201106015035.139574-1-zhangqilong3@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e4062765bc2a41e025e29dd56bad798505036427 |
| Headers | show |
| Series | spi: sprd: fix reference leak in sprd_spi_remove | expand |
On Fri, 6 Nov 2020 at 09:39, Zhang Qilong <zhangqilong3@huawei.com> wrote: > > pm_runtime_get_sync will increment pm usage counter even it > failed. Forgetting to pm_runtime_put_noidle will result in > reference leak in sprd_spi_remove, so we should fix it. > > Fixes: e7d973a31c24b ("spi: sprd: Add SPI driver for Spreadtrum SC9860") > Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com> Acked-by: Chunyan Zhang <zhang.lyra@gmail.com> Thanks, Chunyan > --- > drivers/spi/spi-sprd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/spi/spi-sprd.c b/drivers/spi/spi-sprd.c > index 635738f54c73..b41a75749b49 100644 > --- a/drivers/spi/spi-sprd.c > +++ b/drivers/spi/spi-sprd.c > @@ -1010,6 +1010,7 @@ static int sprd_spi_remove(struct platform_device *pdev) > > ret = pm_runtime_get_sync(ss->dev); > if (ret < 0) { > + pm_runtime_put_noidle(ss->dev); > dev_err(ss->dev, "failed to resume SPI controller\n"); > return ret; > } > -- > 2.17.1 >
On Fri, 6 Nov 2020 09:50:35 +0800, Zhang Qilong wrote: > pm_runtime_get_sync will increment pm usage counter even it > failed. Forgetting to pm_runtime_put_noidle will result in > reference leak in sprd_spi_remove, so we should fix it. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: sprd: fix reference leak in sprd_spi_remove commit: e4062765bc2a41e025e29dd56bad798505036427 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi-sprd.c b/drivers/spi/spi-sprd.c index 635738f54c73..b41a75749b49 100644 --- a/drivers/spi/spi-sprd.c +++ b/drivers/spi/spi-sprd.c @@ -1010,6 +1010,7 @@ static int sprd_spi_remove(struct platform_device *pdev) ret = pm_runtime_get_sync(ss->dev); if (ret < 0) { + pm_runtime_put_noidle(ss->dev); dev_err(ss->dev, "failed to resume SPI controller\n"); return ret; }
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to pm_runtime_put_noidle will result in reference leak in sprd_spi_remove, so we should fix it. Fixes: e7d973a31c24b ("spi: sprd: Add SPI driver for Spreadtrum SC9860") Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com> --- drivers/spi/spi-sprd.c | 1 + 1 file changed, 1 insertion(+)