From patchwork Sun Dec 13 05:29:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 11970477 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A466C433FE for ; Sun, 13 Dec 2020 05:30:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D00EF22D71 for ; Sun, 13 Dec 2020 05:30:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727980AbgLMFab (ORCPT ); Sun, 13 Dec 2020 00:30:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725287AbgLMFab (ORCPT ); Sun, 13 Dec 2020 00:30:31 -0500 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 433BBC0613CF for ; Sat, 12 Dec 2020 21:29:51 -0800 (PST) Received: by mail-pg1-x543.google.com with SMTP id w4so10173607pgg.13 for ; Sat, 12 Dec 2020 21:29:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=RIRFinfbgbZO50AJSCxLN6fLNwVVOhGqRKpbkplO8ug=; b=GdgXpGFH+jNsbOUFmm8A+ht+nCz00rdXqYsd+AUSbdipXdCw26nOkJKHb11QeQKAWs DjO9KXWtR8dCEofzaRIg9CsTIZnm6HMUs/IR471Sm1tyBNm0/NGtEMARWk7HTxYsRlfB 8ewXopKQm4y7VM/axMqJDhV4ul5T/vhuwYas8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=RIRFinfbgbZO50AJSCxLN6fLNwVVOhGqRKpbkplO8ug=; b=oyyio5ZLOpolqkDBHTkUm5PkepRZoCwpX6HfN312J06P/dzAln+x9uWZkhJSKYQh+C hsoaHagL/yS9wXrMgVg22jJdTWQRciKlO7+Ii0DKIXb/GDmqEPBtD6Mu2t/zHEKyp4ar KshD2eUHa2Zw2H4z/KJ9UimNjrKEMox26MhhCi9Yc1pKOdhcC/cL+mA+jKMFVDol3XZE T+OyH+jZGiRDu5q//IoDroo4a+MXG4cVfNy8QjD12h1DCIeQsjxBLu5LpgpIUgLrgMx0 iv2E9jb/ZU5qWJk29SSfe3+nRkK8FfHda/Y3+7P/0P7JSfpUAYXBrMZ1Dla6TqTqvFtY dkRA== X-Gm-Message-State: AOAM5316RRYjE4v9PVEhvAZ8orVeHQ5ORxRdg/Emsuo0UZDIuwVQFzpZ YDPTZEFFdLSDqCt09f32xgiQNg== X-Google-Smtp-Source: ABdhPJzzjIM+frmXipKHf8je8MLsddRzOudjIcl+IK083vh1hHszJcGuzYLOdc+NV9K198oULyFJNA== X-Received: by 2002:a63:cc4c:: with SMTP id q12mr18838228pgi.361.1607837390716; Sat, 12 Dec 2020 21:29:50 -0800 (PST) Received: from smtp.gmail.com ([2620:15c:202:201:3e52:82ff:fe6c:83ab]) by smtp.gmail.com with ESMTPSA id w200sm15862917pfc.14.2020.12.12.21.29.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Dec 2020 21:29:50 -0800 (PST) From: Stephen Boyd To: Mark Brown Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-arm-msm@vger.kernel.org, Douglas Anderson , Rajendra Nayak , Mukesh Kumar Savaliya , Akash Asthana Subject: [PATCH] spi: spi-qcom-qspi: Use irq trigger flags from firmware Date: Sat, 12 Dec 2020 21:29:48 -0800 Message-Id: <20201213052948.308263-1-swboyd@chromium.org> X-Mailer: git-send-email 2.29.2.576.ga3fc446d84-goog MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org We don't need to force this to be trigger high here, as the firmware properly configures the irq flags already. Drop it to save a line. Cc: Douglas Anderson Cc: Rajendra Nayak Cc: Mukesh Kumar Savaliya Cc: Akash Asthana Signed-off-by: Stephen Boyd Reviewed-by: Douglas Anderson --- drivers/spi/spi-qcom-qspi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) base-commit: b65054597872ce3aefbc6a666385eabdf9e288da diff --git a/drivers/spi/spi-qcom-qspi.c b/drivers/spi/spi-qcom-qspi.c index 5eed88af6899..8e70f5e63e0b 100644 --- a/drivers/spi/spi-qcom-qspi.c +++ b/drivers/spi/spi-qcom-qspi.c @@ -516,8 +516,7 @@ static int qcom_qspi_probe(struct platform_device *pdev) ret = platform_get_irq(pdev, 0); if (ret < 0) goto exit_probe_master_put; - ret = devm_request_irq(dev, ret, qcom_qspi_irq, - IRQF_TRIGGER_HIGH, dev_name(dev), ctrl); + ret = devm_request_irq(dev, ret, qcom_qspi_irq, 0, dev_name(dev), ctrl); if (ret) { dev_err(dev, "Failed to request irq %d\n", ret); goto exit_probe_master_put;