| Message ID | 20201229231904.2558916-1-bert@biot.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RESEND,v2,1/2] dt-bindings: spi: Realtek RTL838x/RTL839x SPI controller | expand |
On Wed, Dec 30, 2020 at 12:19:03AM +0100, Bert Vermeulen wrote: > +properties: > + compatible: > + const: realtek,spi It is possibled Realtek might make other SPI controllers, there should be some more specific name such as a compatible for each SoC that the controller appears in or an IP name if one is known. Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
On 12/30/20 2:51 PM, Mark Brown wrote: > On Wed, Dec 30, 2020 at 12:19:03AM +0100, Bert Vermeulen wrote: > >> +properties: >> + compatible: >> + const: realtek,spi > > It is possibled Realtek might make other SPI controllers, there should > be some more specific name such as a compatible for each SoC that the > controller appears in or an IP name if one is known. Mark, Good call. We're changing all the Realtek RTL838x/RTL839x stuff to some variation of "realtek-rtl", in this case "realtek,rtl-spi". The "rtl" prefix to Realtek SoCs fits the bill. Will resubmit.
diff --git a/Documentation/devicetree/bindings/spi/realtek,spi.yaml b/Documentation/devicetree/bindings/spi/realtek,spi.yaml new file mode 100644 index 000000000000..9831df6dc40d --- /dev/null +++ b/Documentation/devicetree/bindings/spi/realtek,spi.yaml @@ -0,0 +1,36 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/spi/realtek,spi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Realtek RTL838x/RTL839x SPI controller + +maintainers: + - Bert Vermeulen <bert@biot.com> + - Birger Koblitz <mail@birger-koblitz.de> + +allOf: + - $ref: "spi-controller.yaml#" + +properties: + compatible: + const: realtek,spi + + reg: + maxItems: 1 + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + spi: spi@1200 { + compatible = "realtek,spi"; + reg = <0x1200 0x100>; + #address-cells = <1>; + #size-cells = <0>; + };
Signed-off-by: Bert Vermeulen <bert@biot.com> --- (resent due to mail trouble) .../devicetree/bindings/spi/realtek,spi.yaml | 36 +++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 Documentation/devicetree/bindings/spi/realtek,spi.yaml