| Message ID | 20210803102517.20944-1-Mason.Zhang@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | *** spi cs_timing restructure *** | expand |
On Tue, Aug 03, 2021 at 06:25:18PM +0800, Mason Zhang wrote: > This patch fixed set_cs_timing param, because cs timing delay has > been moved to spi_device. > > Signed-off-by: Mason Zhang <Mason.Zhang@mediatek.com> > --- > drivers/spi/spi-tegra114.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Each individual patch in the series needs to be buildable by itself, if an earlier commit in the series causes things to fail to build then that commit needs to be improved so that this doesn't happen. This supports things like bisection. Please also look into how you're sending serieses, these patches aren't threaded together as normal and there's a weird "***" in the subject of the first patch.
On Tue, 2021-08-03 at 15:10 +0100, Mark Brown wrote: > On Tue, Aug 03, 2021 at 06:25:18PM +0800, Mason Zhang wrote: > > This patch fixed set_cs_timing param, because cs timing delay has > > been moved to spi_device. > > > > Signed-off-by: Mason Zhang <Mason.Zhang@mediatek.com> > > --- > > drivers/spi/spi-tegra114.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > Each individual patch in the series needs to be buildable by itself, if > an earlier commit in the series causes things to fail to build then that > commit needs to be improved so that this doesn't happen. This supports > things like bisection. > > Please also look into how you're sending serieses, these patches aren't > threaded together as normal and there's a weird "***" in the subject of > the first patch. Dear Mark: Thanks for your suggestions, I have merged patch 2/3/4 in one patch to ensure it can be built by itself. And I have updated the patch v3, and removed the *** int the first patch. Thanks Mason
diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c index 5131141bbf0d..e9de1d958bbd 100644 --- a/drivers/spi/spi-tegra114.c +++ b/drivers/spi/spi-tegra114.c @@ -717,12 +717,12 @@ static void tegra_spi_deinit_dma_param(struct tegra_spi_data *tspi, dma_release_channel(dma_chan); } -static int tegra_spi_set_hw_cs_timing(struct spi_device *spi, - struct spi_delay *setup, - struct spi_delay *hold, - struct spi_delay *inactive) +static int tegra_spi_set_hw_cs_timing(struct spi_device *spi) { struct tegra_spi_data *tspi = spi_master_get_devdata(spi->master); + struct spi_delay *setup = &spi->cs_setup; + struct spi_delay *hold = &spi->cs_hold; + struct spi_delay *inactive = &spi->cs_inactive; u8 setup_dly, hold_dly, inactive_dly; u32 setup_hold; u32 spi_cs_timing;
This patch fixed set_cs_timing param, because cs timing delay has been moved to spi_device. Signed-off-by: Mason Zhang <Mason.Zhang@mediatek.com> --- drivers/spi/spi-tegra114.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)