diff mbox series

[v3,2/3] spi: Replace memset() with __GFP_ZERO

Message ID 20211123170034.41253-2-andriy.shevchenko@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series [v3,1/3] spi: Fix condition in the __spi_register_driver() | expand

Commit Message

Andy Shevchenko Nov. 23, 2021, 5 p.m. UTC 
krealloc() as any other kernel memory allocation calls accepts GFP flags,
one of which is __GFP_ZERO. Hence, no need to call memset() explicitly on
the reallocated buffer.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v3: no changes
 drivers/spi/spi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Andy Shevchenko Nov. 23, 2021, 5:02 p.m. UTC | #1 
On Tue, Nov 23, 2021 at 7:01 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> krealloc() as any other kernel memory allocation calls accepts GFP flags,
> one of which is __GFP_ZERO. Hence, no need to call memset() explicitly on
> the reallocated buffer.

This one is already applied, seconds before I have sent it.
diff mbox series

Patch

diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 15688acc952c..2e6e4b3ca96e 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -1222,11 +1222,10 @@  static int spi_map_msg(struct spi_controller *ctlr, struct spi_message *msg)
 
 		if (max_tx) {
 			tmp = krealloc(ctlr->dummy_tx, max_tx,
-				       GFP_KERNEL | GFP_DMA);
+				       GFP_KERNEL | GFP_DMA | __GFP_ZERO);
 			if (!tmp)
 				return -ENOMEM;
 			ctlr->dummy_tx = tmp;
-			memset(tmp, 0, max_tx);
 		}
 
 		if (max_rx) {