| Message ID | 20220307203745.65210-1-singh.kuldeep87k@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Mark Brown |
| Headers | show |
| Series | [1/2] dt-bindings: spi: Update clocks property for ARM pl022 | expand |
On 07/03/2022 21:37, Kuldeep Singh wrote: > Add missing minItems property to clocks in ARM pl022 bindings. > > This helps in resolving below warnings: > clocks: [[4]] is too short > clock-names: ['apb_pclk'] is too short > > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com> > --- > Documentation/devicetree/bindings/spi/spi-pl022.yaml | 1 + > 1 file changed, 1 insertion(+) > I saw these series in the past... please do not send the same version again. You need to version your series (git format-patch -v2 -2) and add changelog in cover letter (or for small patches after '---' in commits). How did you resolve the comments that the DTS might be wrong? It looks like you simply resent it... Best regards, Krzysztof
On Mon, Mar 07, 2022 at 10:55:52PM +0100, Krzysztof Kozlowski wrote: > On 07/03/2022 21:37, Kuldeep Singh wrote: > > Add missing minItems property to clocks in ARM pl022 bindings. > > > > This helps in resolving below warnings: > > clocks: [[4]] is too short > > clock-names: ['apb_pclk'] is too short > > > > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com> > > --- > > Documentation/devicetree/bindings/spi/spi-pl022.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > I saw these series in the past... please do not send the same version again. > > You need to version your series (git format-patch -v2 -2) and add > changelog in cover letter (or for small patches after '---' in commits). Ahh no. I completely missed out updating series number before sending. Actually I have been struggling to get mutt client setup with gmail account to send replies but it doesn't seem to work properly. Gmail labels has been hardest part. In between these hurdles, I rolled out patches and missed out this important thing. Kindly consider these 2 patches as deprecated. > > How did you resolve the comments that the DTS might be wrong? It looks > like you simply resent it... Few broadcom boards(stingray and ns2) require DT updation for which I sent patches and received Florain's blessings. Those patches are now available in github.com/Broadcom/stblinux, devicetree-arm64 There are several other updations(in realview, versatile etc.) required which I couldn't mention before as they are part of different tree.
diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml index 6d633728fc2b..7d36e15db5b3 100644 --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml @@ -34,6 +34,7 @@ properties: maxItems: 1 clocks: + minItems: 1 maxItems: 2 clock-names:
Add missing minItems property to clocks in ARM pl022 bindings. This helps in resolving below warnings: clocks: [[4]] is too short clock-names: ['apb_pclk'] is too short Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com> --- Documentation/devicetree/bindings/spi/spi-pl022.yaml | 1 + 1 file changed, 1 insertion(+)