| Message ID | 20221004055620.371732-1-usama.anjum@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | spi: Remove the dead code | expand |
Please disregard this patch. This is wrong and not needed. On 10/4/22 10:56 AM, Muhammad Usama Anjum wrote: > The vmallocated_buf is being checked if it is true inside the body of a > if condition which has already checked if it is true. Remove the > duplication and dead code as a result. > > Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> > --- > drivers/spi/spi.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c > index 44e4352d948b..4c51cd4e4ab0 100644 > --- a/drivers/spi/spi.c > +++ b/drivers/spi/spi.c > @@ -1057,10 +1057,7 @@ static int spi_map_buf_attrs(struct spi_controller *ctlr, struct device *dev, > min = min_t(size_t, desc_len, > min_t(size_t, len, > PAGE_SIZE - offset_in_page(buf))); > - if (vmalloced_buf) > - vm_page = vmalloc_to_page(buf); > - else > - vm_page = kmap_to_page(buf); > + vm_page = vmalloc_to_page(buf); > if (!vm_page) { > sg_free_table(sgt); > return -ENOMEM;
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 44e4352d948b..4c51cd4e4ab0 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -1057,10 +1057,7 @@ static int spi_map_buf_attrs(struct spi_controller *ctlr, struct device *dev, min = min_t(size_t, desc_len, min_t(size_t, len, PAGE_SIZE - offset_in_page(buf))); - if (vmalloced_buf) - vm_page = vmalloc_to_page(buf); - else - vm_page = kmap_to_page(buf); + vm_page = vmalloc_to_page(buf); if (!vm_page) { sg_free_table(sgt); return -ENOMEM;
The vmallocated_buf is being checked if it is true inside the body of a if condition which has already checked if it is true. Remove the duplication and dead code as a result. Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> --- drivers/spi/spi.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)