diff mbox series

spi: use devm_platform_get_and_ioremap_resource()

Message ID 202211220944121776425@zte.com.cn (mailing list archive)
State New, archived
Headers show
Series spi: use devm_platform_get_and_ioremap_resource() | expand

Commit Message

ye.xingchen@zte.com.cn Nov. 22, 2022, 1:44 a.m. UTC 
From: Minghao Chi <chi.minghao@zte.com.cn>

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
 drivers/spi/spi-qup.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Mark Brown Nov. 22, 2022, 12:24 p.m. UTC | #1 
On Tue, Nov 22, 2022 at 09:44:12AM +0800, ye.xingchen@zte.com.cn wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
> 
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.

This doesn't apply against current code, please check and resend:

Applying: spi: use devm_platform_get_and_ioremap_resource()
error: corrupt patch at line 19
error: could not build fake ancestor
Patch failed at 0001 spi: use devm_platform_get_and_ioremap_resource()
diff mbox series

Patch

diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c
index 678dc51ef017..71fc65e094e7 100644
--- a/drivers/spi/spi-qup.c
+++ b/drivers/spi/spi-qup.c
@@ -1003,8 +1003,7 @@  static int spi_qup_probe(struct platform_device *pdev)
 	int ret, irq, size;

 	dev = &pdev->dev;
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	base = devm_ioremap_resource(dev, res);
+	base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
 	if (IS_ERR(base))
 		return PTR_ERR(base);