| Message ID | 20230221-spi-arch-deps-v1-1-83d1566474cf@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | spi: Build coverage cleanups and improvements | expand |
On 23/02/2023 18:20, Mark Brown wrote: > The FIQ APIs aren't exported symbols so can't be used from modules, meaning > that the s3c24xx driver can only have FIQ support enabled when it's built > in. > > Signed-off-by: Mark Brown <broonie@kernel.org> > --- > drivers/spi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig > index 6fb17efb35f0..d1ee27d55a5f 100644 > --- a/drivers/spi/Kconfig > +++ b/drivers/spi/Kconfig > @@ -862,7 +862,7 @@ config SPI_S3C24XX > > config SPI_S3C24XX_FIQ > bool "S3C24XX driver with FIQ pseudo-DMA" > - depends on SPI_S3C24XX > + depends on SPI_S3C24XX=y The entire SPI_S3C24XX driver is now being dropped (through Arnd's tree) and should be gone by v6.3-rc1: c9dcd56feb82 ("spi: remove s3c24xx driver") The patch is not needed. Best regards, Krzysztof
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 6fb17efb35f0..d1ee27d55a5f 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -862,7 +862,7 @@ config SPI_S3C24XX config SPI_S3C24XX_FIQ bool "S3C24XX driver with FIQ pseudo-DMA" - depends on SPI_S3C24XX + depends on SPI_S3C24XX=y select FIQ help Enable FIQ support for the S3C24XX SPI driver to provide pseudo
The FIQ APIs aren't exported symbols so can't be used from modules, meaning that the s3c24xx driver can only have FIQ support enabled when it's built in. Signed-off-by: Mark Brown <broonie@kernel.org> --- drivers/spi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)