| Message ID | 20230303172041.2103336-75-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b7b949458ac391963e56ae354b73fee63016dcee |
| Headers | show |
| Series | spi: Convert to platform remove callback returning void | expand |
On Fri, 3 Mar 2023 18:20:28 +0100 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Andre Przywara <andre.przywara@arm.com> Cheers, Andre > --- > drivers/spi/spi-sun4i.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/spi/spi-sun4i.c b/drivers/spi/spi-sun4i.c > index 6000d0761206..994d0fb50e68 100644 > --- a/drivers/spi/spi-sun4i.c > +++ b/drivers/spi/spi-sun4i.c > @@ -516,11 +516,9 @@ static int sun4i_spi_probe(struct platform_device *pdev) > return ret; > } > > -static int sun4i_spi_remove(struct platform_device *pdev) > +static void sun4i_spi_remove(struct platform_device *pdev) > { > pm_runtime_force_suspend(&pdev->dev); > - > - return 0; > } > > static const struct of_device_id sun4i_spi_match[] = { > @@ -536,7 +534,7 @@ static const struct dev_pm_ops sun4i_spi_pm_ops = { > > static struct platform_driver sun4i_spi_driver = { > .probe = sun4i_spi_probe, > - .remove = sun4i_spi_remove, > + .remove_new = sun4i_spi_remove, > .driver = { > .name = "sun4i-spi", > .of_match_table = sun4i_spi_match,
Dne petek, 03. marec 2023 ob 18:20:28 CET je Uwe Kleine-König napisal(a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Best regards, Jernej > drivers/spi/spi-sun4i.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/spi/spi-sun4i.c b/drivers/spi/spi-sun4i.c > index 6000d0761206..994d0fb50e68 100644 > --- a/drivers/spi/spi-sun4i.c > +++ b/drivers/spi/spi-sun4i.c > @@ -516,11 +516,9 @@ static int sun4i_spi_probe(struct platform_device > *pdev) return ret; > } > > -static int sun4i_spi_remove(struct platform_device *pdev) > +static void sun4i_spi_remove(struct platform_device *pdev) > { > pm_runtime_force_suspend(&pdev->dev); > - > - return 0; > } > > static const struct of_device_id sun4i_spi_match[] = { > @@ -536,7 +534,7 @@ static const struct dev_pm_ops sun4i_spi_pm_ops = { > > static struct platform_driver sun4i_spi_driver = { > .probe = sun4i_spi_probe, > - .remove = sun4i_spi_remove, > + .remove_new = sun4i_spi_remove, > .driver = { > .name = "sun4i-spi", > .of_match_table = sun4i_spi_match,
diff --git a/drivers/spi/spi-sun4i.c b/drivers/spi/spi-sun4i.c index 6000d0761206..994d0fb50e68 100644 --- a/drivers/spi/spi-sun4i.c +++ b/drivers/spi/spi-sun4i.c @@ -516,11 +516,9 @@ static int sun4i_spi_probe(struct platform_device *pdev) return ret; } -static int sun4i_spi_remove(struct platform_device *pdev) +static void sun4i_spi_remove(struct platform_device *pdev) { pm_runtime_force_suspend(&pdev->dev); - - return 0; } static const struct of_device_id sun4i_spi_match[] = { @@ -536,7 +534,7 @@ static const struct dev_pm_ops sun4i_spi_pm_ops = { static struct platform_driver sun4i_spi_driver = { .probe = sun4i_spi_probe, - .remove = sun4i_spi_remove, + .remove_new = sun4i_spi_remove, .driver = { .name = "sun4i-spi", .of_match_table = sun4i_spi_match,
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/spi/spi-sun4i.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)