| Message ID | 20230510113942.89994-1-jaewon02.kim@samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 26cd10a0b9761bffd4669a429f8a33cbccef5bbd |
| Headers | show |
| Series | spi: s3c64xx: Disable IRQ mode when using DMA | expand |
On 10/05/2023 13:39, Jaewon Kim wrote: > Fixing the problem of enabling DMA mode and IRQ mode at the same time. > In this case, a value of more than 6bits is written to RDY_LVL, it can > cause an invasion of other registers, potentially leading to SPI > transfer failure. > > Fixes: 1ee806718d5e ("spi: s3c64xx: support interrupt based pio mode") > Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com> > Reported-by: Marek Szyprowski <m.szyprowski@samsung.com> > Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Wed, 10 May 2023 20:39:42 +0900, Jaewon Kim wrote: > Fixing the problem of enabling DMA mode and IRQ mode at the same time. > In this case, a value of more than 6bits is written to RDY_LVL, it can > cause an invasion of other registers, potentially leading to SPI > transfer failure. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: s3c64xx: Disable IRQ mode when using DMA commit: 26cd10a0b9761bffd4669a429f8a33cbccef5bbd All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 238db29fc93b..c6a8a6434140 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -782,7 +782,7 @@ static int s3c64xx_spi_transfer_one(struct spi_master *master, do { /* transfer size is greater than 32, change to IRQ mode */ - if (xfer->len > S3C64XX_SPI_POLLING_SIZE) + if (!use_dma && xfer->len > S3C64XX_SPI_POLLING_SIZE) use_irq = true; if (use_irq) {
Fixing the problem of enabling DMA mode and IRQ mode at the same time. In this case, a value of more than 6bits is written to RDY_LVL, it can cause an invasion of other registers, potentially leading to SPI transfer failure. Fixes: 1ee806718d5e ("spi: s3c64xx: support interrupt based pio mode") Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> --- drivers/spi/spi-s3c64xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)