From patchwork Fri May 12 10:47:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joy Chakraborty X-Patchwork-Id: 13239120 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80276C77B75 for ; Fri, 12 May 2023 10:48:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240905AbjELKsv (ORCPT ); Fri, 12 May 2023 06:48:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240911AbjELKso (ORCPT ); Fri, 12 May 2023 06:48:44 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7A2A13293 for ; Fri, 12 May 2023 03:48:06 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-ba6388faf79so4196122276.0 for ; Fri, 12 May 2023 03:48:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1683888486; x=1686480486; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=y049PmC5C0PnSAgiyWvWPHzKRIJST3guVG5ES+MeGns=; b=vzvkdCR8kM136SsZBU8U6eQlSFq1oB+ZzglgeMJUx1D0MI+o/WQSVOCyw//1P3LZVw npUlZM10hPgXVQ2Cbmr3lZeebUN8Dq/7w4re/xNNrVEEkLgVTQanyAPt3J/qxl47Phag wuurc+OhIsCI3v0IoO8V0okHUzfS0FGRIzDdTTWooGPJwGl8oIsmiPAtSaFkLnDb42V9 b8DR3HLqasuktNv8yBUjuMR4SLdhfbr+/9pa2ApIj/0mcwTdK1LP7S1arT74S1rq/Nxs IQFoe2LN/ptkKD5ZFlVg1wDRkKW4VPHyVVaVC05WFrmDOaBiRbdwfPUroOXRCZ4Wl2Jy J3+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683888486; x=1686480486; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=y049PmC5C0PnSAgiyWvWPHzKRIJST3guVG5ES+MeGns=; b=QQylRwa58YeDoHgWWvWBvezYL3dsXV4CdZivufnsHuq+pFHOUwf7a9Yj7O7oLByXpB fxoGj/2rJ/4H4fE1LFBeol86oO+hG54OW3C+4DMJnQH+UM/jRUTeCFDl4NDKvgXQRL/N nUmzxphDZxjagmU5zE0a+tsLazr9Vd3GUZJ8zczPawjf6FMP0+TXJqVyOMS2+B95fWFd AiPHEkL6oGOWaghRQhMvh8FcREeHM4zghRkz8CTeGqcbOP6nwjH1kuvHuV/0iAS8tVU1 60Mic957Ne4Daf8h4OQI2YZOb035xxudL/+vj0a68XQlYjAmsFljD+ikf3rRbOMfbqjF V6vw== X-Gm-Message-State: AC+VfDygufMnDuHsd3g0ZgcXCE/XZndEztUtt1FndKwl8Z5Nki7gh+ef fF2Bvon+21AfwTgKyLdVxL+sLbJxlHlgCQ== X-Google-Smtp-Source: ACHHUZ79BFgMVJJIcvfFqvQAo8l+zEZEgcjfLxAouTj2iS04W2IVqnCTc6w1YLTXDa6JDILsajqrPA3xjrT+Jw== X-Received: from joychakr.c.googlers.com ([fda3:e722:ac3:cc00:4f:4b78:c0a8:6ea]) (user=joychakr job=sendgmr) by 2002:a05:6902:1890:b0:b96:7676:db4a with SMTP id cj16-20020a056902189000b00b967676db4amr15756188ybb.0.1683888485998; Fri, 12 May 2023 03:48:05 -0700 (PDT) Date: Fri, 12 May 2023 10:47:45 +0000 In-Reply-To: <20230512104746.1797865-1-joychakr@google.com> Mime-Version: 1.0 References: <20230512104746.1797865-1-joychakr@google.com> X-Mailer: git-send-email 2.40.1.606.ga4b1b128d6-goog Message-ID: <20230512104746.1797865-4-joychakr@google.com> Subject: [PATCH v11 3/3] spi: dw: Round of n_bytes to power of 2 From: Joy Chakraborty To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, manugautam@google.com, Joy Chakraborty , Andy Shevchenko , Serge Semin Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org n_bytes variable in the driver represents the number of bytes per word that needs to be sent/copied to fifo. Bits/word can be between 8 and 32 bits from the client but in memory they are a power of 2, same is mentioned in spi.h header: " * @bits_per_word: Data transfers involve one or more words; word sizes * like eight or 12 bits are common. In-memory wordsizes are * powers of two bytes (e.g. 20 bit samples use 32 bits). * This may be changed by the device's driver, or left at the * default (0) indicating protocol words are eight bit bytes. * The spi_transfer.bits_per_word can override this for each transfer. " Hence, round of n_bytes to a power of 2 to avoid values like 3 which would generate unalligned/odd accesses to memory/fifo. Fixes: a51acc2400d4 ("spi: dw: Add support for 32-bits max xfer size") Suggested-by: Andy Shevchenko Signed-off-by: Joy Chakraborty Reviewed-by: Serge Semin Tested-by: Serge Semin * tested on Baikal-T1 based system with DW SPI-looped back interface transferring a chunk of data with DFS:8,12,16. --- drivers/spi/spi-dw-core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-dw-core.c b/drivers/spi/spi-dw-core.c index ae3108c70f50..7778b19bcb6c 100644 --- a/drivers/spi/spi-dw-core.c +++ b/drivers/spi/spi-dw-core.c @@ -426,7 +426,10 @@ static int dw_spi_transfer_one(struct spi_controller *master, int ret; dws->dma_mapped = 0; - dws->n_bytes = DIV_ROUND_UP(transfer->bits_per_word, BITS_PER_BYTE); + dws->n_bytes = + roundup_pow_of_two(DIV_ROUND_UP(transfer->bits_per_word, + BITS_PER_BYTE)); + dws->tx = (void *)transfer->tx_buf; dws->tx_len = transfer->len / dws->n_bytes; dws->rx = transfer->rx_buf;