| Message ID | 20230518052515.368978-1-asuk4.q@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 120e1aa2f2e60b55f9d20c2fe1c6144739e00dc4 |
| Headers | show |
| Series | spi: hisi-kunpeng: Fix error checking | expand |
On Thu, 18 May 2023 13:25:15 +0800, Yeqi Fu wrote: > The function debugfs_create_dir returns ERR_PTR if an error occurs, > and the appropriate way to verify for errors is to use the inline > function IS_ERR. The patch will substitute the null-comparison with > IS_ERR. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: hisi-kunpeng: Fix error checking commit: 120e1aa2f2e60b55f9d20c2fe1c6144739e00dc4 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi-hisi-kunpeng.c b/drivers/spi/spi-hisi-kunpeng.c index 524eadbef87b..2b4b3d2a22b8 100644 --- a/drivers/spi/spi-hisi-kunpeng.c +++ b/drivers/spi/spi-hisi-kunpeng.c @@ -169,7 +169,7 @@ static int hisi_spi_debugfs_init(struct hisi_spi *hs) master = container_of(hs->dev, struct spi_controller, dev); snprintf(name, 32, "hisi_spi%d", master->bus_num); hs->debugfs = debugfs_create_dir(name, NULL); - if (!hs->debugfs) + if (IS_ERR(hs->debugfs)) return -ENOMEM; hs->regset.regs = hisi_spi_regs;
The function debugfs_create_dir returns ERR_PTR if an error occurs, and the appropriate way to verify for errors is to use the inline function IS_ERR. The patch will substitute the null-comparison with IS_ERR. Suggested-by: Ivan Orlov <ivan.orlov0322@gmail.com> Signed-off-by: Yeqi Fu <asuk4.q@gmail.com> --- drivers/spi/spi-hisi-kunpeng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)