From patchwork Wed Nov 29 06:43:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Chia-Lin Kao (AceLan)" X-Patchwork-Id: 13472263 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kZqsuYJh" Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54671170B; Tue, 28 Nov 2023 22:43:17 -0800 (PST) Received: by mail-oi1-x230.google.com with SMTP id 5614622812f47-3b2e330033fso3894750b6e.3; Tue, 28 Nov 2023 22:43:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701240196; x=1701844996; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=i6qfrVn0277bDMh3KhTRXLaLEzam5I22VMt+zO4G1cM=; b=kZqsuYJhpnRSk4CaACBSG0acrUy/5+TsxuD2SDSCkjWnrUUabRJ4FzepB4aKzNsNRZ zIPMHRtbVNjr0sfzdhGYanpUgb5XD0DejB2Zn/gsESJUk9TU9tQzV7m6FVziQPpVgzNW USSzCTmbWjG83bt16S+yJ0o2/WlQf3/3bdFF/0CRgrTavUtMY8Z+bSECA2t70emTlUle f7VOSGv1LyI9/cdXOrccNYWfToIs9we/NEk6rRwZ2WJZ3popU7ziWrW3cQhbCT9TxfMd DkJG+/pFAl7TFC9UOFhJhA27tfbDY0m5voLPPQpQbinQ7miji54cciIFRCL2vGzr5Y0n jS3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701240196; x=1701844996; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=i6qfrVn0277bDMh3KhTRXLaLEzam5I22VMt+zO4G1cM=; b=tmKQfyfnnsEAOLnyDjRUQmDL5r7ZzsjTkVUzEGAyQsmUhQm9uaIoGpFft+wJhpFc2e MlY+zVtT8/z8OF4hur3pWWLhIrzeUJZgx4RS/8y/tOkPKaf7qAFoNptAJ9RD9p4uILp8 f7DHv6MD0wGEsoawYG8rks6Y/6s7txbyoY7SGxWIMTr3SV/lus5kfn/oYAjD4LAdPmUL VFBV3FtxYQC1xIqhDZE6VF6aJq3yL+hvfozn1VnzivPt8t2qS0WmT3UN8dSGpHl28c6t 3ZJ950LRGuSG98mPD0Hwt2mb7X3uOCr11m+VxQ/eobd2Qr4KU7550CFvd6KvbKLxilSy JxcA== X-Gm-Message-State: AOJu0Yzy/eqedp0ZmlaMnaJDCwPGLmFS4Mp2wVJl5EmDuMKgWTRaNMoN bFe1G75Crt0zhz8hzjbgy84= X-Google-Smtp-Source: AGHT+IEaYdguNW0MvrtGlevAV1RSYiqQFJXUoenv/xvsoqABBLuNLSdryk2roXcEnPubcmjtlLFCzg== X-Received: by 2002:a05:6808:23c9:b0:3b5:ae0d:b208 with SMTP id bq9-20020a05680823c900b003b5ae0db208mr25801175oib.6.1701240196530; Tue, 28 Nov 2023 22:43:16 -0800 (PST) Received: from localhost (220-135-95-34.hinet-ip.hinet.net. [220.135.95.34]) by smtp.gmail.com with ESMTPSA id x23-20020aa793b7000000b006cb638ba1aasm9877362pff.49.2023.11.28.22.43.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 22:43:16 -0800 (PST) Sender: AceLan Kao From: AceLan Kao To: Tudor Ambarus , Pratyush Yadav , Michael Walle , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Mika Westerberg , Dhruva Gole , linux-mtd@lists.infradead.org, Mark Brown , Kamal Dasu , =?utf-8?q?Jonathan_Neusch=C3=A4fer?= , Mario Kicherer , Chuanhong Guo , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 2/2] mtd: spi-nor: Stop reporting warning message when soft reset is not suported Date: Wed, 29 Nov 2023 14:43:11 +0800 Message-Id: <20231129064311.272422-2-acelan.kao@canonical.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231129064311.272422-1-acelan.kao@canonical.com> References: <20231129064311.272422-1-acelan.kao@canonical.com> Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: "Chia-Lin Kao (AceLan)" When the software reset command isn't supported, we now stop reporting the warning message to avoid unnecessary warnings and potential confusion. Reviewed-by: Dhruva Gole Reviewed-by: Michael Walle Reviewed-by: Mika Westerberg Acked-by: Pratyush Yadav Signed-off-by: Chia-Lin Kao (AceLan) Acked-by: Tudor Ambarus Reviewed-by: Miquel Raynal --- v2. only lower the priority for the not supported failure v3. replace ENOTSUPP with EOPNOTSUPP and check the first command only v4. move the version information below the '---' line v5. remove dev_warn if soft reset operation is not supported --- drivers/mtd/spi-nor/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c index 87cb2047df80..96a207751cf2 100644 --- a/drivers/mtd/spi-nor/core.c +++ b/drivers/mtd/spi-nor/core.c @@ -3237,7 +3237,8 @@ static void spi_nor_soft_reset(struct spi_nor *nor) ret = spi_mem_exec_op(nor->spimem, &op); if (ret) { - dev_warn(nor->dev, "Software reset failed: %d\n", ret); + if (ret != -EOPNOTSUPP) + dev_warn(nor->dev, "Software reset failed: %d\n", ret); return; }