| Message ID | 20231206145233.74982-1-namcao@linutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7a733e060bd20edb63b1f27f0b29cf9b184e0e8b |
| Headers | show |
| Series | [v3] spi: cadence: revert "Add SPI transfer delays" | expand |
On Wed, 06 Dec 2023 15:52:33 +0100, Nam Cao wrote: > The commit 855a40cd8ccc ("spi: cadence: Add SPI transfer delays") adds a > delay after each transfer into the driver's transfer_one(). However, > the delay is already done in SPI core. So this commit unnecessarily > doubles the delay amount. Revert this commit. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: cadence: revert "Add SPI transfer delays" commit: 7a733e060bd20edb63b1f27f0b29cf9b184e0e8b All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi-cadence.c b/drivers/spi/spi-cadence.c index 12c940ba074a..bd96d8b546cd 100644 --- a/drivers/spi/spi-cadence.c +++ b/drivers/spi/spi-cadence.c @@ -451,7 +451,6 @@ static int cdns_transfer_one(struct spi_controller *ctlr, udelay(10); cdns_spi_process_fifo(xspi, xspi->tx_fifo_depth, 0); - spi_transfer_delay_exec(transfer); cdns_spi_write(xspi, CDNS_SPI_IER, CDNS_SPI_IXR_DEFAULT); return transfer->len;
The commit 855a40cd8ccc ("spi: cadence: Add SPI transfer delays") adds a delay after each transfer into the driver's transfer_one(). However, the delay is already done in SPI core. So this commit unnecessarily doubles the delay amount. Revert this commit. Signed-off-by: Nam Cao <namcao@linutronix.de> --- v3: add missing change log v2: - update subject format - rewrite commit message to be more descriptive drivers/spi/spi-cadence.c | 1 - 1 file changed, 1 deletion(-)