| Message ID | 20240304-mainline-axi-spi-engine-small-cleanups-v2-1-5b14ed729a31@baylibre.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 69d54ee2e5b0dab9350be2a7019c472b9b8d4c14 |
| Headers | show |
| Series | spi: axi-spi-engine: small cleanups | expand |
On 04/03/24 10:04, David Lechner wrote: > The program pointer p in struct spi_engine_message_state in the AXI SPI > Engine controller driver was assigned but never read so it can be > removed. > > Reviewed-by: Kees Cook <keescook@chromium.org> > Signed-off-by: David Lechner <dlechner@baylibre.com> Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org> Thanks -- Gustavo > --- > drivers/spi/spi-axi-spi-engine.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/spi/spi-axi-spi-engine.c b/drivers/spi/spi-axi-spi-engine.c > index 6177c1a8d56e..d89f75170c9e 100644 > --- a/drivers/spi/spi-axi-spi-engine.c > +++ b/drivers/spi/spi-axi-spi-engine.c > @@ -82,8 +82,6 @@ struct spi_engine_program { > * struct spi_engine_message_state - SPI engine per-message state > */ > struct spi_engine_message_state { > - /** @p: Instructions for executing this message. */ > - struct spi_engine_program *p; > /** @cmd_length: Number of elements in cmd_buf array. */ > unsigned cmd_length; > /** @cmd_buf: Array of commands not yet written to CMD FIFO. */ > @@ -543,7 +541,6 @@ static int spi_engine_transfer_one_message(struct spi_controller *host, > > /* reinitialize message state for this transfer */ > memset(st, 0, sizeof(*st)); > - st->p = p; > st->cmd_buf = p->instructions; > st->cmd_length = p->length; > msg->state = st; >
diff --git a/drivers/spi/spi-axi-spi-engine.c b/drivers/spi/spi-axi-spi-engine.c index 6177c1a8d56e..d89f75170c9e 100644 --- a/drivers/spi/spi-axi-spi-engine.c +++ b/drivers/spi/spi-axi-spi-engine.c @@ -82,8 +82,6 @@ struct spi_engine_program { * struct spi_engine_message_state - SPI engine per-message state */ struct spi_engine_message_state { - /** @p: Instructions for executing this message. */ - struct spi_engine_program *p; /** @cmd_length: Number of elements in cmd_buf array. */ unsigned cmd_length; /** @cmd_buf: Array of commands not yet written to CMD FIFO. */ @@ -543,7 +541,6 @@ static int spi_engine_transfer_one_message(struct spi_controller *host, /* reinitialize message state for this transfer */ memset(st, 0, sizeof(*st)); - st->p = p; st->cmd_buf = p->instructions; st->cmd_length = p->length; msg->state = st;