diff mbox series

[1/3] spi: don't unoptimize message in spi_async()

Message ID 20240708-spi-mux-fix-v1-1-6c8845193128@baylibre.com (mailing list archive)
State Accepted
Commit c86a918b1bdba78fb155184f8d88dfba1e63335d
Headers show
Series spi: fix spi-mux/spi_optimize_message() compatibility | expand

Commit Message

David Lechner July 9, 2024, 1:05 a.m. UTC 
Calling spi_maybe_unoptimize_message() in spi_async() is wrong because
the message is likely to be in the queue and not transferred yet. This
can corrupt the message while it is being used by the controller driver.

spi_maybe_unoptimize_message() is already called in the correct place
in spi_finalize_current_message() to balance the call to
spi_maybe_optimize_message() in spi_async().

Fixes: 7b1d87af14d9 ("spi: add spi_optimize_message() APIs")
Signed-off-by: David Lechner <dlechner@baylibre.com>
---
 drivers/spi/spi.c | 2 --
 1 file changed, 2 deletions(-)
diff mbox series

Patch

diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 5e715a640237..e48c2fdd7204 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -4436,8 +4436,6 @@  int spi_async(struct spi_device *spi, struct spi_message *message)
 
 	spin_unlock_irqrestore(&ctlr->bus_lock_spinlock, flags);
 
-	spi_maybe_unoptimize_message(message);
-
 	return ret;
 }
 EXPORT_SYMBOL_GPL(spi_async);