diff mbox series

[1/3] dt-bindings: trivial-devices: Document elgin,spi-lcd

Message ID 20240718200540.955370-1-festevam@gmail.com (mailing list archive)
State New, archived
Headers show
Series [1/3] dt-bindings: trivial-devices: Document elgin,spi-lcd | expand

Commit Message

Fabio Estevam July 18, 2024, 8:05 p.m. UTC 
The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace.

Add an entry for the "elgin,spi-lcd" compatible string.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Conor Dooley July 19, 2024, 8:42 a.m. UTC | #1 
On Thu, Jul 18, 2024 at 05:05:38PM -0300, Fabio Estevam wrote:
> The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace.
> 
> Add an entry for the "elgin,spi-lcd" compatible string.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 7913ca9b6b54..49dee2a1f6b4 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -110,6 +110,8 @@ properties:
>            - domintech,dmard09
>              # DMARD10: 3-axis Accelerometer
>            - domintech,dmard10
> +            # Elgin SPI-controlled LCD
> +          - elgin,spi-lcd

As mentioned on the dts patch, this needs to be far more specific. Are
there no markings etc on the panel?
I still can't find any information online about this board, other than
linux/u-boot lists or related repos.

>              # MMA7660FC: 3-Axis Orientation/Motion Detection Sensor
>            - fsl,mma7660
>              # MMA8450Q: Xtrinsic Low-power, 3-axis Xtrinsic Accelerometer
> -- 
> 2.34.1
>
Fabio Estevam July 19, 2024, 2:38 p.m. UTC | #2 
Hi Conor,

On Fri, Jul 19, 2024 at 5:42 AM Conor Dooley <conor@kernel.org> wrote:

> As mentioned on the dts patch, this needs to be far more specific. Are
> there no markings etc on the panel?

I submitted v2 with a more specific compatible string containing the
markings on the panel.

Thanks
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 7913ca9b6b54..49dee2a1f6b4 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -110,6 +110,8 @@  properties:
           - domintech,dmard09
             # DMARD10: 3-axis Accelerometer
           - domintech,dmard10
+            # Elgin SPI-controlled LCD
+          - elgin,spi-lcd
             # MMA7660FC: 3-Axis Orientation/Motion Detection Sensor
           - fsl,mma7660
             # MMA8450Q: Xtrinsic Low-power, 3-axis Xtrinsic Accelerometer