From patchwork Thu Dec 4 18:17:17 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 5439661 Return-Path: X-Original-To: patchwork-linux-spi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 24388BEEA8 for ; Thu, 4 Dec 2014 18:19:05 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 451BB20125 for ; Thu, 4 Dec 2014 18:19:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6448C2011B for ; Thu, 4 Dec 2014 18:19:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932868AbaLDSTC (ORCPT ); Thu, 4 Dec 2014 13:19:02 -0500 Received: from mail-wi0-f179.google.com ([209.85.212.179]:34744 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932382AbaLDSTB (ORCPT ); Thu, 4 Dec 2014 13:19:01 -0500 Received: by mail-wi0-f179.google.com with SMTP id ex7so28886338wid.12 for ; Thu, 04 Dec 2014 10:19:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :content-type:content-transfer-encoding; bh=U+Mdpfz5qhfehggZT9gOBcgHnmwa5BCMOM+MdMfvtiU=; b=vlrljy5xll2CCQaGfWChWe/6mIJ4cwzxeOiqUhLCS1tAEqtY+X2LJC+SMSZIHBirY3 5Lixev/H9NajfER8HAJVjZy35ygnDgIdAGMf02ZT7p0tmiWEjIqXAGQZeYAq5RosAJzW DqoFv1aj4MAOml8Y/8Xn27SDsb1f7lCC7mj1cwyXofSZmTYZZqF1zDfnhSwaAQrxeL9h 9Yh/FGJ9QP9O/p3d8bg7qqiYLm0am0gm2T49A+yqyYD1fCjdiS3VaoXcihvliBo9Fy50 8Sw3SwZdTyL0Vh6gOHTkOWdZaf+421tLcvDM2VG2ViWSHMkM1obmCUSwNGrsz0oVz1Re 6HRg== X-Received: by 10.180.228.101 with SMTP id sh5mr23027530wic.62.1417717139991; Thu, 04 Dec 2014 10:18:59 -0800 (PST) Received: from ?IPv6:2003:63:2343:500:2db1:a14e:ff2d:e9ed? (p20030063234305002DB1A14EFF2DE9ED.dip0.t-ipconnect.de. [2003:63:2343:500:2db1:a14e:ff2d:e9ed]) by mx.google.com with ESMTPSA id r10sm55969704wiy.13.2014.12.04.10.18.59 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Dec 2014 10:18:59 -0800 (PST) Message-ID: <5480A52D.8010204@gmail.com> Date: Thu, 04 Dec 2014 19:17:17 +0100 From: Heiner Kallweit User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: broonie@kernel.org CC: linux-spi@vger.kernel.org, fabio.estevam@freescale.com Subject: [PATCH] spi: fsl-spi: fix incomplete return statement Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fixes an incomplete return statement after fsl_spi_do_one_msg was changed to return an int and removes an unused variable assignment. Signed-off-by: Heiner Kallweit --- drivers/spi/spi-fsl-spi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/spi/spi-fsl-spi.c b/drivers/spi/spi-fsl-spi.c index e24a9bf..60c5907 100644 --- a/drivers/spi/spi-fsl-spi.c +++ b/drivers/spi/spi-fsl-spi.c @@ -368,10 +368,9 @@ static int fsl_spi_do_one_msg(struct spi_master *master, list_for_each_entry(t, &m->transfers, transfer_list) { if ((first->bits_per_word != t->bits_per_word) || (first->speed_hz != t->speed_hz)) { - status = -EINVAL; dev_err(&spi->dev, "bits_per_word/speed_hz should be same for the same SPI transfer\n"); - return; + return -EINVAL; } }