From patchwork Sun Sep 4 08:01:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 9312421 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 979F5600CA for ; Sun, 4 Sep 2016 08:07:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 891E4287DA for ; Sun, 4 Sep 2016 08:07:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7DF6728925; Sun, 4 Sep 2016 08:07:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 26104287DA for ; Sun, 4 Sep 2016 08:07:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752523AbcIDIHo (ORCPT ); Sun, 4 Sep 2016 04:07:44 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33911 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752106AbcIDIHi (ORCPT ); Sun, 4 Sep 2016 04:07:38 -0400 Received: by mail-wm0-f67.google.com with SMTP id v143so8664514wmv.1 for ; Sun, 04 Sep 2016 01:07:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:subject:to:references:cc:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=KEPq45dgJ7a12SE8z2tVLYOqgmRLkUDD93aexg3LPzc=; b=nmhIAoFdl/RAxdrkLlcZuRIxAUPy7DQ5R+Xykck2BxGNWgnmCTGGD0dcuvtldmZswr DY+1sxm6WwbGHAW1utsVR7Wy8zJbSgZbmg8pEHshktGNoTAHmMyOEXXi6Nllu5t5/qAH XkS8ymLZLHi296WJImfiXrT3cTTCQgYhnLk8tLNb76/IDMDwQwlKqEfS9pC7CpQ1eiMq 2ELfele1c1YSS0zyOqBhIsdG8fGIOuSmK1FCk2g9QnRIeGC0vynzIpZrfvQbLOmaP0+x YALZhdcbeGXewLkO66veWxCGD/we/fhE6bEeTxMDgk1bgoGDjykXqFZkCg9Vl1W44+n/ WXig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:subject:to:references:cc:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=KEPq45dgJ7a12SE8z2tVLYOqgmRLkUDD93aexg3LPzc=; b=ZTl8nr4B8QzxTWSwTBBPVbHmbIi8TUYt66Qkt7qACv5lqXrxixL9mblyBe5mNr9vaM PqA3GSg3aIyRO4KyEXeujEs2SywRWzA2GGG7GB1uqkxYWgAwl6ZWe8H1+tJahNdkvJJB nuPMs00t37KYhONXueRQZ7ep4x6/vMOCeKV6kGyI4AudsFmOW54W7abgLJ0TrH7Bch9K MbtncOhqHU3ptpBJ5sF9NeMlGUc2LsO2mK5GKt3mwsk7lhXUy9uQ1W12iWdHvIvJboms H8G1mNOLkKGAs9GlOLy+wFVx+jxtEmf0rGWaUhsT1rZfRtEcVhnVkGqL1NbgXZfCW2ZK D7kw== X-Gm-Message-State: AE9vXwOOLQqtZOr7ZBoQo0fnTiLHdwHTR11MPMjbuVgWRc7tB4CqOoCciq11zDcdkOVVwA== X-Received: by 10.28.104.6 with SMTP id d6mr9760164wmc.73.1472976456560; Sun, 04 Sep 2016 01:07:36 -0700 (PDT) Received: from ?IPv6:2003:62:5f43:9500:c1f5:c528:a3d:f8c4? (p200300625F439500C1F5C5280A3DF8C4.dip0.t-ipconnect.de. [2003:62:5f43:9500:c1f5:c528:a3d:f8c4]) by smtp.googlemail.com with ESMTPSA id g62sm316802wme.18.2016.09.04.01.07.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Sep 2016 01:07:36 -0700 (PDT) From: Heiner Kallweit Subject: [PATCH v2 11/18] spi: fsl-espi: improve return value handling in fsl_espi_bufs To: Mark Brown References: Cc: "linux-spi@vger.kernel.org" Message-ID: <58e22410-1ae3-7d2d-91d1-3f827b4d0fa1@gmail.com> Date: Sun, 4 Sep 2016 10:01:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Return a proper status code from fsl_espi_bufs instead of returning the number of remaining words and let the caller evaluate it. Signed-off-by: Heiner Kallweit --- v2: - rebased --- drivers/spi/spi-fsl-espi.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/spi/spi-fsl-espi.c b/drivers/spi/spi-fsl-espi.c index f8a6dd1..8d6a570 100644 --- a/drivers/spi/spi-fsl-espi.c +++ b/drivers/spi/spi-fsl-espi.c @@ -258,7 +258,7 @@ static int fsl_espi_bufs(struct spi_device *spi, struct spi_transfer *t) /* disable rx ints */ mpc8xxx_spi_write_reg(®_base->mask, 0); - return mpc8xxx_spi->count; + return mpc8xxx_spi->count > 0 ? -EMSGSIZE : 0; } static int fsl_espi_do_trans(struct spi_message *m, struct spi_transfer *trans) @@ -288,9 +288,6 @@ static int fsl_espi_do_trans(struct spi_message *m, struct spi_transfer *trans) if (trans->len) ret = fsl_espi_bufs(spi, trans); - if (ret) - ret = -EMSGSIZE; - if (trans->delay_usecs) udelay(trans->delay_usecs);