[07/17] spi/mpc52xx: Combine substrings for two messages

Commit Message

SF Markus Elfring Jan. 13, 2017, 5:15 p.m. UTC

From: Markus Elfring <[e-mail]>
Date: Fri, 13 Jan 2017 14:14:45 +0100

The script "checkpatch.pl" pointed information out like the following.

WARNING: quoted string split across lines

Thus fix the affected source code places.

Signed-off-by: Markus Elfring <[e-mail]>
---
 drivers/spi/spi-mpc52xx.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

Comments

Mark Brown Jan. 17, 2017, 6:33 p.m. UTC | #1

On Fri, Jan 13, 2017 at 06:15:54PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <[e-mail]>
> Date: Fri, 13 Jan 2017 14:14:45 +0100
> 
> The script "checkpatch.pl" pointed information out like the following.
> 
> WARNING: quoted string split across lines
> 
> Thus fix the affected source code places.

You should provide more explanation and analysis for changes than just
saying "checkpatch" - it's not a 100% reliable tool and sometimes it
gives false positives or simply silencing the warning actually makes
things worse (as some of the other feedback on the series shows).  It is
better to provide something in the changelog which explains why the
change improves things, giving credit to checkpatch is of course nice to
do but something that shows an understanding of what it's saying really
helps.

Patch

diff --git a/drivers/spi/spi-mpc52xx.c b/drivers/spi/spi-mpc52xx.c
index 8cc129efe7ba..e8b59ce4dc3a 100644
--- a/drivers/spi/spi-mpc52xx.c
+++ b/drivers/spi/spi-mpc52xx.c
@@ -449,8 +449,7 @@  static int mpc52xx_spi_probe(struct platform_device *op)
 			gpio_cs = of_get_gpio(op->dev.of_node, i);
 			if (gpio_cs < 0) {
 				dev_err(&op->dev,
-					"could not parse the gpio field "
-					"in oftree\n");
+					"could not parse the gpio field in oftree\n");
 				rc = -ENODEV;
 				goto err_gpio;
 			}
@@ -458,8 +457,8 @@  static int mpc52xx_spi_probe(struct platform_device *op)
 			rc = gpio_request(gpio_cs, dev_name(&op->dev));
 			if (rc) {
 				dev_err(&op->dev,
-					"can't request spi cs gpio #%d "
-					"on gpio line %d\n", i, gpio_cs);
+					"can't request spi cs gpio #%d on gpio line %d\n",
+					i, gpio_cs);
 				goto err_gpio;
 			}