From patchwork Thu Sep 21 18:02:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 9964677 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8EF7B600C5 for ; Thu, 21 Sep 2017 18:04:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7E864298D1 for ; Thu, 21 Sep 2017 18:04:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7D023298E7; Thu, 21 Sep 2017 18:04:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 423F5298F6 for ; Thu, 21 Sep 2017 18:02:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751765AbdIUSCd (ORCPT ); Thu, 21 Sep 2017 14:02:33 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:46595 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751734AbdIUSCd (ORCPT ); Thu, 21 Sep 2017 14:02:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Date:Message-ID:Subject:From:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=qIf+c0wXjI+sf5aIXTpcjlLwER50Gd2H/bMgVGimP0E=; b=WsV8khMBjVFLFUbSSANIhVxDL sMYfQKCh3tkuz8N/XPCZ2xpwCjpHJp5QDLRcEXEUDA6FceOVECYK/7Wf2RK+btFdxG3yog1eW+eOV XUlA1Q3xJq9B5TMjUnR9UN4csLjxCvsNUzVClVLu8pj+5DpDbV5nzbhUbLuMetuWuIwj2jmhYAaPc rTyHSJq5YFwziM+xcezrSGiCAIJRV40rD2cnLi8AVNHm1nogWadhvv8IRWyozgSKvcVaxQPaUsdTc prS5RnFUggSQKJswfGDHTWyUgO8X6QPtzuaW2zhBnc+K/kKBE6Fu0NzYr17GKivB9eVPb0w39tA+K WSf6SBy0Q==; Received: from static-50-53-52-16.bvtn.or.frontiernet.net ([50.53.52.16] helo=midway.dunlap) by bombadil.infradead.org with esmtpsa (Exim 4.87 #1 (Red Hat Linux)) id 1dv5o0-0008PI-D3; Thu, 21 Sep 2017 18:02:32 +0000 To: LKML , linux-spi@vger.kernel.org, Mark Brown From: Randy Dunlap Subject: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when SPI_SPRD_ADI=y and HWSPINLOCK=m Message-ID: Date: Thu, 21 Sep 2017 11:02:31 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 Content-Language: en-US Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Randy Dunlap Fix build errors when CONFIG_HWSPINLOCK=m and SPI_SPRD_ADI=y. That combination is not allowed. drivers/spi/spi-sprd-adi.o: In function `sprd_adi_remove': spi-sprd-adi.c:(.text+0x13): undefined reference to `hwspin_lock_free' drivers/spi/spi-sprd-adi.o: In function `sprd_adi_probe': spi-sprd-adi.c:(.text+0xf5): undefined reference to `of_hwspin_lock_get_id' spi-sprd-adi.c:(.text+0x107): undefined reference to `hwspin_lock_request_specific' spi-sprd-adi.c:(.text+0x22e): undefined reference to `hwspin_lock_free' drivers/spi/spi-sprd-adi.o: In function `sprd_adi_transfer_one': spi-sprd-adi.c:(.text+0x2eb): undefined reference to `__hwspin_lock_timeout' spi-sprd-adi.c:(.text+0x349): undefined reference to `__hwspin_unlock' spi-sprd-adi.c:(.text+0x389): undefined reference to `__hwspin_lock_timeout' spi-sprd-adi.c:(.text+0x3ee): undefined reference to `__hwspin_unlock' v2: allow build with or without HWSPINLOCK, but restrict to =m if HWSPINLOCK=m. Signed-off-by: Randy Dunlap Cc: Baolin Wang Cc: Mark Brown Cc: linux-spi@vger.kernel.org --- drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion(+) -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- linux-next-20170921.orig/drivers/spi/Kconfig +++ linux-next-20170921/drivers/spi/Kconfig @@ -625,6 +625,7 @@ config SPI_SIRF config SPI_SPRD_ADI tristate "Spreadtrum ADI controller" depends on ARCH_SPRD || COMPILE_TEST + depends on HWSPINLOCK || HWSPINLOCK=n help ADI driver based on SPI for Spreadtrum SoCs.