From patchwork Fri Oct 12 10:01:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Disseldorp X-Patchwork-Id: 10638259 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C033B13AD for ; Fri, 12 Oct 2018 10:01:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B21032B728 for ; Fri, 12 Oct 2018 10:01:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B02072B8F9; Fri, 12 Oct 2018 10:01:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 721CB2BB0F for ; Fri, 12 Oct 2018 10:01:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728372AbeJLRdE (ORCPT ); Fri, 12 Oct 2018 13:33:04 -0400 Received: from mx2.suse.de ([195.135.220.15]:42342 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728309AbeJLRdD (ORCPT ); Fri, 12 Oct 2018 13:33:03 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B6A5AAF6D; Fri, 12 Oct 2018 10:01:24 +0000 (UTC) From: David Disseldorp To: target-devel@vger.kernel.org Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org Subject: [PATCH v2 0/5] target: improve Data-Out and NOP timeout error reporting Date: Fri, 12 Oct 2018 12:01:15 +0200 Message-Id: <20181012100120.2365-1-ddiss@suse.de> X-Mailer: git-send-email 2.13.7 Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The following patchset converts existing Data-Out and NOP ping timeout messages from pr_debug() to pr_error(), to reflect the seriousness of unexpected connection termination events. These events can be triggered using a couple of libiscsi client hacks: https://github.com/ddiss/libiscsi/tree/hack-lio-trigger-dataout-timeout https://github.com/ddiss/libiscsi/tree/hack-lio-trigger-nop-timeout Cheers, David --- Changes since v1 - split out and use a helper function for cxn timeout error stashing - add I_T Nexus to error messages drivers/target/iscsi/iscsi_target_erl0.c | 15 +-------------- drivers/target/iscsi/iscsi_target_erl1.c | 17 ++++++++++++----- drivers/target/iscsi/iscsi_target_stat.c | 4 ++-- drivers/target/iscsi/iscsi_target_util.c | 43 ++++++++++++++++++++++++------------------- drivers/target/iscsi/iscsi_target_util.h | 1 + include/target/iscsi/iscsi_target_core.h | 6 +++--- include/target/iscsi/iscsi_target_stat.h | 4 ++-- 7 files changed, 45 insertions(+), 45 deletions(-)