diff mbox

[2/3] tcmu: return on first Opt parse failure

Message ID 1488431681-15481-3-git-send-email-mchristi@redhat.com (mailing list archive)
State Superseded
Headers show

Commit Message

Mike Christie March 2, 2017, 5:14 a.m. UTC 
We only were returing failure if the last opt to be parsed failed.
This has a return failure when we first detect a failure.

Signed-off-by: Mike Christie <mchristi@redhat.com>
---
 drivers/target/target_core_user.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Nicholas A. Bellinger March 8, 2017, 8:51 a.m. UTC | #1 
On Wed, 2017-03-01 at 23:14 -0600, Mike Christie wrote:
> We only were returing failure if the last opt to be parsed failed.
> This has a return failure when we first detect a failure.
> 
> Signed-off-by: Mike Christie <mchristi@redhat.com>
> ---
>  drivers/target/target_core_user.c | 3 +++
>  1 file changed, 3 insertions(+)

Applied to target-pending/master.

Thanks MNC.

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
index b1444a3..266dc82 100644
--- a/drivers/target/target_core_user.c
+++ b/drivers/target/target_core_user.c
@@ -1120,6 +1120,9 @@  static ssize_t tcmu_set_configfs_dev_params(struct se_device *dev,
 		default:
 			break;
 		}
+
+		if (ret)
+			break;
 	}
 
 	kfree(orig);