From patchwork Thu Mar 16 04:05:59 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 9627099 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B850060244 for ; Thu, 16 Mar 2017 04:13:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 99F3A285EB for ; Thu, 16 Mar 2017 04:13:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8AE1C28604; Thu, 16 Mar 2017 04:13:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A504A285EB for ; Thu, 16 Mar 2017 04:13:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750858AbdCPENU (ORCPT ); Thu, 16 Mar 2017 00:13:20 -0400 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:51106 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750877AbdCPENS (ORCPT ); Thu, 16 Mar 2017 00:13:18 -0400 X-IronPort-AV: E=Sophos;i="5.36,170,1486396800"; d="scan'208";a="3645105" Received: from mail-dm3nam03lp0018.outbound.protection.outlook.com (HELO NAM03-DM3-obe.outbound.protection.outlook.com) ([207.46.163.18]) by ob1.hgst.iphmx.com with ESMTP; 16 Mar 2017 12:11:28 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=1LuIJ8hz7tMjcw3wRfb3sD94/KqdZadtjCkmR+/XKbE=; b=Ew7PRPT5LaEB0ZhAdou76jR3Ki5RSQN6FvXkFHdvetPazOfQrXgvbS69CLOsN6GVCoY4hpajadCO6hcHZzgmlBjJjVXEc42PF6h8eOnHWdpcaIvV7iB6LIybj4KXAr3n0/FVNAYllfs3Vmq8hIj+wEV0tmJbcl2HNca7CNjXdN4= Received: from BN6PR04CA0015.namprd04.prod.outlook.com (10.172.194.25) by DM2PR04MB525.namprd04.prod.outlook.com (10.141.99.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.919.13; Thu, 16 Mar 2017 04:11:26 +0000 Received: from SN1NAM04FT027.eop-NAM04.prod.protection.outlook.com (2a01:111:f400:7e4c::205) by BN6PR04CA0015.outlook.office365.com (2603:10b6:404:cb::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.977.11 via Frontend Transport; Thu, 16 Mar 2017 04:11:25 +0000 Authentication-Results: spf=pass (sender IP is 74.221.232.54) smtp.mailfrom=sandisk.com; cavium.com; dkim=none (message not signed) header.d=none;cavium.com; dmarc=bestguesspass action=none header.from=sandisk.com; Received-SPF: Pass (protection.outlook.com: domain of sandisk.com designates 74.221.232.54 as permitted sender) receiver=protection.outlook.com; client-ip=74.221.232.54; helo=sacsmgep14.sandisk.com; Received: from sacsmgep14.sandisk.com (74.221.232.54) by SN1NAM04FT027.mail.protection.outlook.com (10.152.88.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.961.10 via Frontend Transport; Thu, 16 Mar 2017 04:11:25 +0000 X-AuditID: ac1c2133-9afff7000000c960-49-58ca0f29e39e Received: from SACHUBIP02.sdcorp.global.sandisk.com (Unknown_Domain [172.28.1.254]) (using TLS with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by (Symantec Messaging Gateway) with SMTP id 57.D7.51552.92F0AC85; Wed, 15 Mar 2017 21:06:03 -0700 (PDT) Received: from ULS-OP-MBXIP03.sdcorp.global.sandisk.com ([fe80::f9ec:1e1b:1439:62d8]) by SACHUBIP02.sdcorp.global.sandisk.com ([10.181.10.104]) with mapi id 14.03.0319.002; Wed, 15 Mar 2017 21:06:00 -0700 From: Bart Van Assche To: "himanshu.madhani@cavium.com" , "target-devel@vger.kernel.org" , "nab@linux-iscsi.org" CC: "giridhar.malavali@cavium.com" Subject: Re: [PATCH v4 00/14] qla2xxx: Bug Fixes and updates for target. Thread-Topic: [PATCH v4 00/14] qla2xxx: Bug Fixes and updates for target. Thread-Index: AQHSngqeA/HRqD94V0qk8aeb6cdHKw== Date: Thu, 16 Mar 2017 04:05:59 +0000 Message-ID: <1489637143.5578.1.camel@sandisk.com> References: <20170315164856.17255-1-himanshu.madhani@cavium.com> In-Reply-To: <20170315164856.17255-1-himanshu.madhani@cavium.com> Accept-Language: en-US, nl-NL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.28.1.254] Content-ID: <240415FB59FC574F8FA579CA8D90BBCF@sandisk.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprPIsWRmVeSWpSXmKPExsWyRobxn642/6kIg8kv5S32PDjHZnFhTzej RdvqM4wWrUvfMjmweMz4vYjF4/72I0wenzfJBTBHcdmkpOZklqUW6dslcGUsufCHqeCJWsWy M+/ZGxifqHYxcnJICJhIzPm8ibWLkYtDSGAJk8TOvi+MEM4lRonv32+ygFSxCRhJzJ6whwUk ISKwnlHi0JwpbCAJZgFHiTn9t5lBbGEBD4k5b06wgtgiAp4SHWuWMEHYehLvp28GinNwsAio Smw9BBbmFTCUeLNkFztIWEjAQaLlqRRImBNo4qeJ/ewgNqOArMTi6S1MEJvEJW49mc8EcbSA xJI955khbFGJl4//sULYChKfV/xjAxnJLKApsX6XPoRpJfGsXQ1iiqLElO6H7BAHCEqcnPmE ZQKj2CwkC2YhNM9CaJ6FpHkWkuYFjKyrGMWKE5OLc9NTCwxN9IoT81Iyi7P1kvNzNzGCo03R eAfjvw3uhxgFOBiVeHgn+J6MEGJNLCuuzD3EKMHBrCTC+4D7VIQQb0piZVVqUX58UWlOavEh RmkOFiVx3pjZUyOEBNITS1KzU1MLUotgskwcnFINjJvEBY4FmHhkPKmo3cD33fXQ+Sifu3y+ ovlTb92vUi4V+X4xft3zc83Sl1cXevu/7Uib9Wf18X1y3LUVtou+eD8+vtZR8ii3xAPmGbN7 1h1al8YYunxHaGTqyb/Td22fzHBLr2Dqif4qq7ue63uMj4exXzhU36qYX9OxLvYhe76M0dws ng9vfyixFGckGmoxFxUnAgD7agHcsgIAAA== X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:74.221.232.54; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(39450400003)(39840400002)(39410400002)(39850400002)(39860400002)(2980300002)(438002)(189002)(51234002)(24454002)(377424004)(199003)(9170700003)(2950100002)(4326008)(86362001)(2201001)(305945005)(81166006)(106466001)(103116003)(7736002)(5660300001)(23676002)(8936002)(2906002)(2501003)(229853002)(2900100001)(36756003)(38730400002)(47776003)(53936002)(54356999)(356003)(189998001)(76176999)(50466002)(102836003)(33646002)(3846002)(6116002)(6246003)(8676002)(50986999); DIR:OUT; SFP:1102; SCL:1; SRVR:DM2PR04MB525; H:sacsmgep14.sandisk.com; FPR:; SPF:Pass; MLV:sfv; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; SN1NAM04FT027; 1:FZlo5UFCJFNPwfa0pHip83F0KHAI/tuPNyCNksapeTm2tOhBUaGs2KKIdBhN7TFaKcizhk1aDUGPsB96DaV1JieK8K9KOPzmN7fH94UaPY/1tqRC4Iv4udSzYlWpPzsU5RJnxCLJzpoXBvbWJtHwYlrRTdaTg6kM2OtHUTiPgO6V5FxjRJGyTVPpkdmsu7vUVz4a5ki2AcyI5skFkCVhAIf5MnBv51JjVyOw5skNVHMSMK9bHNzH9vHkTlmtYBaEhjBr4+ACJqXk6fiO6Pj8SutIseupIp9eJNemGNuNhKpXiIftztwlsVYneRDt1b+knUvnzoRni6WpLhyqTLTG2OoltwYN2HEtySP6niaYeqjMuRYj2kN7POmzcJAzTUCSkwAfSeWFAOx/XEN5SQR+uk56xZkCo+g2PAZGuJ8z0KzFAWxaOQFwflCXelxBecNj1pqO29AbQqTigTKuNr8ZJYO5byigXqCftXughVJLTFW8QD5L+dwAjQekZrWkMROg9iOX204YNc7ydNBH6YtzzA== X-MS-Office365-Filtering-Correlation-Id: 9500d017-30e9-4749-7b0a-08d46c228375 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(8251501002); SRVR:DM2PR04MB525; X-Microsoft-Exchange-Diagnostics: 1; DM2PR04MB525; 3:2k6mJuZmaOg0YK7tZmpYUYSLV9GNx42IWhpsk4KnlVppN5Nfe8TRSvp3au8y6e6x3OfYfN+6L7u3vp0rAF2uHBsDNOh7C5brkFQe9z00akCoeIbFBQOT7yDaF7/tNB77bsCv5mRRsXjPCAz2wig+bBLcGzT7uR4wGOm2iGASPj1BItXeurvCp5NgRgfjBDd4U90dgdu+8pcfSjqFq1dYo06cxRc51W5WBQh2MAp9x9510RVwIdCHjJLyZNq4t76xXZZc8bcQW4POVTxhcogNvZATUI2FB/Mf11tI1NURVMTEjuqkYE+B1lI2FvYe1nlz/RvZdla1cPt1PTcKRLptIR93KjCiThxy7uK48puMAoLrVN8O9WhvDR4/oGXwvLgTEsHn7c0V4NJD7ZUegMHwgA==; 25:SOIPtJJ5wbmax2i4Y8XowIyFix2aQmRHFHKvbM94GxnU8s48dCZ8v5f5Vxwg+a3GU26b2P4mOSk962QKFDme9NgejOFwUYOvAn+7oFcBy6efCmu/V+WrasXpRFu6gycRaN0B5VeLCMR0DYokEvyLLBFDQgfVXlR9Xto4nP9ajbeeTEZIQJkISpzcGoAhdKxvofc9QluuM9Orp4pjwY3RldQh+HUKnvygUJ9Kq4oRy2nWym+FS0JLx1J0LM+/3CdBfAoOoZira/ZDEFT3ofr/+prv8MHYKpIzmW5h1do+9kv/iHpBXjZAFVN4yssvbVPneyZtbBd0RM83CrC8GUlWd0/cvr9iFlsij27PyINUIXGvoj0ajzIwP8auApymUm2RbPB/lapnYV9bMm+dVw8SdMYxiLL4dnt9Y1cuCieskIj9JEQmQ/n1xVXNQ17I47M+vrBSVHqHyGpOScWwD45lpg== X-Microsoft-Exchange-Diagnostics: 1; DM2PR04MB525; 31:nq8mhDA/vMSNbu0BRdSFVDVEGDgakAEKDseZZN6ELNlA8Nphp9m5Rg+C0OEII2Ipc5YKt8e1lYKXg2R8ZCjV1D/8rWJZXpjatdNoXZOIdZrNsr0KD5ZczIIdqK044zD5gYE5oO+YaBwb8DWGzJJA7fEVUMM7Mj4Jw5M6i55/wSz/tzFLqFILKLlyCB2D8vs+75jIlc5oymgITjBq/vDBZ2tI/5swgsMHPak69rbcNe8uvoa16JpprzNaDe4YBiCTPZUjCmo0n6F3DjrzR9MGgQ==; 20:2mSwRaHxm4ObeBNExHsb/O6ubbrdhE222WvCSlwjXoB768X+jsdPae8BOHpxWTtF8oM4VRujfxQW0+bcKSnmtzGfKWveuP1QMISpBDim8qm7IPZBVbJI/qZOWmxERP2S+31PPbeaLWpTZRoWckvLlXS2CN3UiKy/NrJ8GA5y/Nw5+2/zs3Ql4AhpQVbJvO0UYK96+oYm7y7AC4SrDQD1zeVv0BaxkRnDXNRKju7QI43Gm3C3f6dKlOMhV7VpJCg5T6U2nvr8niUaNugzf08bjajmStec0/gYC1ZLoxqATvIJV5LDNxN7a6xSR9Zi6IrtJsyNHyW1VUlLvclIyGnnbSuPyTsvSnVkYMS043pcBqwmUwl3SvMF2FY5u/Kbd8XlrNIU49cHRRgnFUHGYPJvaCY3rOFCPIk9YNuXjEAsfYIkFn3TIUvn3sdlodwynW+p3Y0GD7NEQUsUBNg+AVGbzz28ZTPldK3xHIYNOg34wCdCTy/hxmQ4ij8EWOQNGba5 WDCIPOUTBOUND: EOP-TRUE X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(42932892334569); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(13024025)(13023025)(13018025)(13016025)(3002001)(10201501046)(6055026)(6041248)(20161123560025)(20161123562025)(20161123564025)(20161123555025)(20161123558025)(6072148); SRVR:DM2PR04MB525; BCL:0; PCL:0; RULEID:; SRVR:DM2PR04MB525; X-Microsoft-Exchange-Diagnostics: 1; DM2PR04MB525; 4:e33+d26eCLhWsNIJn2jQkcf6UFPRWyxnJS9dXvnGo9yfpIVvu720gFVxcudWwS0ZRfDox1omApbfQPXqZTy/4bKVPXLy2e7xVGq4/ngH++VZG/j6mNqgc5HthTt1sYo8xLCrY6gU3K6IWEjH+9rnAIY/6POyUGcyUfoLFfQP/nxonUeKl0FPYT5jvQD7kHj9NElmKfiJhk49I9KoWQlc0bpAxl/uM32cFZNIwkPhm/rX9uOPb2KTddl3LhktPkQSjHASLnk8CpQtnDKIV35n5W5MtZGvCGxbJJ0z9AYkk6HFdCH46BObXi/QKhg9aV7FxDp/mesW+0/9TZRON6qEnXrh46/BtQZCmyQXC/XpXa6MH32gPG8iIlu4eGVph4/lrBCyreGmcftz8x+Yo8O2+QF+edW0/MTKfqUGSvMgHtLmkkfICpkEoh/1I+20RihgrCjmT1oVzoTO93Gs3JZCNxHeQMhVXDZp23bGTherLYVha8kOA09jgtuIqGHfqFyAJwUedVnhL+cO2FLImK4FvjmbL6DjPa8O5eShHm+6XKQlrsJwctUycFOb8PYgrtHEV/J6yuTxJSs+x1kFfUNN1Weg37a+QGIe3/45Dxh86jN6O9Q/dg4ojNOcC2/8x2oQHN2VcupfY7Oqa9kPBdwqLdT2FPuXv4oUuIXKGpU6rycD7nRTP8XJQIucmeJJ8gsmul1nGQ4AMXdJ1+QdCOcc0GKYRB9Tm0aCTLiuHdnrukydV2MiZRjdy8KY45UjXDw3 X-Forefront-PRVS: 024847EE92 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTJQUjA0TUI1MjU7MjM6enR5TFBtNnVpcGtwZWpCanZocEJxak9LcXZB?= =?utf-8?B?bWQ5RDZMUGc0MkFpdnREY0VMbEZtTW5iSWVaZXBianlVdFpWaVZvM2tlYy94?= =?utf-8?B?d1pIV1pVVUJWOEdPZHRabXU4V3hjOEV6QSs1TFVRMncrcWhMbVpkeVUzQUM4?= =?utf-8?B?Wk0yVHZFemI4ZTN3T29CbFhhZnBqSTk5Vzk0Snd0Z2ZER2l3aU15Rm5jSWlw?= =?utf-8?B?a2l4RXV3UVBENVV0Q1Y5cFZHazA5RnZsc0w0SnY2MWxKM3dwK3BzQ0o2cXNp?= =?utf-8?B?U2JmS3NHbElaNU1pZU9NV0VTSU92ekZ1NHpWNERkUGhVMUppYUlxeFJLL05L?= =?utf-8?B?OE8vYUlVNGkweXVXd0Y5QUIvbEYyYlBoVXRxUkh3cTNzcVNmZFpUd2M5UGVL?= =?utf-8?B?V3NUVDIxam1GWm8zSVhWcm9aTVVMSXlhcGZOSjJITG1BV3I4dHI5OWd4QllL?= =?utf-8?B?ZWtRaVgvVHBBMXBuTStodFZ5TW9TMU04VkoyVHJJelg3Z0o0c0dJNlV6ZnNa?= =?utf-8?B?RzltUDYrejRSK3JhUlNkTURYZjNXWHF3VUI1aXJHQ1A4VTF1YzF4M0x6VDZ5?= =?utf-8?B?akk4cE1mQVFXZlFhYWlwc2RqVTc3WVlmODhoQXdaOHRScVlZRjZCTjZadGJJ?= =?utf-8?B?bXBneVVrRk4vM0tsNnNqYk04MzdORkZadHVmQzRHem1IVm04eSs1azA2RTk2?= =?utf-8?B?L0loaWovbUNJeExXS2JEc21sQ0JWN3E0ZmxoSHdBNWJaaGsxTHRWMUJxbE50?= =?utf-8?B?dnd2RDQxMmRrUDhGNG1oOFRNQ0hSZWY2ZHU3ZlAvd1lWNlNNeGd1MTc0UGJj?= =?utf-8?B?RDZUeWUzMUtYY2kzSUpsUjh4R2p1T3V0VFhHOEZ4aHN3V3BYemRGcytEUFpo?= =?utf-8?B?U0JIYi9JZVN2b0JrZWMyTnRhbzNFNGFZWlJrS2lELzNZbFVGVk5ocWJ1N0li?= =?utf-8?B?bTFNMlFWTUszcFg5Ulo5ZzFwcWZQSVhMS1RycjZ5N3dJMk90MGFHYXRXS3ZI?= =?utf-8?B?Z0JNZWxtNGhZSHAycGNmQTVobjFYWnpycWFWQUpQSVp6YVduNUFTVEJpYVhJ?= =?utf-8?B?OWJUVHp0OXg4Si9Ccno3S3lqdUs2Kzc4dE9PRURRNkY5MTl6WEd6K0lQekZv?= =?utf-8?B?ZUpOUnNwWTNkdHNLVG10ZUh1SjhDVFJtMzB5VUJldjJPRElBNHFTVmZhRnQ0?= =?utf-8?B?YXU5cXlQVzJzZ0xXUVliWSs2T3dCdGJWMFJUd2dCUUZEU0hKVm1RNXZZTWV3?= =?utf-8?B?Vnlac0JFYzMycG5LSWVManFTWGhQNDBRTE51eHZKbVVSMTZVS0szdjl3Ly9N?= =?utf-8?B?QmlvV2pvTkdGRkJXSDJLblpwOTJMQzN0dHkzeDNvbWNJSTRFSHZkMlFkd0VN?= =?utf-8?B?Q2YybEY3WHVGLzNpV1BPNDNvWno0NDF4TzNtTW1xTFNaSmE3eHo5VWxLOWNO?= =?utf-8?B?emVPbXVqNjRPbFRId3FUTnlCTGl5SC8xOVZPVk4rQ1lLd1JrdmxQNGRQRmNV?= =?utf-8?Q?SKlu88pNTg1xQv51i9T6u75zi0IPDwZlmAQLRHhWNopP7?= X-Microsoft-Exchange-Diagnostics: 1; DM2PR04MB525; 6:iJWg/brf1mBhke63UEY/SW3mAjWRmuSMnU+2v4usxGb9JyG/lD41d9FVtYZqxCmOSqqMipm9m8BB5ZSChdC2wuNK9nhySYLh32O/xwiPIRaKG9zsq7U+eCDqLom1HGu0hkNlMMT6vhFrBm2JeLarzde5sIz3081ysf9HGH+nHFHCCaLoypf/Ugm5MOPH5x3SfHbMBXNNzkfMC+3z2Spa2zzxSRww8QtQY2nd+XgTYwt/PFnUN4X+hgiXpsM5EOzY7u0a1r6w6yLHeaBnKgztY99ZvFJp7V4lqIfMu/vKZZRfxqcW3Oc13FqHTdNNJkb1B2zlJCZ6ZVlAoHVAqsBKsvN+xmzj6/S7G5CXt/4FdpS2qZPrOUkAgShtkOsKXerBbgNyyrEezYdBGsBZp8+M65AxkWYSyq4LxOuy/esT6dk=; 5:L8KxhXXgKPMULOdWJ7rABlBt9DIKo4R9v4DzG3suxuT7xPm7IfVilne/t4jJAhNJ6Lnhh9Sm21PuiLTh0gvcdaeFxgCAsMnCsQnPXPLY/nVDcuTqMyVBPrzH6SCYX5TzMNQA/gY6fU4l5U+COf88DA==; 24:RIzUP579t5Hpjkh3RJwvsF3iU3zWOh6VtuDOOHzyoIOYq0sFUeiywNxEsn7oyL+Tm3u+QMAGc+gCprRVBcp7bWbw/ImxkfSbFTbGpIu06IY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM2PR04MB525; 7:RL3B8+gNTj4BzLL3FJ6Y+x5RIuuJIiRxcBdwPhbM1ROYvDKQiEgneCLHzOIJ8ty4i1Vob/4FR/HYVexytTgHAIzIngLNG/lK2la2IwJSJJwnuKR9YtWBY3RCAqsiKpOhYSKT2i3uLe7aBa8mV5thnuCxKXS15n44OTUyYX8EJ9WQRHQNxa/OOfTjg8pn6kT4n51IAT3H1SLEJm1ydUYFrVnpXxE77tcsxib/IiOGf0/ek5fJ+RAmNWt2jGJiTc5DFQTbDb6yHfhel8hk8CeBLgZvK0nu5im3Uj9z6Hc9CLo8x/O75nr/N+CnfL68JwGr4Fvim9OSxBrs1wepA03YUA==; 20:xO9O0tUobZ/ug310bSLwjhN3skHlAAailMc6P91LtfiZ2KXl9veyHKs33dvbKrpKhnViK5dmbyvzxFedn+1YaQXhCDqTlXHYE2hSKBQdd+BhJkhcMmUpbAL3bD3ueVkWOpvF2KvLQ0jo8+iOHrOb44yvXSYCwcMNViAqjVFEd2w= X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2017 04:11:25.1909 (UTC) X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=b61c8803-16f3-4c35-9b17-6f65f441df86; Ip=[74.221.232.54]; Helo=[sacsmgep14.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR04MB525 Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, 2017-03-15 at 09:48 -0700, Himanshu Madhani wrote: > o Fixed regression repored by Bart in following patch. > "qla2xxx: Fix delayed response to command for loop mode/direct connect." Thanks for having fixed this! BTW, while retesting this patch series I ran into another (longstanding) bug. Please consider to include the (untested) patch below in a future patch series. Bart. [PATCH] qla2xxx: Avoid using smp_processor_id() where inappropriate Use queue_work(...) instead of queue_work_on(raw_smp_processor_id(), ...). These two calls have the same effect for workqueues for which WQ_UNBOUND has not been set. This patch avoids that the following is reported: BUG: using smp_processor_id() in preemptible [00000000] code: kworker/u16:0/5 caller is debug_smp_processor_id+0x17/0x20 CPU: 4 PID: 5 Comm: kworker/u16:0 Not tainted 4.11.0-rc2-dbg+ #1 Workqueue: tmr-iblock target_tmr_work [target_core_mod] Call Trace: dump_stack+0x86/0xc3 check_preemption_disabled+0xe2/0xf0 debug_smp_processor_id+0x17/0x20 tcm_qla2xxx_free_cmd+0x92/0xd0 [tcm_qla2xxx] tcm_qla2xxx_aborted_task+0x74/0x80 [tcm_qla2xxx] transport_cmd_finish_abort+0x54/0x80 [target_core_mod] core_tmr_lun_reset+0x38f/0x800 [target_core_mod] target_tmr_work+0xdb/0x130 [target_core_mod] process_one_work+0x20d/0x6c0 worker_thread+0x4e/0x4a0 kthread+0x10c/0x140 ret_from_fork+0x31/0x40 Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_target.c | 14 ++++---------- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 4 ++-- 2 files changed, 6 insertions(+), 12 deletions(-) -- 2.12.0 diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 0e03ca2ab3e5..8c9906ac9bbc 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -4197,6 +4197,7 @@ static int qlt_handle_cmd_for_atio(struct scsi_qla_host *vha, struct fc_port *sess; struct qla_tgt_cmd *cmd; unsigned long flags; + int cpu; if (unlikely(tgt->tgt_stop)) { ql_dbg(ql_dbg_io, vha, 0x3061, @@ -4263,16 +4264,9 @@ static int qlt_handle_cmd_for_atio(struct scsi_qla_host *vha, spin_unlock_irqrestore(&vha->cmd_list_lock, flags); INIT_WORK(&cmd->work, qlt_do_work); - if (ha->msix_count) { - if (cmd->atio.u.isp24.fcp_cmnd.rddata) - queue_work_on(smp_processor_id(), qla_tgt_wq, - &cmd->work); - else - queue_work_on(cmd->se_cmd.cpuid, qla_tgt_wq, - &cmd->work); - } else { - queue_work(qla_tgt_wq, &cmd->work); - } + cpu = ha->msix_count && !cmd->atio.u.isp24.fcp_cmnd.rddata ? + cmd->se_cmd.cpuid : raw_smp_processor_id(); + queue_work_on(cpu, qla_tgt_wq, &cmd->work); return 0; } diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tcm_qla2xxx.c index 7443e4efa3ae..0f1ee1680eb8 100644 --- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c +++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c @@ -303,7 +303,7 @@ static void tcm_qla2xxx_free_cmd(struct qla_tgt_cmd *cmd) cmd->trc_flags |= TRC_CMD_DONE; INIT_WORK(&cmd->work, tcm_qla2xxx_complete_free); - queue_work_on(smp_processor_id(), tcm_qla2xxx_free_wq, &cmd->work); + queue_work(tcm_qla2xxx_free_wq, &cmd->work); } /* @@ -570,7 +570,7 @@ static void tcm_qla2xxx_handle_data(struct qla_tgt_cmd *cmd) cmd->trc_flags |= TRC_DATA_IN; cmd->cmd_in_wq = 1; INIT_WORK(&cmd->work, tcm_qla2xxx_handle_data_work); - queue_work_on(smp_processor_id(), tcm_qla2xxx_free_wq, &cmd->work); + queue_work(tcm_qla2xxx_free_wq, &cmd->work); } static int tcm_qla2xxx_chk_dif_tags(uint32_t tag)