[04/11] target: add helper to find se_device by dev_index v2

Commit Message

Mike Christie June 16, 2017, 9:47 p.m. UTC

This adds a helper to find a se_device by dev_index. It will
be used in the next patches so tcmu's netlink interface can
execute commands on specific devices.

v2:
- Add depend/undepend support.

Signed-off-by: Mike Christie <[e-mail]>
---
 drivers/target/target_core_device.c  | 24 ++++++++++++++++++++++++
 include/target/target_core_backend.h |  2 ++
 2 files changed, 26 insertions(+)

Comments

Bart Van Assche June 21, 2017, 6:15 p.m. UTC | #1

On Fri, 2017-06-16 at 16:47 -0500, Mike Christie wrote:
> This adds a helper to find a se_device by dev_index. It will
> be used in the next patches so tcmu's netlink interface can
> execute commands on specific devices.

Reviewed-by: Bart Van Assche <[e-mail]>--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
index 25fbc27..544e38e 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -880,6 +880,30 @@  sector_t target_to_linux_sector(struct se_device *dev, sector_t lb)
 }
 EXPORT_SYMBOL(target_to_linux_sector);
 
+/**
+ * target_find_device - find a se_device by its dev_index
+ * @id: dev_index
+ * @do_depend: true if caller needs target_depend_item to be done
+ *
+ * If do_depend is true, the caller must do a target_undepend_item
+ * when finished using the device.
+ *
+ * If do_depend is false, the caller must be called in a configfs
+ * callback or during removal.
+ */
+struct se_device *target_find_device(int id, bool do_depend)
+{
+	struct se_device *dev;
+
+	mutex_lock(&g_device_mutex);
+	dev = idr_find(&devices_idr, id);
+	if (dev && do_depend && target_depend_item(&dev->dev_group.cg_item))
+		dev = NULL;
+	mutex_unlock(&g_device_mutex);
+	return dev;
+}
+EXPORT_SYMBOL(target_find_device);
+
 void target_init_device_idr(void)
 {
 	idr_init(&devices_idr);
diff --git a/include/target/target_core_backend.h b/include/target/target_core_backend.h
index 3dbcacd..1f2b700 100644
--- a/include/target/target_core_backend.h
+++ b/include/target/target_core_backend.h
@@ -106,6 +106,8 @@  sense_reason_t	transport_generic_map_mem_to_cmd(struct se_cmd *,
 sense_reason_t passthrough_parse_cdb(struct se_cmd *cmd,
 	sense_reason_t (*exec_cmd)(struct se_cmd *cmd));
 
+struct	se_device *target_find_device(int id, bool do_depend);
+
 bool target_sense_desc_format(struct se_device *dev);
 sector_t target_to_linux_sector(struct se_device *dev, sector_t lb);
 bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,