diff mbox

[12/34] target: Remove an overly chatty debug message

Message ID 20170125233646.2243-13-bart.vanassche@sandisk.com (mailing list archive)
State Superseded
Headers show

Commit Message

Bart Van Assche Jan. 25, 2017, 11:36 p.m. UTC
Enabling dynamic debug for the target_core_mod kernel module
causes the system log to be spammed with the "Incremented ..."
message. Hence remove it.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Andy Grover <agrover@redhat.com>
Cc: David Disseldorp <ddiss@suse.de>
---
 drivers/target/target_core_transport.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Hannes Reinecke Jan. 26, 2017, 7:59 a.m. UTC | #1
On 01/26/2017 12:36 AM, Bart Van Assche wrote:
> Enabling dynamic debug for the target_core_mod kernel module
> causes the system log to be spammed with the "Incremented ..."
> message. Hence remove it.
> 
> Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Andy Grover <agrover@redhat.com>
> Cc: David Disseldorp <ddiss@suse.de>
> ---
>  drivers/target/target_core_transport.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
> index 6c451ea4f429..9881f0ac08d2 100644
> --- a/drivers/target/target_core_transport.c
> +++ b/drivers/target/target_core_transport.c
> @@ -1970,8 +1970,6 @@ static void transport_complete_task_attr(struct se_cmd *cmd)
>  	if (cmd->sam_task_attr == TCM_SIMPLE_TAG) {
>  		atomic_dec_mb(&dev->simple_cmds);
>  		dev->dev_cur_ordered_id++;
> -		pr_debug("Incremented dev->dev_cur_ordered_id: %u for SIMPLE\n",
> -			 dev->dev_cur_ordered_id);
>  	} else if (cmd->sam_task_attr == TCM_HEAD_TAG) {
>  		dev->dev_cur_ordered_id++;
>  		pr_debug("Incremented dev_cur_ordered_id: %u for HEAD_OF_QUEUE\n",
> 
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
Christoph Hellwig Jan. 26, 2017, 5:32 p.m. UTC | #2
Looks fine,

Reviewed-by: Christoph Hellwig <hch@lst.de>
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
index 6c451ea4f429..9881f0ac08d2 100644
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
@@ -1970,8 +1970,6 @@  static void transport_complete_task_attr(struct se_cmd *cmd)
 	if (cmd->sam_task_attr == TCM_SIMPLE_TAG) {
 		atomic_dec_mb(&dev->simple_cmds);
 		dev->dev_cur_ordered_id++;
-		pr_debug("Incremented dev->dev_cur_ordered_id: %u for SIMPLE\n",
-			 dev->dev_cur_ordered_id);
 	} else if (cmd->sam_task_attr == TCM_HEAD_TAG) {
 		dev->dev_cur_ordered_id++;
 		pr_debug("Incremented dev_cur_ordered_id: %u for HEAD_OF_QUEUE\n",