From patchwork Wed Jan 25 23:36:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 9538139 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 523C46042C for ; Wed, 25 Jan 2017 23:37:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2319D27F17 for ; Wed, 25 Jan 2017 23:37:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1805B27FC0; Wed, 25 Jan 2017 23:37:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F26FF27F17 for ; Wed, 25 Jan 2017 23:37:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752162AbdAYXhU (ORCPT ); Wed, 25 Jan 2017 18:37:20 -0500 Received: from mail-bn3nam01on0065.outbound.protection.outlook.com ([104.47.33.65]:26907 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751933AbdAYXhE (ORCPT ); Wed, 25 Jan 2017 18:37:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sandiskcorp.onmicrosoft.com; s=selector1-sandisk-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=GQzCsxwhWwhM5BBQ3nrro27HKkZy3bFBnOMZDZCkij0=; b=d2+AH5oD749rl3Jl1sE1NQevXxsRtA6lRcg8JwgXL+bx2mcaDlqdIj8O2cZmVC3+ny+KaeGltR2OndXOt2/2dFYi8UzWwxTdve6nCaoebMshcN3rm7Gd3U0ZiLw1UzZPiSVO8x2dyeqTbhJ1HJB3x3AJrrYZUxJCB6BbGgbD4uw= Received: from CY1PR0201CA0005.namprd02.prod.outlook.com (10.163.30.143) by BY2PR02MB043.namprd02.prod.outlook.com (10.242.44.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.860.13; Wed, 25 Jan 2017 23:36:55 +0000 Received: from BN1AFFO11FD016.protection.gbl (2a01:111:f400:7c10::153) by CY1PR0201CA0005.outlook.office365.com (2a01:111:e400:58b9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.874.12 via Frontend Transport; Wed, 25 Jan 2017 23:36:56 +0000 Authentication-Results: spf=pass (sender IP is 63.163.107.21) smtp.mailfrom=sandisk.com; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=bestguesspass action=none header.from=sandisk.com; Received-SPF: Pass (protection.outlook.com: domain of sandisk.com designates 63.163.107.21 as permitted sender) receiver=protection.outlook.com; client-ip=63.163.107.21; helo=milsmgep15.sandisk.com; Received: from milsmgep15.sandisk.com (63.163.107.21) by BN1AFFO11FD016.mail.protection.outlook.com (10.58.52.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.803.8 via Frontend Transport; Wed, 25 Jan 2017 23:36:54 +0000 Received: from MILHUBIP03.sdcorp.global.sandisk.com (Unknown_Domain [10.201.67.162]) (using TLS with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by (Symantec Messaging Gateway) with SMTP id 3B.C8.65426.6C339885; Wed, 25 Jan 2017 15:24:54 -0800 (PST) Received: from milsmgip11.sandisk.com (10.177.8.100) by MILHUBIP03.sdcorp.global.sandisk.com (10.177.9.96) with Microsoft SMTP Server id 14.3.319.2; Wed, 25 Jan 2017 15:36:50 -0800 X-AuditID: 0ac94369-b62949800001ff92-2f-588933c6abd6 Received: from exp-402881.sdcorp.global.sandisk.com ( [10.177.9.6]) by (Symantec Messaging Gateway) with SMTP id DD.35.16817.19639885; Wed, 25 Jan 2017 15:36:49 -0800 (PST) From: Bart Van Assche To: Bart Van Assche CC: , Christoph Hellwig , "Andy Grover" , David Disseldorp Subject: [PATCH 22/34] target: Remove several state tests from TMF code Date: Wed, 25 Jan 2017 15:36:34 -0800 Message-ID: <20170125233646.2243-23-bart.vanassche@sandisk.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170125233646.2243-1-bart.vanassche@sandisk.com> References: <20170125233646.2243-1-bart.vanassche@sandisk.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKLMWRmVeSWpSXmKPExsXCddJ5ke4x484Ig9knVSz2z3rGZPH1/3QW i5WrjzJZtC59y+TA4rH7ZgObx/t9V9k8Np+u9vi8SS6AJYrLJiU1J7MstUjfLoEr48fEXtaC /2IVn7YfZGpgbBbuYuTkkBAwkTh4ZjJ7FyMXh5DAUiaJmZ9+soIkhAR2MEocXBsNU7TkQRcT RNFGRoknc5czgSTYBIwkvr2fyQJiiwgYSPzuvcAIUsQs0MEoMb/nGdAkDg5hAXeJ/umZIDUs AqoSz69sYwexeQXsJaa+W8QMsUBeYlfbRbDFnEDx1rM/WSCOsJNYf6AVbLGEQBOrxLMzX5kg mgUlTs58AlbELCAhcfDFC2aIBnWJk0vmM01gFJqFpGwWkrIFjEyrGMVyM3OKc9NTCwxN9YoT 81Iyi7P1kvNzNzFCAjtzB+PdJ96HGAU4GJV4eAW2dEQIsSaWFVfmHmKU4GBWEuFdJ9cZIcSb klhZlVqUH19UmpNafIhRmoNFSZzX7d6XMCGB9MSS1OzU1ILUIpgsEwenVAOjq6DW9ly7/3G3 9qfyRkpd3i7/sGGeywTzjBPlN9xmZFQH5G4PsL37PoqtZu2DTQ012X4HbOM23YiXb7ZbU/dC zsT1w3GzdH65eqfjchskImdMWzx/ljXHVk0T1TJ/pbnxBVNygoTKI75sspsar3uUbelEFk69 bwZXN6766J/osWrNj69nbuYqsRRnJBpqMRcVJwIAClC/5WgCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMJMWRmVeSWpSXmKPExsXCtZGTTXeSWWeEwRtui/2znjFZHPzZxmjx 9f90FouVq48yWbQufcvkwOqx+2YDm8f7fVfZPKatOc/ksfl0tcfnTXIBrFFcNimpOZllqUX6 dglcGT8m9rIW/Ber+LT9IFMDY7NwFyMnh4SAicSSB11MILaQwHpGiXn/TUFsNgEjiW/vZ7KA 2CICBhK/ey8wdjFycTALdDFKbDpzir2LkYNDWMBdon96JkgNi4CqxPMr29hBbF4Be4l9Z5vZ IObLS+xqu8gKYnMCxVvP/mSB2GUnsf5AK9MERu4FjAyrGMVyM3OKc9MzCwwN9YoT81Iyi7P1 kvNzNzFCgiFyB+PTieaHGJk4OKUaGB2+xnmem+q2s/PqK3GeOf2td+00D4kllycWHPexf7aN md9p3pHzvWZKGbUO1k7e2+X+rtqb8Oqv9Lanv2cL2+9ZvzqGd15N7O3nmm5aU3ZOk37sETiB 2+PO5ivib32MDbRr9E7bZIa+0/ml0nzk/MpbPStiE3PfuZ97a2VeEmEStFygZpmxgxJLcUai oRZzUXEiAPR5vkq2AQAA MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:63.163.107.21; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39410400002)(39850400002)(39860400002)(39840400002)(39450400003)(2980300002)(438002)(189002)(199003)(68736007)(189998001)(50466002)(2950100002)(2906002)(50986999)(6200100001)(6666003)(76176999)(2270400002)(86362001)(575784001)(97736004)(53936002)(1076002)(47776003)(77096006)(7049001)(33646002)(626004)(69596002)(48376002)(4326007)(38730400001)(305945005)(50226002)(110136003)(8676002)(81166006)(106466001)(356003)(81156014)(6862003)(8936002)(5003940100001)(92566002)(1691005)(5660300001)(36756003)(54906002); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR02MB043; H:milsmgep15.sandisk.com; FPR:; SPF:Pass; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD016; 1:P1HNnAkRkYEhN/uuWUcTQ4V9kqqMEw1hK91odg5LaT70eimTjkJZILgVQhLHINiLGyUDBK1X9ceYdcplOh6FHu3r9++9DwGKsq/Uzhoa+AUYAMuIHty3mu4TjGey3QRrfo29YsGBWjQaqVCp00zktx1cZQDoY2LWzzvGmmkQlgVUnjAUyhzIKXf5PlJtGNvvRFOvg4qw6EUkCWOL1bpmqdHZ8WhE7lHzjROWQW61658ZmtLUJ3nVShe1AXykinOL5HG7lSSjx5qOBKiifq3+TFl9H8pCdkmVf/P2JpW2xhxNHZ+D9+BTm8Ap/YQZQeAdn0H6d4CQIa9bIanN1DeP8GFc32JTjCl/qUAJTEyzoL+agreA9pOtKHDde8pMVcDJJt3X8HaNBwEIKwjQ+h9zfwl1//Ks8xRuBNKlQtmFCNGpofMQTQQOU8bQWKDu8SwTW7XKB7ewLeHvx/wmaZ4X1E5mxC/Uu0HhCga25pAY1KgiucRQeB6N9miyUoIhhjml X-MS-Office365-Filtering-Correlation-Id: ba7fae92-b542-436a-1d7c-08d4457b0c3a X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(8251501002); SRVR:BY2PR02MB043; X-Microsoft-Exchange-Diagnostics: 1; BY2PR02MB043; 3:/JUod0NHqu0vCPrLWJX8RGQcZCZPMteOXCxMTvPTIWxr3xOkeo3ecxu8GT1/vE/WAM+GnC/hvVbb2MJiPJy9JN6+oErr5rld51JlsFz/Wxr5OVsNcXEVzkSEUTV6HQ1OsN/b17VeP06SA8K+hiql+nzuCvi8BId6Jgi+aNcL0D9y0Izry+rYCz/V9rvSft7acqCT/z4FCYIdeP15JyfjjtvJPcqc8uTXdQ+5KbBMlfrc1YYdFxoGW8rz+LZUSogXp4VFCCuFYUMM/mcAJhyfJyl9hx/97jUOAhder6pkVvync0kECcR5FOkBbUh+VLN8a557ULps3opk7HgUq1DitixSUysTXdGoRxzBsyE6C3IEN2dTye7j9pOmm4XKRFUUfaZ+iYENFomhU0meE3s7qg==; 25:1XEiE5+0m5HGRQ3BjGLTpRy/dWfpFk/UP4q27O01FzFFcJQWqinnIhTvDbfWjfZe7UzGH1tm3ZKQNThUoONvcyp2MOXqOHlNT8kvn+C7E9QSRW/pct0DhLCH0Sh/r7R/uvc93x2TJuW77Oq2/uP8SWM1imOYDZGEvULQI+3fE3KAxPMZnvF989RiimM60U2xxEbT7PacycvWopjNuq2VLZ270LiYXBiFJP5g/G7RVxdAu3tR6RWyKbSjSDbaZ4gfAE9uJ7mXRVpQlcxVB8r2K3CNHJEYyQA3X6IgFuVEkI3UGWgSCqSEeJdU1LG1BJmKCyHr/IOP216zr9HomrLe31FwPncTI9KZyDqL+pOr0WUANF69ZQJBUeFrQd1/DM1TkX3rocAyvgkVdYzhHSQ60m6wijm2MtzonhcJo8wZfRjfW0s8czHdTv4Qk/fLCs0tUOIrLh/+Rbjhe6iZH8VO1g== X-Microsoft-Exchange-Diagnostics: 1; BY2PR02MB043; 31:MH2gIutyJuwRuuZWo5Fe9++GY9d5YxKpzACXz1WIEBEqL4wlka6iL3H0DXsauNv4FyQEYJcktRK7rfJkkpD5+4h/R1tmUd5Q9rDIb/HCoh6OBoIwoLC0m9tPniw25jbEBoUrvWsusILV/enhgkzHUdgrYUSN1NnbTwEvws/2IW03E9/Jyf9hzDyDvNklMmdCFMZBaUKTsimvxUapIPW6dVIZf5xNb2OTtsbOI1GEpSajyP3RDo2DKbnYQEpk+2kwkq7yOCtAyLxKC4r8rUrykQ==; 20:Uie9C1EibrME8AE1Be2Ff9rYB9RihtOW8xT27FxP2YgiKwbENn/1G5JUwWUEa8zvId2IKdJGOemuFwkuDDM+1ZMoNFPGmQ0DVEVepXe5xIRVTNKEDQjs+e5e3vPBxV90+RlXgTuWyx3ypJcj/e1ickJpKAu/46EEto4Nar1tZ1GT7OMfON4UMjQ/S1DGnH4erQC9lYJ3OhJ3IenCeGeyJHyeh8aUTTRATHy+p9qUtiXj0qbNpB4qMEdJeag5zT7eogUUeaE8J3VecTnGJmIkjDpn2t981tyuSpV7S2VYFaNYjtN/h4CGKGKNjKPTFlK8qbMlBVhf9y2bjMSOnjFOSo4Hh1iG/Zb7PW8ffTWE+16B84TiqzatB9DQbBzOpYiSzC4OVLuuD/HsUimhFu3Qvkh4z4n3yYeiX855/W/3dUA/uWu7dajApYh2aBGKxrdV8zLISMWvQ4MDVX/FR2liJyKcKAEymcrejk4iZo+AsixlmldvtV2uN0fhh5y0P/78 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(42932892334569); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(13016025)(13018025)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(20161123560025)(20161123562025)(20161123555025)(20161123564025)(6072148); SRVR:BY2PR02MB043; BCL:0; PCL:0; RULEID:; SRVR:BY2PR02MB043; X-Microsoft-Exchange-Diagnostics: 1; BY2PR02MB043; 4:UrnkHdkgqHSmgWLV96xOH2QPWyz4/zrd+xqcV/txgVbD4RqLrbRRk37fMbW5wnzl0dyfFA1y5i/IIHHb1nrBH1AfJA3gkJou1S5xVByimXVcaM2GfkD70EjdEI4LSdTg8OSj39kpBnyUUNqU4z9RK6XGEe5i/Pe/seqEIBC6B51nFtDwLIbVci1wpu2Es2zPTlmJvvggXBuXywLtKqEAxpmzhBrRKX+MtEyYLzlIKysdHd/Xg7Spq89DSdJA0Lviz43P24RxLvJ51s+Z9KN4kXxMnwzsoa5P0uHuJ9PPxQ3gXjGJZ6ZooNLJfRs4uZSGKfbnHGM5HTB+fjRtVKAfTxWV8J1jQ98LIO5MWBPRgd4FMtm36sgGUr+whis9mesBTEei2yxftXN+6A6VDq/RuHL1ItA5f0QbiyDqLkTK6hHQ1x+Xj7tVXoDTufewahlIxzSlGYSumSFxj7YwjQMHMPZA5EDVj1UPzULpTwaGt0g16dejaACNvBJttDLr26AbzMwXHp5sKxaJJc6darM06n2BVygVfnjKw1KpSc1dnn+ipU5WgnD99XLWOoLxHnCF4KDXZUuR4NhCluNhPLIjPNfFQYzSaJAZ4sYImYC0XKdq/zDnuZsqH8hcIwuP+TYRw484XKMxtR2b5m8Nxtn0cVNryn5ydxq5Pcc7IFGfdeM= X-Forefront-PRVS: 01986AE76B X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY2PR02MB043; 23:gBUaHXK90qOUSKrHmiADKsOpPsuWJcL6dRfHvAuiet?= =?us-ascii?Q?BHpDDYJ3WZpNzJ8rJVIJQvfcBGQNq6E+pRKFGcARSmklrs4XQcMiSksWl/NJ?= =?us-ascii?Q?smmYKPLNMtqalnLo8iB4kGlbewQ0c8buaAtcObBdajMKJQk4OWzIau8EkY+O?= =?us-ascii?Q?6zL+o5+eQdCXwD9gxaK6P3Mel2II857T/gpmxgsr2uDoqLJ8fTijQFJaruUt?= =?us-ascii?Q?5gZaz3fN8oqVHzHQS93QO735rwAyEa34OeIdbHcXOYYv+LEdJWsObjU14ENg?= =?us-ascii?Q?SKApGA3u5SsK+Hbl+q+WaW+2b9YX9jrQvs/T1mCgYWb/6/qY4me+66Lmp8Q6?= =?us-ascii?Q?7XnXeho/P1KM/VWLKvoMgC4KzJj4scfI6iiXaSQ5+LVukviYmEDjOtnsYdg1?= =?us-ascii?Q?fxL5qOWertqCDob22zT+SLx2ixIMKWan8Q8fhWLw/SrQXsteNAMUF+adlvHO?= =?us-ascii?Q?MdLxi9vbvJCHnL1Z+z9jsrH0PBYz/45FOlQv8/y3ir8VSzMZJQLfSOLGvQ8k?= =?us-ascii?Q?TtBHq4zjS9GSyWWY5XDgYdERDVFnJiIa1TuD4Q5bJyShgjultIkgaIdbVlkS?= =?us-ascii?Q?5tPlPjqOgrAlA/LKG3SkcxshpqfkTmKGndXI6MzC+qKa+DALYxQBYukfTlAb?= =?us-ascii?Q?fvSzrkNhflvZ7X0AgexCYCN4wEkp7guln/J1LIUJgx6kc4xXWIQdZKz2meah?= =?us-ascii?Q?BH7QRP/zTauD7vvYgY3WS1ZIx8Tjy+3TouO00O15C9qbMoU4V5hEHTN1PLvf?= =?us-ascii?Q?rvaZye0Q21Blieh58SzFqZT7QfcT7uFqX0kH+ekcY54OwIL7hUbPzxxOs9/u?= =?us-ascii?Q?yJUKIgHQdoCG8D5eucE5Ko6Z2cPl9mbdWykb0C4k8KoXCfdmUOgo85KRDKxt?= =?us-ascii?Q?FYCYmiDRPl5TvGtokfLm/skarzn66+dK9fibpJ3hzinHIarWvzX0XjK3SL04?= =?us-ascii?Q?8t9w0XXjX0YDty7pUiVddLbPDOXTb+Xqa5ipYXebDnI/n8SNaaVoZ0CxYCfs?= =?us-ascii?Q?UMnMmiqUN2/549RuZYXi54lv8Oz/gLm65y9xMdUamcb0mV38SixbdswBkzIT?= =?us-ascii?Q?kSr4PpS5kh6l0mKkD4ZSdV8uxJKbIv+192M1IcAfDwyiYRrOkhYgPs14K4UJ?= =?us-ascii?Q?RmfHHAAafhm/yLGp9Tk6vLZ3ls4rlQ42VIK+lXK2XIFXYUJUFhaVoLO7tYme?= =?us-ascii?Q?aZSxwI6zW6V7nepK6mkAT9T1tXztSs8FnSWBIjnQiJL2ftZ0z9tcfxTYK6J0?= =?us-ascii?Q?S3uTSG6bxEnhmDSfc=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR02MB043; 6:u/UGHePxQFFTEHrUGThb18yqmWhm7FwQjFuO+vsL4BDCgeEteifASAufc58r51LO9oMgh+MtUTMgAyCrI2IYUr2hC9CX/2K27NFRn0U6CzurrBI311ozphL3q0/y7Y3gsogkPX4tyI/ZsghKFyFGoMYh0rdLjZzhlEtuZ5ODdlbRyVeQAn7wfqR6y5u8ZKprhk7iIw7uZXc69wOVIity10mjvDqAPjbuyL+mCLNmQFxYaq1U7A7e0fXtp6XxOzlhIjWEPg0gqnow5Y+bmkWa+YbZHOdfqHrNf3wN6Jm4dJyXMTZ0kvOW5yYl1ET/xch3G8Y7jHEqyq6r1O/oAI1nVBVFHmCf0nAdihuJLDlVw2oeycyljII6JSNXG0va2el8zmA2JfgWQhbCtkV+XjPiyKeP7v9bUdRATMXIVUG7s56TjD6NTc4MqovRmtIlkHvA9JPX4saMloasjf7aZQATQA==; 5:Qj+AGRCMUCzn2QO+yj5iEHTYYkCCH6CzM8RDQyEdaIjk9xIhyNRjt1w5CS3b/aZ2gmZvZ1FlhRXAiG7tj7EZppCTOeX60yKjwSAGJdYC+vlBqT8r6lBL91vd1DzzfdQmC1EX7frE75vCaWlpr7woHA==; 24:wMEI96GTtby/53HMgMRlXKmtpimgcVAXQfs65Bb2GhnKjY+whu3BbDFXiFYJmsu6Qe/wpyP4RfEQy3/btneM+NTjkl9mZhLTqWfTsjQOt8E= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY2PR02MB043; 7:DA1GcuhD5vRm5k25PP/5bNbFa0oFHAZ7NNLi4ryElITfLLrPNv/beR3I2NeeVWlvPrqqPsFZ2HcfdTzwzN4YgbkB1xZWeCVPTEXr3JMB/4w3Ny3Pv4sE8s1sPM0Fr4ilaKmZCelkrD/TRWzwBfCXBEO4O/gMoUmxJPBCSfA7bZ8SR6QCopy3XB0xQ9OlSiTpRbR6xjmAyJM3xPTL3BXPsezo79bINm+ClQvv4xrKhfb1mVvrnx/M5r4jf95hUAUlf3O8j/F6BfdET0QB8Rjg1tUEw3lciYCMmzPMhnT/W/WnI2PUBaYChIMSZmm+r7rVHUyzvhd3v81kiG8jkyBOP9C1lC/msDRPkiwE9JeJKK5+5MWQLyUeiodskJFJqZypK3T5Jq4wrRnpeeQK0Th+ixZnY9LLrxc5jby4ETAhS/oloT+qwmGZkvAKaXJdUAmITFu/HJB2frry5eutFra+RA== X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2017 23:36:54.9987 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d; Ip=[63.163.107.21]; Helo=[milsmgep15.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR02MB043 Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Whether or not a session is being torn down does not affect whether or not SCSI commands are in the task set. Hence remove the "tearing down" checks from the TMF code. The CMD_T_FABRIC_STOP test is left out because it overlaps with the CMD_T_COMPLETE and kref tests. The TRANSPORT_ISTATE_PROCESSING check is left out because it is now safe to wait for a command that is in that state. Signed-off-by: Bart Van Assche Cc: Christoph Hellwig Cc: Andy Grover Cc: David Disseldorp Reviewed-by: Hannes Reinecke --- drivers/target/target_core_tmr.c | 30 ++++++------------------------ 1 file changed, 6 insertions(+), 24 deletions(-) diff --git a/drivers/target/target_core_tmr.c b/drivers/target/target_core_tmr.c index 95f8e7d0cf46..75527c83a860 100644 --- a/drivers/target/target_core_tmr.c +++ b/drivers/target/target_core_tmr.c @@ -98,9 +98,8 @@ static bool __target_check_io_state(struct se_cmd *se_cmd, assert_spin_locked(&sess->sess_cmd_lock); WARN_ON_ONCE(!irqs_disabled()); /* - * If command already reached CMD_T_COMPLETE state within - * target_complete_cmd() or CMD_T_FABRIC_STOP due to shutdown, - * this se_cmd has been passed to fabric driver and will + * If a command has already reached the CMD_T_COMPLETE state, + * it has already been passed to the fabric driver and will * not be aborted. * * Otherwise, obtain a local se_cmd->cmd_kref now for TMR @@ -108,15 +107,9 @@ static bool __target_check_io_state(struct se_cmd *se_cmd, * long as se_cmd->cmd_kref is still active unless zero. */ spin_lock(&se_cmd->t_state_lock); - if (se_cmd->transport_state & (CMD_T_COMPLETE | CMD_T_FABRIC_STOP)) { - pr_debug("Attempted to abort io tag: %llu already complete or" - " fabric stop, skipping\n", se_cmd->tag); - spin_unlock(&se_cmd->t_state_lock); - return false; - } - if (sess->sess_tearing_down) { - pr_debug("Attempted to abort io tag: %llu already shutdown," - " skipping\n", se_cmd->tag); + if (se_cmd->transport_state & CMD_T_COMPLETE) { + pr_debug("Response for command with tag %llu is being sent to initiator, skipping\n", + se_cmd->tag); spin_unlock(&se_cmd->t_state_lock); return false; } @@ -236,18 +229,7 @@ static void core_tmr_drain_tmr_list( spin_lock(&sess->sess_cmd_lock); spin_lock(&cmd->t_state_lock); - if (!(cmd->transport_state & CMD_T_ACTIVE) || - (cmd->transport_state & CMD_T_FABRIC_STOP)) { - spin_unlock(&cmd->t_state_lock); - spin_unlock(&sess->sess_cmd_lock); - continue; - } - if (cmd->t_state == TRANSPORT_ISTATE_PROCESSING) { - spin_unlock(&cmd->t_state_lock); - spin_unlock(&sess->sess_cmd_lock); - continue; - } - if (sess->sess_tearing_down) { + if (!(cmd->transport_state & CMD_T_ACTIVE)) { spin_unlock(&cmd->t_state_lock); spin_unlock(&sess->sess_cmd_lock); continue;