From patchwork Tue Feb 7 23:02:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 9561379 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 50EC360547 for ; Tue, 7 Feb 2017 23:06:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 47D7528475 for ; Tue, 7 Feb 2017 23:06:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3C58C28488; Tue, 7 Feb 2017 23:06:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8393B2848E for ; Tue, 7 Feb 2017 23:06:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755652AbdBGXGG (ORCPT ); Tue, 7 Feb 2017 18:06:06 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35136 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751906AbdBGXFa (ORCPT ); Tue, 7 Feb 2017 18:05:30 -0500 Received: by mail-wm0-f68.google.com with SMTP id u63so30970806wmu.2; Tue, 07 Feb 2017 15:04:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=v2DT88GYZmkkNL1RIA734rORBYb38no/svhgaIiaxho=; b=uA7Vn0rxOZe2kg4HWjQH2AP1wi8VgNFDa4tvxNtcIsk2D/mt8wfxvUgG0RThWgzqnZ p1He4xh6E/rifAsc92YJ3+NIw3o4Om2eZAF/87LPscS9pmdolnvpT8sMITJeX4ga8YJr ITGbZLexmHf8IrVV8xeo8wFh//50aodQpPUS0GGOjqqTmyuxyvT5MO1RHnzMSbHxY71N QfZ7Pry/Q3BiorXN+DUj3/ToiCNcb+2b3jvMbqm8OKXJ2P2DJQxygbPAXbnkSJ1P0k2c HRUVEtiLkozhGL2FD6SqVDfqsldnd1xhJXTiIHq4vj+HD+o2gKAJxhXZxZUmm/T/SgkJ 2TWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=v2DT88GYZmkkNL1RIA734rORBYb38no/svhgaIiaxho=; b=IERGmeolF94YiXKHixpn3ryhz3GYNR/PJH5QsvFyfRHQ7tmw+y+wbyY7m5cqncNVNT /ezwycqpyzwTa0EhyRX6JNq+7VqEObx+ZlJ5r4BH52kF6Pcmu29OGA3RLxMZbjk+74U+ 24MHNVA+p4kXc4G4sz09kfnRVUdk13SMkBh9DylJ98vGxzqtuuZuiR9X+axH2cWmHr3X eUFqddN8m1MFyn9py7u3lxcRTupy0hOM1AgMqFE1Ypa74/HF1p1Ns0UrOJK6VLyccNrU IOMlcZqUQ52GmpaP/vnzgbsDdXDDIFpLd6wunsoaBCBS2s8jYTbVOBhGBD6hJIOy/9m/ AC8w== X-Gm-Message-State: AIkVDXLfDLqin89o8ZhKbTG/AT74IM7RGMFrKj2XZ9zxVlcGfpIkQ4xBK3iJ+xUNt5It+Q== X-Received: by 10.223.172.17 with SMTP id v17mr16142837wrc.115.1486508670051; Tue, 07 Feb 2017 15:04:30 -0800 (PST) Received: from fainelli-desktop.irv.broadcom.com ([192.19.255.250]) by smtp.gmail.com with ESMTPSA id b15sm9742283wra.4.2017.02.07.15.04.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Feb 2017 15:04:29 -0800 (PST) From: Florian Fainelli To: netdev@vger.kernel.org, linux-mips@linux-mips.org, linux-nfs@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, target-devel@vger.kernel.org Cc: Russell King , Andrew Lunn , Anna Schumaker , "David S. Miller" , Derek Chickles , Felix Manlunas , Florian Fainelli , "J. Bruce Fields" , Jeff Layton , Jiri Slaby , Kalle Valo , "Luis R. Rodriguez" , Madalin Bucur , Microchip Linux Driver Support , "Nicholas A. Bellinger" , Nick Kossifidis , Nicolas Ferre , Raghu Vatsavayi , Ralf Baechle , Satanand Burla , Thomas Petazzoni , Timur Tabi , Trond Myklebust , Vivien Didelot , Woojung Huh Subject: [PATCH net-next v2 05/12] net: bgmac: fix build errors when linux/phy*.h is removed from net/dsa.h Date: Tue, 7 Feb 2017 15:02:58 -0800 Message-Id: <20170207230305.18222-6-f.fainelli@gmail.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170207230305.18222-1-f.fainelli@gmail.com> References: <20170207230305.18222-1-f.fainelli@gmail.com> MIME-Version: 1.0 Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Russell King drivers/net/ethernet/broadcom/bgmac.c:1015:17: error: dereferencing pointer to incomplete type 'struct mii_bus' drivers/net/ethernet/broadcom/bgmac.c:1185:2: error: implicit declaration of function 'phy_start' [-Werror=implicit-function-declaration] drivers/net/ethernet/broadcom/bgmac.c:1198:2: error: implicit declaration of function 'phy_stop' [-Werror=implicit-function-declaration] drivers/net/ethernet/broadcom/bgmac.c:1239:9: error: implicit declaration of function 'phy_mii_ioctl' [-Werror=implicit-function-declaration] drivers/net/ethernet/broadcom/bgmac.c:1389:28: error: 'phy_ethtool_get_link_ksettings' undeclared here (not in a function) drivers/net/ethernet/broadcom/bgmac.c:1390:28: error: 'phy_ethtool_set_link_ksettings' undeclared here (not in a function) drivers/net/ethernet/broadcom/bgmac.c:1403:13: error: dereferencing pointer to incomplete type 'struct phy_device' drivers/net/ethernet/broadcom/bgmac.c:1417:3: error: implicit declaration of function 'phy_print_status' [-Werror=implicit-function-declaration] drivers/net/ethernet/broadcom/bgmac.c:1424:26: error: storage size of 'fphy_status' isn't known drivers/net/ethernet/broadcom/bgmac.c:1424:9: error: variable 'fphy_status' has initializer but incomplete type drivers/net/ethernet/broadcom/bgmac.c:1425:11: warning: excess elements in struct initializer drivers/net/ethernet/broadcom/bgmac.c:1425:3: error: unknown field 'link' specified in initializer drivers/net/ethernet/broadcom/bgmac.c:1426:12: note: in expansion of macro 'SPEED_1000' drivers/net/ethernet/broadcom/bgmac.c:1426:3: error: unknown field 'speed' specified in initializer drivers/net/ethernet/broadcom/bgmac.c:1427:13: note: in expansion of macro 'DUPLEX_FULL' drivers/net/ethernet/broadcom/bgmac.c:1427:3: error: unknown field 'duplex' specified in initializer drivers/net/ethernet/broadcom/bgmac.c:1432:12: error: implicit declaration of function 'fixed_phy_register' [-Werror=implicit-function-declaration] drivers/net/ethernet/broadcom/bgmac.c:1432:31: error: 'PHY_POLL' undeclared (first use in this function) drivers/net/ethernet/broadcom/bgmac.c:1438:8: error: implicit declaration of function 'phy_connect_direct' [-Werror=implicit-function-declaration] drivers/net/ethernet/broadcom/bgmac.c:1439:6: error: 'PHY_INTERFACE_MODE_MII' undeclared (first use in this function) drivers/net/ethernet/broadcom/bgmac.c:1521:2: error: implicit declaration of function 'phy_disconnect' [-Werror=implicit-function-declaration] drivers/net/ethernet/broadcom/bgmac.c:1541:15: error: expected declaration specifiers or '...' before string constant Add linux/phy.h to bgmac.c Signed-off-by: Russell King Acked-by: Rafał Miłecki --- drivers/net/ethernet/broadcom/bgmac.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c index fe88126b1e0c..20fe2520da42 100644 --- a/drivers/net/ethernet/broadcom/bgmac.c +++ b/drivers/net/ethernet/broadcom/bgmac.c @@ -12,6 +12,8 @@ #include #include #include +#include +#include #include "bgmac.h" static bool bgmac_wait_value(struct bgmac *bgmac, u16 reg, u32 mask,