From patchwork Wed May 3 20:50:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Butterfield X-Patchwork-Id: 9710415 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6CB166021C for ; Wed, 3 May 2017 20:50:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5FA4028692 for ; Wed, 3 May 2017 20:50:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5450F2868F; Wed, 3 May 2017 20:50:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E6DB52868E for ; Wed, 3 May 2017 20:50:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757531AbdECUul (ORCPT ); Wed, 3 May 2017 16:50:41 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:36618 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754354AbdECUul (ORCPT ); Wed, 3 May 2017 16:50:41 -0400 Received: by mail-it0-f66.google.com with SMTP id x188so183594itb.3 for ; Wed, 03 May 2017 13:50:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vKF6zwFmFZ1sWuliwm6ZWBVJ2Fxp0PT2fO39Z7v1uXA=; b=jD/Om7dLzHL/+LYa3vkPvH7fWYzpC3lYw0t0rKDy3wpus2SLrWGR7J4tpDMkLlty3Z 4FdohwaAQ9xh8f60krxUCkw+xc2Mw+lZ6Xetfn3seZmRkNMzxx+hMBcX9NSVj2Xtedln BCvSEHhyCcyYdms35v2HvW+XSyaTI0KOW/7rnpBA3BIW384DzXpE0xAd69G/By1peBLr HzlJkjf1IQlPqzfirxo7m8AyhErfO5o5UZFE1rV8rxvvCBNPDvHFw2uf2th+I4L/Ier7 gFPBtDkARH65sIcyWvf98dzCWA+Y+F88D3UcL37K3sjGc387tZsGTsFvm8WO5ljgFwmG 1/nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vKF6zwFmFZ1sWuliwm6ZWBVJ2Fxp0PT2fO39Z7v1uXA=; b=VLXx8mn/MUiPfpSeaeyVAlm47aVDBvVuKmMPvK9umvXGsMTrAYpv05xz35B196OWyr Dp6S2nbvq7CC2nLhaKAlyVlbdd0s3VHc3XLZFu/JvltJB4tz1xyJeEF2IexjW2v2kRDG xmKlf7/SpDP07RoRbjC7JbnxEMosovRYR8NyHrBiRlJRhlueD8qeBZHFn1jLqxWQrhwn /OJIiqxm8x9tH+0jCXVNSD7sL5VZIrh8wWckL4mD7z2me0FfLBGv7pzasBRhnri4IJRG R3+u1UIOEiAlMVJmGIYyEHbOsOPoMv5u5ElCEYBj0NxOFf7tPV70zDBk6EqAsEibf3E5 dEGg== X-Gm-Message-State: AN3rC/7qgVXzfuvsfUpOqmx+t6TONx0fSnCcBCQHDUW8LpFf5S/HVjWj Gy4w5NaCm2/sHQ== X-Received: by 10.36.17.201 with SMTP id 192mr10041041itf.76.1493844640274; Wed, 03 May 2017 13:50:40 -0700 (PDT) Received: from localhost.localdomain (c-73-181-28-74.hsd1.co.comcast.net. [73.181.28.74]) by smtp.gmail.com with ESMTPSA id z26sm61277ita.8.2017.05.03.13.50.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 03 May 2017 13:50:39 -0700 (PDT) From: David Butterfield To: target-devel@vger.kernel.org Cc: David Butterfield Subject: [PATCH] tcmu_rbd_open 'size' is expected to be signed Date: Wed, 3 May 2017 14:50:06 -0600 Message-Id: <20170503205007.21976-2-dab21774@gmail.com> X-Mailer: git-send-email 2.12.2.575.gb14f27f In-Reply-To: <20170503205007.21976-1-dab21774@gmail.com> References: <20170503205007.21976-1-dab21774@gmail.com> Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP tcmu_rbd_open 'size' is expected to be signed, as evidenced by the check "if (size < 0)" later in the function. Signed-off-by: David Butterfield --- rbd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/rbd.c b/rbd.c index efd001f..ed50aa5 100644 --- a/rbd.c +++ b/rbd.c @@ -384,7 +384,8 @@ static int tcmu_rbd_open(struct tcmu_device *dev) char *pool, *name; char *config; struct tcmu_rbd_state *state; - uint64_t size, rbd_size; + uint64_t rbd_size; + ssize_t size; int ret, block_size; state = calloc(1, sizeof(*state));