From patchwork Thu May 4 22:50:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 9712897 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 58D8E60387 for ; Thu, 4 May 2017 22:51:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4AE9D28639 for ; Thu, 4 May 2017 22:51:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3FBAA286A9; Thu, 4 May 2017 22:51:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9378228639 for ; Thu, 4 May 2017 22:51:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753147AbdEDWvy (ORCPT ); Thu, 4 May 2017 18:51:54 -0400 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:58228 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752751AbdEDWvO (ORCPT ); Thu, 4 May 2017 18:51:14 -0400 X-IronPort-AV: E=Sophos;i="5.38,289,1491235200"; d="scan'208";a="16214495" Received: from mail-bl2nam02lp0083.outbound.protection.outlook.com (HELO NAM02-BL2-obe.outbound.protection.outlook.com) ([207.46.163.83]) by ob1.hgst.iphmx.com with ESMTP; 05 May 2017 06:51:13 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=bOWpSv5QrAlgW6S3uxJWmqSnKsafvkHOmGZ2RRcibQk=; b=gMsKgFX18M77EtNMg74uErVAciI1cJitNLkftJ+bPCe2sYrKV/BcJYxMU1XKKYbEZw14gfKuKEjF8f6esYJugdDYcGCsxGqAta80UQiizvyMSHLm59t2N98VpXVLsNaO0a7yUunwnpJ6JPQOo2mgNuBpA1NKz0VELm0/f+JXeBs= Received: from BN3PR04CA0036.namprd04.prod.outlook.com (10.166.70.174) by CY1PR0401MB1209.namprd04.prod.outlook.com (10.160.165.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1061.12; Thu, 4 May 2017 22:51:11 +0000 Received: from BN3NAM04FT057.eop-NAM04.prod.protection.outlook.com (2a01:111:f400:7e4e::207) by BN3PR04CA0036.outlook.office365.com (2a01:111:e400:7a4f::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1075.11 via Frontend Transport; Thu, 4 May 2017 22:51:10 +0000 Authentication-Results: spf=pass (sender IP is 63.163.107.21) smtp.mailfrom=sandisk.com; suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=bestguesspass action=none header.from=sandisk.com; Received-SPF: Pass (protection.outlook.com: domain of sandisk.com designates 63.163.107.21 as permitted sender) receiver=protection.outlook.com; client-ip=63.163.107.21; helo=milsmgep15.sandisk.com; Received: from milsmgep15.sandisk.com (63.163.107.21) by BN3NAM04FT057.mail.protection.outlook.com (10.152.93.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.1047.9 via Frontend Transport; Thu, 4 May 2017 22:51:10 +0000 Received: from MILHUBIP03.sdcorp.global.sandisk.com (Unknown_Domain [10.201.67.162]) (using TLS with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by (Symantec Messaging Gateway) with SMTP id CC.D4.29323.C50BB095; Thu, 4 May 2017 15:51:08 -0700 (PDT) Received: from milsmgip11.sandisk.com (10.177.8.100) by MILHUBIP03.sdcorp.global.sandisk.com (10.177.9.96) with Microsoft SMTP Server id 14.3.319.2; Thu, 4 May 2017 15:51:04 -0700 X-AuditID: 0ac94369-548749800000728b-04-590bb05c4fda Received: from exp-402881.sdcorp.global.sandisk.com ( [10.177.8.100]) by (Symantec Messaging Gateway) with SMTP id E7.F0.11415.850BB095; Thu, 4 May 2017 15:51:04 -0700 (PDT) From: Bart Van Assche To: Nicholas Bellinger CC: , Bart Van Assche , Hannes Reinecke , "Christoph Hellwig" , Andy Grover , David Disseldorp Subject: [PATCH 14/19] target/iscsi: Remove second argument of __iscsit_free_cmd() Date: Thu, 4 May 2017 15:50:57 -0700 Message-ID: <20170504225102.8931-15-bart.vanassche@sandisk.com> X-Mailer: git-send-email 2.12.2 In-Reply-To: <20170504225102.8931-1-bart.vanassche@sandisk.com> References: <20170504225102.8931-1-bart.vanassche@sandisk.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrFLMWRmVeSWpSXmKPExsXCddJ5kW7MBu5Ig60rtCz2z3rGZPH1/3QW iwVv9rJZrFx9lMmibfUZRovWpW+ZHNg87m8/wuSx+2YDm8f7fVfZPNZvucrisfl0tcfnTXIB bFFcNimpOZllqUX6dglcGU+m7WYuWKJRMf3sNrYGxveKXYycHBICJhJ/N91h6WLk4hASWMok sfnEMlYIZzujxNKji5hgqtZv+wyV2Mwo8Wf5KhaQBJuAkcS39zPBbBEBHYlZd1+wgxQxC9xm lFjzeDUbSEJYIEji4Z0jQEUcHCwCKhLvLjiAhHkF7CUmrvsFtUBe4uyWncwgNidQfO+M+2Bx IQE7iTX9mxlBZkoILGKVWPT5FwtEs6DEyZlPwGxmAQmJgy9eMEM0qEucXDKfaQKj0CwkZbOQ lC1gZFrFKJabmVOcm55aYGiqV5yYl5JZnK2XnJ+7iRESA5k7GO8+8T7EKMDBqMTDu8CNO1KI NbGsuDL3EKMEB7OSCG/ECqAQb0piZVVqUX58UWlOavEhRmkOFiVx3nMyUyOEBNITS1KzU1ML UotgskwcnFINjIYvQtUYr/nIn9fs/ixY0trt/Syz/ruLwVrDFZ/nfcuPXahwT+NuwabTveyV L2uVG/WXXdx1Y940zr9pq077NF20tNm5JyXI+5dimPCqSzuWKMwq/i+YUWGevO8Nx/1TbbE/ s0NNH5QaV0RdKW55+c5dslp3q99en5CEY69ORi0xNd95YLNZixJLcUaioRZzUXEiALoicMh9 AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrJJMWRmVeSWpSXmKPExsXCtZEjRTdiA3ekweFb5hb7Zz1jsjj4s43R 4uv/6SwWC97sZbNYufook0Xb6jOMFq1L3zI5sHvc336EyWP3zQY2j/f7rrJ5TFtznslj/Zar LB6bT1d7fN4kF8AexWWTkpqTWZZapG+XwJXxZNpu5oIlGhXTz25ja2B8r9jFyMkhIWAisX7b Z1YQW0hgI6PEhG0cIDabgJHEt/czWUBsEQEdiVl3X7B3MXJxMAvcZZQ40/2JDSQhLBAk8fDO EbAiFgFViQntZ5hAbF4Be4n5t66yQiyQlzi7ZScziM0JFN874z4TxDI7iTX9mxknMHIvYGRY xSiWm5lTnJueWWBoqFecmJeSWZytl5yfu4kRHDickTsYn040P8TIxMEp1cDYMYnx+Nz3gmLO /QfO5ux/F7TIxfr9qtvHXunKGgRN8pu4VVrlNwPjf8s/oXtdsost07Qql6muE9KwWzd1clK0 ec6xGrXH9fvM1Bib9PfPKfh4Raz9VNNeB07OQL3ndw/N59lYvWLnLZMPrZerrytGbZtQHnb4 QeyREs/Y3/yiok+ClKrfdD1TYinOSDTUYi4qTgQACLj4NcwBAAA= MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:63.163.107.21; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10019020)(39410400002)(39840400002)(39850400002)(39400400002)(39860400002)(39450400003)(2980300002)(438002)(189002)(199003)(9170700003)(8676002)(6916009)(33646002)(36756003)(356003)(189998001)(305945005)(50986999)(5003940100001)(478600001)(110136004)(106466001)(5660300001)(8936002)(76176999)(50226002)(38730400002)(47776003)(81166006)(54906002)(48376002)(53936002)(77096006)(2950100002)(6666003)(2906002)(4326008)(575784001)(86362001)(50466002)(1076002); DIR:OUT; SFP:1102; SCL:1; SRVR:CY1PR0401MB1209; H:milsmgep15.sandisk.com; FPR:; SPF:Pass; MLV:sfv; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN3NAM04FT057; 1:OXzyxu0hy/JycaqlYvCELoQVF4cupYIseUfNs2ZADq0yWD07szjFJW0pHRf1+xaXjBPHqov4p6jMbHK5YntJPF3ts5WrCX7adfg1qcJSzQAWSktZWX3V/mRuPiN3CdlRkiAGwZ6BQMN12xKaJ5u50ZwP/LGo5xpc2zC77cYUEFd7AO3yG6aeLh9S+/iTWqdE1Lz9qio4vi8SY101phpyFH7vBdEx/uVyLulyS2BicYMcVNMH91zAU16HDsqiO8puxHnJMqCHNURhuuOJsjQFUintiRx0ypwUhqJ0WYy7NI9tLgJeTRKDYAnUefe/guEn59wywilUYk2dvYVXmnX711zHxCrjgjTI1VjOb1v8LnTfilYIVJmfucNDKYk7H+ou0MED65SAy8qDuCo2Ml0qFSJf9SxXRyD2STm4jRysjfh5GDdVxbOnO5UKFzIrC2ZNQL5S1xWnO+0ft7ti98k1Xyi4DvpINJl5RlbEIN87zM6JfTu2UDNBGWUzyhFX6ZGTqB2tq4rVceJru3/B4ur4jg1oiQ7akOc3KjZF9HT8gYM= X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 31cfed89-c357-447f-ada0-08d493400f0f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(8251501002)(2017030254075)(201703131423075)(201703031133081); SRVR:CY1PR0401MB1209; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0401MB1209; 3:MdZoI+yeVsiOlu3VynyLIRhNT+AyMC1D6fXE8Pxm84D1cAHevWGrRSb12+YbIW2ca9A6Vm6uSTAncPvyvUa/xSLrn+gbp41rUC/OZ9CfZwdIxp7KOFfKTF0XzWQnvkDf582W35BFbC40wT7yFbyrr4kd30UbocvQxuAufYS0yOGiHWUTITPPP6Dd+kfJCJqOg2fF4GgqpaZjVdW2NTZQ9lJgzpu8CuqWT7dE5cLn2GfkSCo3Jl+cQaW41hqY+agXRGWjKMAN1Cv1KgJaEfSqaw2PCP9VTMihZ0nLZUSMyRQbd8SAjRCxW1Roc2PoYxDxLY6+u4f2zYaQ84szGOtLcDsg2E89MUoQcEUgLpF0KAbTmMASYWFe3uzzU/Bon4yb12znUksS1jn44anT7sogFGkQ27J5KKyZpKxcZPXurpCT5lxO0trLeBPqTnghqnv8aMTIjpBlK/CpqwRvfFUus29bUTKWIGmLObdBwijZUshYq3hJlEZNWumomwU3qJjd X-Microsoft-Exchange-Diagnostics: 1; CY1PR0401MB1209; 25:BllVIVURgQvoAv+lVjwBobcClgiKS1eQW8Pth0C06EmwN8FxMTjOxHnivdcE7h784P2t+mLvgzmu/fJY1yvRaAi0kAL7tqbuA+48eI2bH5XYX2auweO3+3yCBW3PalAt/mDltNr+YdtCeI8VeTDEklG8m2tG4JahoicWbZJsIGfYM+mzafh352BdwYiRBhnsv0LFwq/td8GS7VsEp+M75YnWSGMbO0iU/+X0478N2iCV9jPXKkAKyoN25hsDLbo8QLQsliCuEZ2CTRFVekEmU4YgqffmVvdv/7OLuPyz7Aqfh7uOscXRccMg2ljoRbzxeMjGWbxF9NK+8q+htpPbTr7demBCV4hiib6xEH3ZmXRPyxpo5E1TZ2sHs/tTLzQufcr3RO83cK9Z9DJdkYBBEF0vgal3bwVFb5sv1iPmBIT1p6pX701aPLCsazn8r7HXFynXsCP7ira/iaWtW0fyRw==; 31:G6kVVeigx2+MKAhh9giWaXwY2xtR6Ratl6eVQtn1Pj1KZb54DMXq0fy+mOjflSkkWXckB44vhSRvzFSjJYjcY0bBYyZjwUzwXP0T4o82fmEnYReK6KcxqNE4kDqB6zPRlGArCIKG1wcailT8cvc2ReeicJwYOSwwf8gjL5WjjnI2KQTWaHoYSagOeBSvQRyNTbVcNQ/AJ15bLg5uRMvGLICp4Zr37RPW/P3LfaaulDeplvLrntYvRSbHu8/3xvcGR9Z0ZDO18taUtrJ1wbz1fw== WDCIPOUTBOUND: EOP-TRUE X-Microsoft-Exchange-Diagnostics: 1; CY1PR0401MB1209; 20:TErNzaaCcRQwWJ4nw+kt8wuCymdLM27sYXT6xw/4k63spNRMnXbqK8m6a1NPnLc/vP5RB/NFGeyTl3ChGFTFMPgOCplhvL6UHsdmEDnWq4EAN1yEhdlOOv9QkOExih3h3Nm7mN5zacRkdiH2MugcfB5tSsqc36cG9voqMAZgsaGRSMQzWeSc77CSwd+OwnHVHC7NHMvSvlETpneyp0OVk7fwKT6r97D9dYQnnMXZK0eDU2z7WdNhF/wInY88LW0+0309Uju1mXCEOl9EQfK9i4mC1Ew1GLX2q1OoN8RqTyx/vxpUwkQQ6rnMFVpBeG50S0jdfSgW4FRvjOmx6BO+P1GtEK1KzFIc4dpNAXkcl3MonJ4EguJQsoedY851KGBmtkm3TP6svpHg+YdWhsbyTAN1xJ5IhsHGLYDfzQB5U6XLPPm4BtMvq2/11s8GcPhukG1pTwcHIEh89BAJ7k/ydRf5KhMpucWhqEdGZQ1XJyUrxS0CihVJ8Zw4S5gewyAd X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(42932892334569); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(13016025)(5005006)(13018025)(10201501046)(3002001)(93006095)(93004095)(6055026)(6041248)(20161123562025)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(6072148); SRVR:CY1PR0401MB1209; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0401MB1209; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0401MB1209; 4:JbSb6S8UyY1J0U7AfkWteCG+qVO0ch7bRRZQfUvJWJaxBqhslQZsugDO4Rqlyfz9nYeRuRDtvgQnHAgO1ZhSZVr10qxJkCB+nL+z4CUcL1iNK2OwZBAimcf4KsrgMe+c/W6AQ5e+W8xOy1Ndys/fcAEHM8wfjLAqkfbaX2BoUZTtT1alNd3yX0PDJyd1zhBqSr/LIxjzy8WDx5SrF6eNKWSCe0REEj3QWbIFFpML/HQmFgARkelgdwFWZzNY9axTwNvBNZhtlRhN8VpCi90N4MXoJ1982CM47TBY4DioCCBQcO9lUg4EMFDNzPftWyV1UlDAYgPnJlVhq7FxmvonPKLuxKVKEPKDCXZ6k6LDw7EpvUIEWLx27xo0chK415PN87byLEmvMA3xnkbQzpLSfrVIhG1UjWvpVAv/bURREb0ShsUU4A0ozT/0oYMZqIjrOTC3GigHSUvI54qYL/ziSl+30QvyCi2fc/z0VtTCR1TWV6VVzTJxGBno8/AZAGE6rRRROvRH2sAwwzkKjd8XRwhUSxkhPIQ6oRTV6UvW4H7dLxe2DQdGENoVUzknJUSDow00x63tHN3FITNmZJixwZw5qzUx35p8MVBeji+zAbI0q5lEXGy+SXLTF+OnYFkb9StzTfmz1SAx/JyV2Va1eaB6RqONIYoQHsDh5frJSD9/f2MsBR43xBd3oxLjQAqPKZfqANXkS2io/k6XadMTN5H9GGl+8t3feDqUPff/baOw7PkO3+oZBnikx0Ll5j82YJMpsCa1K88X/4tsKLM0z+dFhW6OpAy7HSO/e76NgsKxWyIWHXoaVab0Z0O0r6DdaXsX7xXPHL/BMnxECh+quqs0hqxsD6vkpDojny/HQBlGZGsCKomZHnNFJapXhZ8e X-Forefront-PRVS: 02973C87BC X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0401MB1209; 23:JLQBxBMonI6tGAL48PFwKtyCsTfEjopYJ2lxfeG?= =?us-ascii?Q?WgfsfwyEuXoDtcOTUpxZZtfP+cn4nGAJKgH3eseQTZGKgvVIUEa3x7tN/O+h?= =?us-ascii?Q?+qxJ5BGcRfXpPA3ZS2WyAblCnh9w0yUGjNxNJs818Lr8/7WD1RT2RsPh500k?= =?us-ascii?Q?HcFkRVU8iPNwrU70DfrVP+0HiiVgQusbUgtdN9Vta66ITL/D0km0xX4VVe0e?= =?us-ascii?Q?Lg9MWFvi2+9OsIWqYE9l15YELlyj4KCQKOe/bflkZ1ikKO+E6W6nsk0JbigJ?= =?us-ascii?Q?CNl+nQ1lJJz3gHUs4ogohoA0LfGQtpaDFTsI50f9jgndy9+efs6vXAHdkSzX?= =?us-ascii?Q?haQxjav97SQ9N1YENXq28gXqd1Mull13ZL/I0V6aAlNZJCOd5DU72X+5uyIh?= =?us-ascii?Q?tj4gO/kTfIhHzGYWruICnHsCLRuDFCZWDS3XskApF6oXyTY9RZ+KHLwDihrl?= =?us-ascii?Q?ZnsyINSEozBK2R6CqBgBVTZlMATZDhcRoAG3zdxdnwjzArmsSbquvZm7Fxie?= =?us-ascii?Q?r1zflk2vZMqQEhAY/OJM17DDCkL4hHKbqMpmO6O7eR78pw76RGqfS2FmHyMQ?= =?us-ascii?Q?xO/XN78zFJgEOwUeKX16MGnOCLDpnYefjTvesYUC38e/YFWvmTcJ7/B2lRaO?= =?us-ascii?Q?238hkFcSb13p9PWGodi3QV5cKKN4KJb87nG0vx/NxJjOYyl8R8pY80JMa/2O?= =?us-ascii?Q?45zdjDBrqi3AA77bgH7P3gS5eNHUKiQeflMbl1huyVFhHHfBWSjyQAfqm42D?= =?us-ascii?Q?7tQ3QYnnnOw77uDLr0yTGpX+bpnm6nY3DCHMnhd/Hj79GqBDgQR8rrRyKwpU?= =?us-ascii?Q?isjVWFOLAMAWyRlZILkHeJeWbBAaQV8aUUvGesgkaxTAKIUtRNQmMtI2Oprx?= =?us-ascii?Q?dqoFgxwDMfExfZIl9BmYtLZYMEYfTwXNvhbLxnHR1E5+aj0RCy/19tzN4OGg?= =?us-ascii?Q?ar9r6kVYIIfRpNP7tuUjYkEM120tEqoQPSszjLJhsrNVQBdk/WQuZA2qfRHW?= =?us-ascii?Q?7ZVPOPw94sJU8cdSiHxLnH1Tv6E3YPURs4XpixKC5K+SjwnDuFtXBoPPQhcx?= =?us-ascii?Q?RxSfze+yN+wlxAR0J163r82aToQ6+?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0401MB1209; 6:7k6OmxVFDQrWcFpEar1nuy+ptK/CxUPjkqKWHfBZ0iJ8xhJdQ+86Kih0NpUOGkWcDZbDOrDiZ2JKJob94yqsnSS6liQp96k9gUwvPMSEwAbBWtpYuY2q89xaYRbc4Tkb0Wd4Qwc2XoGU+tYhBQ51HYlLzKzQh4KDXpGKL9P1UyDNgb1HITgbJ7MQu0j1hKx1F6L+e50wL8WVEoKip4/dr1b3e5H7E7azwwHudzIQbhv/0+8u23QiysgB9Mle+uZPhn3fAYuqSL51uZANR3QJXk1YBj1Tin09njDF5Fp5R3j+pZ+YSMpPdFeQfyh4LI0o2b9GUsb3empbb8ikSMhBPDHspxFy1KqLfCuAibSLDbvDhiUFq+liuWOpffSuDqB6TSUHxY4Xj/asbuibdQ66WKxRJwtRls8+cj/vRkLV2li40/z3FQHv0JRmVprAdJ6KpcSNjxzf7HXW19YH89YraXMLFOTIC6hKFpbUKfU0nEjYRHaZHHPAT4lQYt43tNAnF9GFImLriI3Ja8I/ThyQSA1Vw66pdb6ncMY1cVq8Iyo=; 5:vFBvmQcnKZr3ypEa39WBvrKG0sYOJ/3vKs05CDNwIzzj4r6QDMIV8iOZgX3me2sZA/c39HbWr96FctKGEnYgZ5bcZkwyfTG7t58V+oBxbUJzwXTjdD6eoP/hWXisY0jQwZOMz2InXrw0KEfQjGddnQ==; 24:s0l9qJXQYBIiOtD3oyGX1ZxT1wSn98gcsPJgRWTjKGXlUR0mvKJRu8Jm6AxLdvGdu3py7qDAlwA8Bv6hvv7MojZAXXlVVpz5TshZrEe9tWg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR0401MB1209; 7:ByUCQJ9X9WtW4J6toPInKFXr3HaLlhdQZBeljhB/1hXsRlzjgYd+VrTq2E/MwXsqlb3dWadXloA7+x4ID/FYZLc2a+1jBTgFk9KTm9KmburbK6IkvG4Kh7LyG4hi4NWRPtZXh/g5vNHUg2+BGXmED4mz3C7Jw297cJK5qVo2b+0x5YTiVyRF/WNO6WWS7iYtkVBOMfLDnsXI+CHN0x49r/y/ArlJNcjYypMQcvcNdh8AZ5/PQ8jikwKUxQmoTB0bwJ3Phws6g2y8YDWQ/TEQ8O5v+3hocm8S+AB3rC2FYLZwvGfO9KwN+7xH9Wd/5t+mX6FrZTZgFgf3vZwS+gy/0A==; 20:LGjfiJG0bKKRlybqRBZHZBa39s+SN3hM3d1KtAgl8kX1/wmynwO5uzNtT09LB9QSSmo1+U3WT0uO9Njzfcq9svJ3Ml7LH76fpOXHCjJW6urdsmXlNO4SYFPS1XXAnT3QGQiMYZcT6r9DYqvzPNnetkG/+TPljVyisF4v7pmUc84= X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2017 22:51:10.0315 (UTC) X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=b61c8803-16f3-4c35-9b17-6f65f441df86; Ip=[63.163.107.21]; Helo=[milsmgep15.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1209 Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Initialize .data_direction to DMA_NONE in iscsit_allocate_cmd() such that the second argument of __iscsit_free_cmd() can be left out. Note: this patch causes the first part of __iscsit_free_cmd() no longer to be skipped for TMFs. That's fine since no data segments are associated with TMFs. Signed-off-by: Bart Van Assche Cc: Hannes Reinecke Cc: Christoph Hellwig Cc: Andy Grover Cc: David Disseldorp Reviewed-by: Hannes Reinecke --- drivers/target/iscsi/iscsi_target.c | 4 +--- drivers/target/iscsi/iscsi_target_util.c | 29 +++++++++++++---------------- drivers/target/iscsi/iscsi_target_util.h | 2 +- 3 files changed, 15 insertions(+), 20 deletions(-) diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c index 26a9bcd5ee6a..083e6228c99d 100644 --- a/drivers/target/iscsi/iscsi_target.c +++ b/drivers/target/iscsi/iscsi_target.c @@ -488,15 +488,13 @@ EXPORT_SYMBOL(iscsit_queue_rsp); void iscsit_aborted_task(struct iscsi_conn *conn, struct iscsi_cmd *cmd) { - bool scsi_cmd = (cmd->iscsi_opcode == ISCSI_OP_SCSI_CMD); - spin_lock_bh(&conn->cmd_lock); if (!list_empty(&cmd->i_conn_node) && !(cmd->se_cmd.transport_state & CMD_T_FABRIC_STOP)) list_del_init(&cmd->i_conn_node); spin_unlock_bh(&conn->cmd_lock); - __iscsit_free_cmd(cmd, scsi_cmd, true); + __iscsit_free_cmd(cmd, true); } EXPORT_SYMBOL(iscsit_aborted_task); diff --git a/drivers/target/iscsi/iscsi_target_util.c b/drivers/target/iscsi/iscsi_target_util.c index 7d3e2fcc26a0..41b9e7cc08b8 100644 --- a/drivers/target/iscsi/iscsi_target_util.c +++ b/drivers/target/iscsi/iscsi_target_util.c @@ -167,6 +167,7 @@ struct iscsi_cmd *iscsit_allocate_cmd(struct iscsi_conn *conn, int state) cmd->se_cmd.map_tag = tag; cmd->conn = conn; + cmd->data_direction = DMA_NONE; INIT_LIST_HEAD(&cmd->i_conn_node); INIT_LIST_HEAD(&cmd->datain_list); INIT_LIST_HEAD(&cmd->cmd_r2t_list); @@ -711,19 +712,16 @@ void iscsit_release_cmd(struct iscsi_cmd *cmd) } EXPORT_SYMBOL(iscsit_release_cmd); -void __iscsit_free_cmd(struct iscsi_cmd *cmd, bool scsi_cmd, - bool check_queues) +void __iscsit_free_cmd(struct iscsi_cmd *cmd, bool check_queues) { struct iscsi_conn *conn = cmd->conn; - if (scsi_cmd) { - if (cmd->data_direction == DMA_TO_DEVICE) { - iscsit_stop_dataout_timer(cmd); - iscsit_free_r2ts_from_list(cmd); - } - if (cmd->data_direction == DMA_FROM_DEVICE) - iscsit_free_all_datain_reqs(cmd); + if (cmd->data_direction == DMA_TO_DEVICE) { + iscsit_stop_dataout_timer(cmd); + iscsit_free_r2ts_from_list(cmd); } + if (cmd->data_direction == DMA_FROM_DEVICE) + iscsit_free_all_datain_reqs(cmd); if (conn && check_queues) { iscsit_remove_cmd_from_immediate_queue(cmd, conn); @@ -738,23 +736,22 @@ void iscsit_free_cmd(struct iscsi_cmd *cmd, bool shutdown) { struct se_cmd *se_cmd = NULL; int rc; - bool op_scsi = false; + /* * Determine if a struct se_cmd is associated with * this struct iscsi_cmd. */ switch (cmd->iscsi_opcode) { case ISCSI_OP_SCSI_CMD: - op_scsi = true; /* * Fallthrough */ case ISCSI_OP_SCSI_TMFUNC: se_cmd = &cmd->se_cmd; - __iscsit_free_cmd(cmd, op_scsi, shutdown); + __iscsit_free_cmd(cmd, shutdown); rc = transport_generic_free_cmd(se_cmd, shutdown); if (!rc && shutdown && se_cmd->se_sess) { - __iscsit_free_cmd(cmd, op_scsi, shutdown); + __iscsit_free_cmd(cmd, shutdown); target_put_sess_cmd(se_cmd); } break; @@ -766,18 +763,18 @@ void iscsit_free_cmd(struct iscsi_cmd *cmd, bool shutdown) */ if (cmd->se_cmd.se_tfo != NULL) { se_cmd = &cmd->se_cmd; - __iscsit_free_cmd(cmd, true, shutdown); + __iscsit_free_cmd(cmd, shutdown); rc = transport_generic_free_cmd(&cmd->se_cmd, shutdown); if (!rc && shutdown && se_cmd->se_sess) { - __iscsit_free_cmd(cmd, true, shutdown); + __iscsit_free_cmd(cmd, shutdown); target_put_sess_cmd(se_cmd); } break; } /* Fall-through */ default: - __iscsit_free_cmd(cmd, false, shutdown); + __iscsit_free_cmd(cmd, shutdown); iscsit_release_cmd(cmd); break; } diff --git a/drivers/target/iscsi/iscsi_target_util.h b/drivers/target/iscsi/iscsi_target_util.h index 9e4197af8708..425160565d0c 100644 --- a/drivers/target/iscsi/iscsi_target_util.h +++ b/drivers/target/iscsi/iscsi_target_util.h @@ -37,7 +37,7 @@ extern void iscsit_remove_cmd_from_tx_queues(struct iscsi_cmd *, struct iscsi_co extern bool iscsit_conn_all_queues_empty(struct iscsi_conn *); extern void iscsit_free_queue_reqs_for_conn(struct iscsi_conn *); extern void iscsit_release_cmd(struct iscsi_cmd *); -extern void __iscsit_free_cmd(struct iscsi_cmd *, bool, bool); +extern void __iscsit_free_cmd(struct iscsi_cmd *, bool); extern void iscsit_free_cmd(struct iscsi_cmd *, bool); extern int iscsit_check_session_usage_count(struct iscsi_session *); extern void iscsit_dec_session_usage_count(struct iscsi_session *);