From patchwork Thu May 4 22:50:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 9712887 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 22B8B6038F for ; Thu, 4 May 2017 22:51:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 17DA028639 for ; Thu, 4 May 2017 22:51:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0C8F3286A9; Thu, 4 May 2017 22:51:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8BC5328695 for ; Thu, 4 May 2017 22:51:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753195AbdEDWvs (ORCPT ); Thu, 4 May 2017 18:51:48 -0400 Received: from esa1.hgst.iphmx.com ([68.232.141.245]:40817 "EHLO esa1.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753157AbdEDWvZ (ORCPT ); Thu, 4 May 2017 18:51:25 -0400 X-IronPort-AV: E=Sophos;i="5.38,289,1491235200"; d="scan'208,223";a="117845882" Received: from mail-dm3nam03lp0018.outbound.protection.outlook.com (HELO NAM03-DM3-obe.outbound.protection.outlook.com) ([207.46.163.18]) by ob1.hgst.iphmx.com with ESMTP; 05 May 2017 06:51:11 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Dr5e30PIWU6FchoXJNohA7N1PRCBunAJouILT+viiqY=; b=AsxL9NUppY12J7hRrWafrD3Z7QUjbbKk9IUEQtFUOZ31MWcufFuVb+PCEVc1C8WFLRvIydpbQ6kW26dBULaMfjyPg8KlIjX/fHE/IxJqYVHKAymC8a9c9Ctk5IEAvXWzx/KA7W4zATKiRRPhfUkc/yPSGcFuVuVs+osbL0HRLXk= Received: from BN3PR04CA0036.namprd04.prod.outlook.com (10.166.70.174) by BY1PR0401MB1547.namprd04.prod.outlook.com (10.162.109.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1061.12; Thu, 4 May 2017 22:51:09 +0000 Received: from BN3NAM04FT057.eop-NAM04.prod.protection.outlook.com (2a01:111:f400:7e4e::207) by BN3PR04CA0036.outlook.office365.com (2a01:111:e400:7a4f::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1075.11 via Frontend Transport; Thu, 4 May 2017 22:51:08 +0000 Authentication-Results: spf=pass (sender IP is 63.163.107.21) smtp.mailfrom=sandisk.com; lst.de; dkim=none (message not signed) header.d=none;lst.de; dmarc=bestguesspass action=none header.from=sandisk.com; Received-SPF: Pass (protection.outlook.com: domain of sandisk.com designates 63.163.107.21 as permitted sender) receiver=protection.outlook.com; client-ip=63.163.107.21; helo=milsmgep15.sandisk.com; Received: from milsmgep15.sandisk.com (63.163.107.21) by BN3NAM04FT057.mail.protection.outlook.com (10.152.93.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.1047.9 via Frontend Transport; Thu, 4 May 2017 22:51:07 +0000 Received: from MILHUBIP03.sdcorp.global.sandisk.com (Unknown_Domain [10.201.67.162]) (using TLS with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by (Symantec Messaging Gateway) with SMTP id 07.D4.29323.A50BB095; Thu, 4 May 2017 15:51:06 -0700 (PDT) Received: from milsmgip11.sandisk.com (10.177.9.6) by MILHUBIP03.sdcorp.global.sandisk.com (10.177.9.96) with Microsoft SMTP Server id 14.3.319.2; Thu, 4 May 2017 15:51:04 -0700 X-AuditID: 0ac94369-548749800000728b-f4-590bb05a819a Received: from exp-402881.sdcorp.global.sandisk.com ( [10.177.8.100]) by (Symantec Messaging Gateway) with SMTP id 82.F0.11415.850BB095; Thu, 4 May 2017 15:51:04 -0700 (PDT) From: Bart Van Assche To: Nicholas Bellinger CC: , Bart Van Assche , Hannes Reinecke , "Christoph Hellwig" , Andy Grover , David Disseldorp , Subject: [PATCH 04/19] target/fileio: Avoid that zero-length READ and WRITE commands hang Date: Thu, 4 May 2017 15:50:47 -0700 Message-ID: <20170504225102.8931-5-bart.vanassche@sandisk.com> X-Mailer: git-send-email 2.12.2 In-Reply-To: <20170504225102.8931-1-bart.vanassche@sandisk.com> References: <20170504225102.8931-1-bart.vanassche@sandisk.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHLMWRmVeSWpSXmKPExsXCddJ5kW7UBu5Ig71frCz2z3rGZPH1/3QW iwVv9rJZrFx9lMmibfUZRosFGx8xWrQufcvkwO5xf/sRJo/dNxvYPN7vu8rmsX7LVRaPzaer PT5vkgtgi+KySUnNySxLLdK3S+DKuPHwBmvBPO6KfXPOMDYwHubsYuTkkBAwkXjT+ICxi5GL Q0hgKZPEus3X2EESQgJbGSVOzOTuYuQAK3p1RRqiZjOjxP81r8Bq2ASMJL69n8kCYosI6EjM uvuCHaSIWeAro0Tj3r9MIAlhgUiJ7V82gTWwCKhIPD3/gxHE5hWwk/j3aC0jxBXyEme37GQG sTkF7CX2zrjPBHGEncSa/s1g10kIrGOVaJzSxgbRLChxcuYTsM3MAhISB1+8YIZoUJc4uWQ+ 0wRGoVlIymYhKVvAyLSKUSw3M6c4Nz21wNBUrzgxLyWzOFsvOT93EyMkFjJ3MN594n2IUYCD UYmHd4Ebd6QQa2JZcWXuIUYJDmYlEd6IFUAh3pTEyqrUovz4otKc1OJDjNIcLErivOdkpkYI CaQnlqRmp6YWpBbBZJk4OKUaGG1Wub9Zsk5Saf+mU+2Rn5kCrwv9bPZZEXdZaIO9clL5c8dL DBxrntjde5AnvP3e/79Jz5xMt0so5l11fsThpyDuyWEQkT/1ZjszO8ODJXWL3blTSyX3nxZJ 0pzA9YFX89VMKSdvj60Ov/LFpHUqzYMDetvO7atpWht2XjZBZaWFzrqGBu5lSizFGYmGWsxF xYkAqo1OKoECAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDJMWRmVeSWpSXmKPExsXCtZEjRTdiA3ekweojmhb7Zz1jsjj4s43R 4uv/6SwWC97sZbNYufook0Xb6jOMFgs2PmK0aF36lsmBw+P+9iNMHrtvNrB5vN93lc1j2prz TB7rt1xl8dh8utrj8ya5APYoLpuU1JzMstQifbsErowbD2+wFszjrtg35wxjA+Nhzi5GDg4J AROJV1ekuxi5OIQENjJKPDk5k7mLkZODTcBI4tv7mSwgtoiAjsSsuy/YQYqYBb4zSlybt4cJ JCEsECmx/csmdpBBLAKqEic+GYGYvAJ2Et/3uYBUSAjIS5zdshNsJKeAvcTeGffBOoWAStb0 b2acwMi9gJFhFaNYbmZOcW56ZoGhoV5xYl5KZnG2XnJ+7iZGcPhwRu5gfDrR/BAjEwenVAPj 1jPC82ZZqm6Q37i10erw2aTp0w8JzLN8asjCODn8wKvKuxPOFLC/ChBzrw6cu+16I3P3NfNZ y08p17ZqHLFUDmypeqQvucjOaPYLtii7rewWrOvWtr+O1OU66PtNM+RcreM+N68di16q/ja9 NLFSLDr23OfX1aHlXC4HudLsmN5bJTApHN+gxFKckWioxVxUnAgAyaQBa88BAAA= MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:63.163.107.21; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10019020)(39410400002)(39850400002)(39400400002)(39840400002)(39450400003)(39860400002)(2980300002)(438002)(199003)(189002)(9170700003)(76176999)(6916009)(86362001)(305945005)(6666003)(2950100002)(81166006)(48376002)(478600001)(33646002)(77096006)(8676002)(38730400002)(1076002)(2906002)(50466002)(50986999)(4326008)(5660300001)(36756003)(5003940100001)(53936002)(54906002)(47776003)(50226002)(106466001)(110136004)(356003)(8936002)(189998001); DIR:OUT; SFP:1102; SCL:1; SRVR:BY1PR0401MB1547; H:milsmgep15.sandisk.com; FPR:; SPF:Pass; MLV:sfv; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN3NAM04FT057; 1:41O9340Wi3Gzab/GjnYZVZj3DP1qwchTvNYEwu3YXYGzUKC+xHAUELY5GycwSXgNbjG0pmtvOoBcIjVuiyPm8gAK4anTNBRJGpYb0sQC2nBxEXw1BWAQ/jht2LCsHLjd5Jvpv8sId74OGTBoFf7DBMw8HB7S3dpfAWx3EIGbQt2DPgMGc/2v+NQPeT+p/eiGRIfVRPaFOzqUzTa7DZX+ziG1GGW/AqWmhr503C9bC6dbyM9HHZeMb7+LfgahgEAOOK6nK4UF2heERMqiq0DkeO2Cqv7cdh3Wsffjs3GhTjFh93lj336vhhwYm7hG0faM6aOjoaRXeujLnNyJJivfg1v+8EkL5xo7SnMBXgfyAPxfxJK4bsD+I1jG1MZmX75RRhXItMO78B5M2AJxqcPbt1Quhd16h1qFdQm1UHm8Xq6qsV1eUb7bImDdXyFQU27ZoZbDQ/amdjhxPgM/nUcEkQcRVfbyoCNaM2wO8jdEMJ5koyo2Oi9yBJUXMyX0/F4CH+JKlkpQ4L7+xmiYNugrBHSChrzyq25BJJWlXlw4rCk= X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e27831e6-ada8-4c6e-d9df-08d493400dbc X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(8251501002)(2017030254075)(201703131423075)(201703031133081); SRVR:BY1PR0401MB1547; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0401MB1547; 3:s0GAEn8y+QLioeXhtN95t90eLPdePRpXViee/smmf3w3rv9uNrKyRLI2GUYuLl+k40JjIfA+bXq0PWT+wTtFCN4HOgZjOBPhZgxLu391GLHd+ulQ5pMb0adyfZDD11Ybdrj5+8xEZQ1bnrFbs/3raDjISoqYOHQGesiXz6MtCGp8iA4KxEVxvCEPTwGrzkFFuIjGS05AS5nyvhlbZ4x0yn5m4lqIHdmjm4W1Fqlp6SNznRDZosbsl1mTFbr0B2Znoh3hQlTM+YeVsro68qgABjZOtUA/umta2oGOtkmf0iQuhUwWfoDFrCnzWTUDj7eMi8tQchi8CHqYJYrv3+vhBycRMOLm6tzeCemTfOB7s9NyqdaASsOzgqMy98h5mMHB5raukDPh0F6eNjXglbXpvHn7H5CfZ9rpbaWm/XZ11zEwHdzH7C8WRRUbXnDCGaBkZ5cd3pgnoK+0AF3c86WPzWaYfkLIaiUWjengEUJwdmaIFQik7v2v5Pna+mdaP7Te X-Microsoft-Exchange-Diagnostics: 1; BY1PR0401MB1547; 25:EKEV1ZVUQv6OI4RXOpDpC88T/X0Ij8o7x28LB94JKO9APQjG4UmSReKRCWlY+FSylMiFWNqh7bRb0T1GqX9BGGPjzmE+SiZLOnqPlzAcxIa5rN9sq2EKMk8fvEglytcUJNO2g3GEmCmkrYs1FLvBVKkyA+0vnWTqxL+RACWs3GOiF+/EFGmC0aPxf7wJI0sa26Pk7WX49DGaUjQc2VahzFSaaGI6Wlfz/kAdf4jBL0wSyisCHL3JhzJUnBtpJSEOrAbSQN/XiZF0ITBdsr5U8x4avrFESC9XmhBrOFwKLRjzHG1zaRYYrXgk4fnMb4LGItH+rSwU21r5Gt3y8YmcyOObVjyz6exx5UBmpZUhnJ/1gSi7tE/xvAx3fZWMV/TzoZI8Yzn3A6RWlQjGbuxszwb7yjjljNbUvQacnO/MmgZKPHhUudSd1XkAKeqD5acHbuHXrT1EU6A7XFfYSFOxlQ==; 31:XVWxBma+Toqh7tdzqeOdl4RDbz9Ngs3G+TAekfmYqbOmPtcLseJAqZcPtMArE/iY38jl5Hj4q0waVZF/J7/yvvQ4YvBDYWXErwrQYo0ptHVURVfUyxBOQmOuknxt+pK4EFkSrA8oYFBOInVXLv7UdAEjtzpvIXPIz6HaafPJdaLx4z6V5KzddTX5GCrOBgdEXL/qqMgKlUWfcOAa8c/nJYZ1WbJ9w5VVsfLjw53cxiqyx56FPMftp2pDe9si7/LADIXH9/hfkFumVPtyugMrjw== WDCIPOUTBOUND: EOP-TRUE X-Microsoft-Exchange-Diagnostics: 1; BY1PR0401MB1547; 20:eT7h64OmyidYa0Ii18bGIW1DWSXzJQp023F49R7cBLhIJIkaGDEXX9RMKZANFgwq55SkCA/J1uHCPZZxbiyze5uRMGbmO3DQ32GEk5xjlQs6PMw48aTDOz21vfrb2jAs8R3Zow5yV57tZfzaGB4w7oNkkUP/8tv3eQz2kVTRYd5kAAeHoSd4qu8eRu0trEZnqflm6TlcwsNzWOmKH5bFT5q/e+THpReG4aO3iH7diAumiKOqDFl5dwk0/N4qGzxPm3USFCt8D1NkXOP7Rf5LXJRDUDD11yHkrnJEsc3oRGDX2eKSyl6QtVu9F3NZWiQPH/16tzxEHtk6IhplMDBqJYxwCypO17zqJ4MWCEyTEeJp5yDxV57jZrHny/sq1B34nnzwHjGuH7tn4GaPz17cfSuHa4AoRbi2PVz1HgOdtENz0PikxWfcY+dmXwfpnAZOzdXS3AnP7oud3h+N/snYYdFC4pFG20rkySVxSH/7CZuVF+GF1cRhAjexHtyqaKnR X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055)(42932892334569); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(13018025)(8121501046)(13016025)(5005006)(93006095)(93004095)(3002001)(10201501046)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(20161123558100)(20161123560025)(20161123562025)(6072148); SRVR:BY1PR0401MB1547; BCL:0; PCL:0; RULEID:; SRVR:BY1PR0401MB1547; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0401MB1547; 4:FYhaK/lDCs8vbKHwN45gYLLaF/swc0I0jXt1naqPT170Sx/AZZ8EMTJJAzPPQGnQO8O9N+s8awLr+8uWp3beUpMkW0Bbn4Ganzt1LCBaT+AjtUKl8U58lrbQWGIB2lhY6atIahfQEN1d9WgmBmYsSGEVZNuVuuCewCnFLLce8uXpLGr/NW7KP2qtALhmAsY0J7SohFWUaEvdJBBWvOkwbu71hU4OD7MXg+IHh8cBeTFzRT6YOeCEkEHQCa5W0Wahkplwk1jTGsf8jQfivTQaMB/r2/301EA5IGLJupB3Nx8/3olYTm8ICNP6AjDvF9uhy+hrwzxlRHtooi7B49wFrtHq/RxDy48POv4VClFi9tbZvGG5E6IvhmDiCWx6hR0qt773lIGnmTRG/kTRcXObBOuxALQYIJ9lImady+WCZE4eab4vqFB5hS6tjkaC8euAqtP2ufa7XRV5YOIM0cVKWLWE8INtZtL2gFJCr4kvlOETUnOPh8ojM3VHORw/tghvRBrQtjsV6XLSJMF6x/YRLFqwBRfeZvVbUbjqj7K1AKcNaYa7IAzNiB8sT3cT2AEuD//Yez0cyd50fq+a1ji8gq6TgMYZdHHvtcsiTi9NSoLFDhGbCJuGMILvB2L0gn+wDA7d8jTgrOnRkNpyqWSn8CtAE1evYFdv15BlLusbwh2aB680JOVgFeGun9StnPuUuPYYox/PuvMKIuelyZE64FfH4gRmFne9/48pGgP+jNWNy13XLJ5a/E+OeW7K0vTRQqhWQhx7CXNbY+9IahScTK1QwbdB2taFoRfEg0iBIG5pxlCIlEvlS08LdeX2V8PehydjA8Pu/88KwsgnEhGQcSqmcTIc1tCVkBvIpJRlh77rnc1/7ZyJw5Aok9VpWpr+FI24oQtjDsdLd6gSb1vUubY8S7nDej0PgagqNWnd L6g= X-Forefront-PRVS: 02973C87BC X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY1PR0401MB1547; 23:PW3BXXkOlTz0sJQ9Ztx99exi1ekjj9ZkduvzXgw?= =?us-ascii?Q?P4fPxfOVGrvEOoeRn0pxzt1GZ3Mtc0RwSsBe7Z24jSjeqafMRad1Z/fbvpVO?= =?us-ascii?Q?6u5ZVrN+4uN7QPuwuXuptuSt5uMhcdwfIpfh7uHMajhfpbdNV58ZoLxvxXO/?= =?us-ascii?Q?qn+iv01aEoV9m4+qbXNSl1FPc29Rcd8n8+fW1JsX6PjqUo9ky++GTC9bUOhN?= =?us-ascii?Q?I7uzoYx1eHcFwRrtSByh83vPdAB2FWPK4MxmfgGU4QfiYLD6TQoFoOALdUBZ?= =?us-ascii?Q?nbo8xQ8cp6vGrFrMPB9luCAqpszumPwa6ZYEG47eOq/tw2cwEEHPOt8A02IX?= =?us-ascii?Q?CeireOUUZaY5VtcE5iRCCQ33genU+8SNve92PMj5NEZNOCpzRQRXyKbvwiFR?= =?us-ascii?Q?QR23jE6E80PmUOVD8UdB40ljGS9eKiWepXs3Zg+mW1xQplO1HwCCRWm3AfLp?= =?us-ascii?Q?FO5f08kZCS1sglvnrg7TwPSsAUuzsw+QNJdpyjaPiyLlHLkwQkgHTXkPTwJB?= =?us-ascii?Q?RFEoOtq2Kf0wKpSNxbTpVpQiQuDwD80vxv7JplcgfkdDpwILN1JqDs7zdfMq?= =?us-ascii?Q?89ijzzQidFvacrz6pRDbWHt8iUt6giSFcF4SfXWpcyRvAdMz2nBMjRIWJb3t?= =?us-ascii?Q?yxRvbXaNd6mdkatat0dDLrqq4tVIBSSZhWTj2sRirez0QPZa983IZI9tFwVf?= =?us-ascii?Q?vv4O+MIiq2jdQLRnNwZvW/HnIjn8DMszBy0dZCoDgtuOSO5dsgOHmfB0E/Hx?= =?us-ascii?Q?ibWIcZKLb2/fr2Amd/mkDpdpIU5JWZEQzn100Abvb7uttL1UOaWlyLDpFdr0?= =?us-ascii?Q?GWoP9ax0zSGrGqwz1M07JMfNEi1f7OPdfPf7XxfUyypIAiu56e3awVafGfvi?= =?us-ascii?Q?Ej2mWPGXTq+SI8ciSOmctxD/NybCyTEyNbsp3zsG6iFRs4IvmasfdPMw+3wY?= =?us-ascii?Q?RBnXMhkUmm0VvvSfTxjCGAC8JJ2mfA5kLEMTN8kk3wVgCGAlgktMM3UZzhJO?= =?us-ascii?Q?m+yXrdhXaUaQjgc6vrNs/ClRHVhMdE9CL3BbdZ3qtD4Kq4jiPfOw5OGSKgzJ?= =?us-ascii?Q?MDb3xcxM=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY1PR0401MB1547; 6:zYvqSzJ9mT3Ew1Vw/f8Vs8rWKvaD2HUb4gvITcsgwqeXBIjWudXoq6x9/od1qt4xjYnrwmoivjzzkDcPVPADPnUuSlBgizC9p5wSEAw8ftS3fu1h3NJLaEWNKFSll9zi7Hpa4w2ZWh5VgYnfnooxaMmfiGGxqBkziLTKkJw+ToVurgx2kcnOmBKyjsTFMtdAV4vUGxvJQWHRIXSRl1lj+RgzayI2l4bjyeIbhFZ6pY3ZMroDZRxkZiZPScxRsuU0gkL3YhEJ+TYsbM8BABoGHQT0YqI+Ax9cZrUlehwYtbX+M6WEpLWQsJIhtWr5qwh2wBbpWK/XzRpB/dBytc4KAQDtaep2Wl07MQJqfK5YAsD92WFGLVkKj2CKEJzhx7wF4K054rMn9KiF1HcgWkm3ULEi5ZYUG3DUQdR+Wa8xVbRaBflNOEzVBAkINhDGPXxGrSBBQd4+TgAF9YO8ISCeFoPwiRG7fdjpDv35ratuFi480Ur9H95QYTs+4cn6yQC4P2bxO0dKL8iXaTbcfVyo2kFThh5gsydXSm5N2vU3x8Y=; 5:DxL39XI6VIgMk/sJ2iebzLAAPtGyt4MkgtKpBM+eU009QOIgG6+b+FsPjvdhGtON1bjo63pWBbTFMmpRy7tgZAioU/n6Zo+nWwExgmmd77nrNJT3KoiTVNjXq6OrAByaWW8vQplofUVy3IP+o1RHSg==; 24:E1thRmTrjM0HYgFlVKk/qh0QfBAt82jaMR3K/xlo3+DaK580pzplfXcyXKz1jxk+Hm3ViGQTPT9JG8yaZKXRDya2w0+m9PFWg4GMhDU6sxQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY1PR0401MB1547; 7:/rxmxnIuksHJXPl6eiGOr3Bvk+rIr41X3RnKFNwkoszcUHIJJ8ab4j883qnFRkme7to4yaRGrCB7QTo/tzO92VONaOD2JoupsKfyTgOpWKwqT5WXnTqU21W+aK1oULFy9+dB0ndnOxYQos1pCbQ3MJksqSBRvQMWSWbBw5q9DgCc9WQ61W1QER8AhCgBP3fM6b6Qw9zfyvXplMb+1vPrOIl9/qaJ3IChd1hFgm1wF8RKMIr7Z5sRVn7Av4CAQj+BJbcaU3viNVKoB7/s+GR4g+ngYFSZ3sTtZiJ1Nb6heSG/v5CVzOEoJYfTJz6PsIwUVk2AqRTTDPnDvAJLjLP79Q==; 20:tKbWI6qom89NIktYTePOSCULMYMyikLHM8Uop8N/fnsZeYQ+guv+gppntkrsiOPNFrGK6O5jMpiFxm1VqwCHhldrbVk62hqg1FpWI6wCYG/EusD6uT7RY7VGRBRTu0diGYynfl+a2pEQOLoBpqiH23aQ/i2VHvKgPQ95fJqFN2A= X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2017 22:51:07.7346 (UTC) X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=b61c8803-16f3-4c35-9b17-6f65f441df86; Ip=[63.163.107.21]; Helo=[milsmgep15.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0401MB1547 Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From __target_execute_cmd() (simplified): ret = cmd->execute_cmd(cmd); if (ret != 0) transport_generic_request_failure(cmd, ret); From sbc_execute_rw(): return ops->execute_rw(cmd, cmd->t_data_sg, cmd->t_data_nents, cmd->data_direction); This means that sbc_ops.execute_rw() must either return a non-zero value or call target_complete_cmd() and return zero or command execution stalls. Make sure that fd_execute_rw() calls target_complete_cmd() even for zero-length commands. Fixes: commit c66ac9db8d4a ("[SCSI] target: Add LIO target core v4.0.0-rc6") Signed-off-by: Bart Van Assche Cc: Hannes Reinecke Cc: Christoph Hellwig Cc: Andy Grover Cc: David Disseldorp Cc: Reviewed-by: Hannes Reinecke Reviewed-by: Christoph Hellwig --- drivers/target/target_core_file.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/target/target_core_file.c b/drivers/target/target_core_file.c index 1bf6c31e4c21..73b8f93a5fef 100644 --- a/drivers/target/target_core_file.c +++ b/drivers/target/target_core_file.c @@ -608,8 +608,7 @@ fd_execute_rw(struct se_cmd *cmd, struct scatterlist *sgl, u32 sgl_nents, if (ret < 0) return TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; - if (ret) - target_complete_cmd(cmd, SAM_STAT_GOOD); + target_complete_cmd(cmd, SAM_STAT_GOOD); return 0; }